From patchwork Tue Apr 9 09:43:53 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 17843 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UPV5q-0005pZ-Lt; Tue, 09 Apr 2013 11:43:58 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp id 1UPV5p-000206-Cr; Tue, 09 Apr 2013 11:43:58 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935246Ab3DIJn4 (ORCPT + 1 other); Tue, 9 Apr 2013 05:43:56 -0400 Received: from mail-bk0-f48.google.com ([209.85.214.48]:35744 "EHLO mail-bk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935034Ab3DIJnz (ORCPT ); Tue, 9 Apr 2013 05:43:55 -0400 Received: by mail-bk0-f48.google.com with SMTP id jf3so3432755bkc.7 for ; Tue, 09 Apr 2013 02:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to:cc :content-type; bh=ib30pJHO2gLfcrbfyihrGtbhbkCGQu/TUfm1db3lUdo=; b=Ad+graDAH9z7/5x8BYWM2jRzIXkrsozWPyUqVqvcelTaPCu0vfVhOSzGJ3cSXlCBQp uqRT9/RKfbo9A+4vBQvm9DdMPuc+3s6pwnXI3n0W4zfK/8lzJArIjJaB65ej6fhyNeOF OrBMgiR0h2n+Fa3EszBdEllvl+BhvpPaAG63XlIjL9F2XaSHrSrBu0LeXde3y+/NbTqr jvF9gtYEfIIp18yMh8SXROfeeANK6TvsdrR2zVCYXXZlhirPjbyYJKLwwFrCyCjIn0Db haEt7c31gI2UCjo5ssUKroaDOnrMQppcl44BE2pOrClACWPdbwNBRt3UU9ziGQkpFw6e yfnw== MIME-Version: 1.0 X-Received: by 10.205.114.136 with SMTP id fa8mr12343907bkc.48.1365500634003; Tue, 09 Apr 2013 02:43:54 -0700 (PDT) Received: by 10.204.30.210 with HTTP; Tue, 9 Apr 2013 02:43:53 -0700 (PDT) Date: Tue, 9 Apr 2013 17:43:53 +0800 Message-ID: Subject: [PATCH] [media] rc: ite-cir: fix potential double free in ite_probe() From: Wei Yongjun To: mchehab@redhat.com, matthijs@stdin.nl, ben@decadent.org.uk, david@hardeman.nu, jarod@redhat.com Cc: yongjun_wei@trendmicro.com.cn, linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.4.9.93323 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' CN_TLD 0.1, FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DATE_TZ_HK 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_RCPTS_TO_X5 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Wei Yongjun Since rc_unregister_device() frees its argument, the subsequently call to rc_free_device() on the same variable will cause a double free bug. Fix by set argument to NULL, thus when fall through to rc_free_device(), nothing will be done there. Signed-off-by: Wei Yongjun --- drivers/media/rc/ite-cir.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c index dd82373..63b4225 100644 --- a/drivers/media/rc/ite-cir.c +++ b/drivers/media/rc/ite-cir.c @@ -1613,6 +1613,7 @@ exit_release_cir_addr: release_region(itdev->cir_addr, itdev->params.io_region_size); exit_unregister_device: rc_unregister_device(rdev); + rdev = NULL; exit_free_dev_rdev: rc_free_device(rdev); kfree(itdev);