From patchwork Fri Oct 25 09:34:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 20473 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VZdmU-0002Zd-Cd; Fri, 25 Oct 2013 11:34:10 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1VZdmS-0000fr-3s; Fri, 25 Oct 2013 11:34:09 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595Ab3JYJeF (ORCPT + 1 other); Fri, 25 Oct 2013 05:34:05 -0400 Received: from mail-ee0-f42.google.com ([74.125.83.42]:35617 "EHLO mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573Ab3JYJeE (ORCPT ); Fri, 25 Oct 2013 05:34:04 -0400 Received: by mail-ee0-f42.google.com with SMTP id b45so2308142eek.1 for ; Fri, 25 Oct 2013 02:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type; bh=/ZQO0ncfv8hJrEPmpTgR3HJSw7BciD98mssvCoUUiDM=; b=JCp3ywVKTx1Aav0+au5Uxr6+KFAVWm7poBxnsxfxpa/nUqs/lEZh/PVo3PJW3lEKC+ dXVLD7b9tUpm+YgEMqhnU30hppPfFSuhatBGqsIM4mT5+PPUVZtqZ6MmUD5eJ2ndCJdO AXqQGi2DojqQ5vgtss+7tgGPmBa7+PA+tHMikWIhBV4w7pZEPJTBiHr9ej37mpIU8aS8 VvQp97KwSNppZQZu4E3oWr9396N3c3N9K5RXmkyv6dIWUrjn6qp6j0hKojWVggF8DRv+ +crOfGe6LBybPG0xU5z2Y4/i1pqfS1pQjYq+XKYjAdHutP/owPzPi2Rh9SaTONmQATk4 utMw== MIME-Version: 1.0 X-Received: by 10.205.3.7 with SMTP id nw7mr3227717bkb.26.1382693643501; Fri, 25 Oct 2013 02:34:03 -0700 (PDT) Received: by 10.205.19.10 with HTTP; Fri, 25 Oct 2013 02:34:03 -0700 (PDT) Date: Fri, 25 Oct 2013 17:34:03 +0800 Message-ID: Subject: [PATCH] [media] saa7164: fix return value check in saa7164_initdev() From: Wei Yongjun To: m.chehab@samsung.com, hans.verkuil@cisco.com, gregkh@linuxfoundation.org, jkosina@suse.cz, rdunlap@infradead.org Cc: yongjun_wei@trendmicro.com.cn, linux-media@vger.kernel.org Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.10.25.92415 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' CN_TLD 0.1, FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __DATE_TZ_HK 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __MULTIPLE_RCPTS_TO_X5 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' From: Wei Yongjun In case of error, the function kthread_run() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/media/pci/saa7164/saa7164-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c index d37ee37..896bd8b 100644 --- a/drivers/media/pci/saa7164/saa7164-core.c +++ b/drivers/media/pci/saa7164/saa7164-core.c @@ -1354,9 +1354,11 @@ static int saa7164_initdev(struct pci_dev *pci_dev, if (fw_debug) { dev->kthread = kthread_run(saa7164_thread_function, dev, "saa7164 debug"); - if (!dev->kthread) + if (IS_ERR(dev->kthread)) { + dev->kthread = NULL; printk(KERN_ERR "%s() Failed to create " "debug kernel thread\n", __func__); + } } } /* != BOARD_UNKNOWN */