From patchwork Thu Mar 1 16:24:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 47521 Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1erR59-00006h-1J; Thu, 01 Mar 2018 16:29:23 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032935AbeCAQYH (ORCPT + 1 other); Thu, 1 Mar 2018 11:24:07 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:40236 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032698AbeCAQYE (ORCPT ); Thu, 1 Mar 2018 11:24:04 -0500 Received: by mail-oi0-f65.google.com with SMTP id c12so4885274oic.7; Thu, 01 Mar 2018 08:24:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=0MzCbVxVhCxZaN8sbOpyF6Nl+x5vZGjmmPYdkJ0vp6w=; b=jVFzvM77/7lYi9Z0bOhs3C7Md4ATsrYpLRV8WM4jJOWAl47xHV/QPk58cYShEAJhvr k4qjcWPBkDh0Q9MvwED3CT/HzHbLorDyatcXXH11WJH1N7dyoNLS57MFmjEeTyZc2dy2 7D80VSO0DrLA9tWgFsTl5zAZ6wQd8FNLixm/BQhBU5A5fGvDQvSG0hZUkITVduCZDuKw wbUwv94i+aruRwfjJQoIoe1+wzhxYXT1PPra09/ASTdi9YUfhsZ94qr7wLsapVPIUiMy DXDZ549LEU2jArsGNFPljeusd7npK84TKrMlRifdIkkRWW5O9THaK6WN+ISCldh75JAt NLng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=0MzCbVxVhCxZaN8sbOpyF6Nl+x5vZGjmmPYdkJ0vp6w=; b=RIQBbcLilhT659PHE67V037lvCjjfgSpDjKwIkXqP8cfdvz/gpnKWHCUiD3GZSyWjm SXvh8Mk5VhZprQSCJW8gUgJEVj9F9pGN+crkw+xJ5Op5plCBgqjYGaoVHT/jOh2JKUU1 +RXFgucXmpt9CryoOf0z15QbC4wSVNSgFaTGbzalrOUs3dqDF2Sdk5ctIyCDz8LH6Y+L bFRnIev5j8tYdlSzHzx7rrPPkXGG9qJnYeyxNXBm0+gPZNUJyFOJY7cs+VINWYAUe1Lj RPJgWLx4vfqZAByezbPxiFP/+sl7XU3sVRub8JS/A1cFHyWsK5Dki65HQ9gsZV52/Z+d x1Og== X-Gm-Message-State: AElRT7F7XCma4pNLkdc7SeUus67Ikn1mNbbrFnsAk7aQaEK9dW47fsdb PHKkIXVrAcpVjvlQdLDlfuFnnbQNFGFv72QYevM= X-Google-Smtp-Source: AG47ELv5V6S3RR0l9HR8Ycg2G1ww8L8fxCN/UMd+VyFdOfDUOtATNlT0nrQy68aY0nCRNIfMKA+Znt/g02zI0H8TvBA= X-Received: by 10.202.66.130 with SMTP id p124mr1669138oia.198.1519921443800; Thu, 01 Mar 2018 08:24:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.5.137 with HTTP; Thu, 1 Mar 2018 08:24:03 -0800 (PST) In-Reply-To: References: <20180301040939.GA13274@embeddedgus> From: Fabio Estevam Date: Thu, 1 Mar 2018 13:24:03 -0300 Message-ID: Subject: Re: [PATCH] staging/imx: Fix inconsistent IS_ERR and PTR_ERR To: "Gustavo A. R. Silva" Cc: Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media , devel@driverdev.osuosl.org, linux-kernel , "Gustavo A. R. Silva" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Steve, Phiipp, On Thu, Mar 1, 2018 at 1:02 PM, Fabio Estevam wrote: > So imx_csi_probe() does not succeed anymore since > devm_pinctrl_get_select_default() always fails. > > Not sure I understand the comments that explain the need for pinctrl > handling inside the driver. > > Can't we just get rid of it like this? Just tested and if devm_pinctrl_get_select_default() is removed, I am not able to change the ipu csi pinctrl settings anymore. I had to ignore devm_pinctrl_get_select_default() error value so that the driver can probe again: Is there a better solution for this issue? diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 5a195f8..c40f786 100644 --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -1797,11 +1797,8 @@ static int imx_csi_probe(struct platform_device *pdev) */ priv->dev->of_node = pdata->of_node; pinctrl = devm_pinctrl_get_select_default(priv->dev); - if (IS_ERR(pinctrl)) { - ret = PTR_ERR(priv->vdev); - goto free; - } - + if (IS_ERR(pinctrl)) + dev_dbg(priv->dev, "pintrl_get_select_default() failed\n"); ret = v4l2_async_register_subdev(&priv->sd); if (ret) goto free;