From patchwork Wed Nov 23 12:32:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Javier Martin X-Patchwork-Id: 8550 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1RTC0B-0000xo-Ks; Wed, 23 Nov 2011 13:32:36 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-1) with esmtp id 1RTC0A-00072z-LM; Wed, 23 Nov 2011 13:32:35 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752504Ab1KWMcc (ORCPT + 4 others); Wed, 23 Nov 2011 07:32:32 -0500 Received: from mail-yw0-f46.google.com ([209.85.213.46]:48488 "EHLO mail-yw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985Ab1KWMcc convert rfc822-to-8bit (ORCPT ); Wed, 23 Nov 2011 07:32:32 -0500 Received: by ywt32 with SMTP id 32so1294498ywt.19 for ; Wed, 23 Nov 2011 04:32:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.205.135.129 with SMTP id ig1mr24152800bkc.106.1322051549325; Wed, 23 Nov 2011 04:32:29 -0800 (PST) Received: by 10.223.72.14 with HTTP; Wed, 23 Nov 2011 04:32:29 -0800 (PST) In-Reply-To: <20111122205552.GO27267@pengutronix.de> References: <1321963316-9058-1-git-send-email-javier.martin@vista-silicon.com> <1321963316-9058-3-git-send-email-javier.martin@vista-silicon.com> <20111122205552.GO27267@pengutronix.de> Date: Wed, 23 Nov 2011 13:32:29 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] MEM2MEM: Add support for eMMa-PrP mem2mem operations. From: javier Martin To: Sascha Hauer Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com, laurent.pinchart@ideasonboard.com, s.nawrocki@samsung.com, hverkuil@xs4all.nl, kyungmin.park@samsung.com, shawn.guo@linaro.org, richard.zhao@linaro.org, fabio.estevam@freescale.com, kernel@pengutronix.de, r.schwebel@pengutronix.de Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.11.23.122415 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1800_1899 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, WEBMAIL_SOURCE 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_HTTP_RECEIVED 0, __PHISH_SPEAR_STRUCTURE_1 0, __PHISH_SPEAR_STRUCTURE_2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NS ' X-LSpam-Score: -4.2 (----) X-LSpam-Report: No, score=-4.2 required=5.0 tests=BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3 autolearn=ham Hi Sascha, I was just trying to fix the issues you pointed previously and I have a question for you. On 22 November 2011 21:55, Sascha Hauer wrote: > Hi Javier, >> + >> +static int emmaprp_probe(struct platform_device *pdev) >> +{ >> +     struct emmaprp_dev *pcdev; >> +     struct video_device *vfd; >> +     struct resource *res_emma; >> +     int irq_emma; >> +     int ret; >> + >> +     pcdev = kzalloc(sizeof *pcdev, GFP_KERNEL); >> +     if (!pcdev) >> +             return -ENOMEM; >> + >> +     spin_lock_init(&pcdev->irqlock); >> + >> +     pcdev->clk_emma = clk_get(NULL, "emma"); > > You should change the entry for the emma in > arch/arm/mach-imx/clock-imx27.c to the following: > > _REGISTER_CLOCK("m2m-emmaprp", NULL, emma_clk) > > and use clk_get(&pdev->dev, NULL) here. > Is this what you are asking for? If I do that, mx2_camera.c will stop working. Furthermore it does not work for this driver either (I get an error on clk_get() ). --- a/arch/arm/mach-imx/clock-imx27.c +++ b/arch/arm/mach-imx/clock-imx27.c @@ -661,7 +661,7 @@ static struct clk_lookup lookups[] = { _REGISTER_CLOCK(NULL, "dma", dma_clk) _REGISTER_CLOCK(NULL, "rtic", rtic_clk) _REGISTER_CLOCK(NULL, "brom", brom_clk) - _REGISTER_CLOCK(NULL, "emma", emma_clk) + _REGISTER_CLOCK("m2m-emmaprp", NULL, emma_clk) _REGISTER_CLOCK(NULL, "slcdc", slcdc_clk) _REGISTER_CLOCK("imx27-fec.0", NULL, fec_clk) _REGISTER_CLOCK(NULL, "emi", emi_clk)