From patchwork Wed Jan 14 20:05:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Aguirre Rodriguez, Sergio Alberto" X-Patchwork-Id: 381 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Wed, 14 Jan 2009 20:08:08 +0000 Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1LNC23-0000WF-Rj for mchehab@infradead.org; Wed, 14 Jan 2009 20:08:08 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752862AbZANUIG (ORCPT ); Wed, 14 Jan 2009 15:08:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753384AbZANUIF (ORCPT ); Wed, 14 Jan 2009 15:08:05 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:34586 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752862AbZANUIE convert rfc822-to-8bit (ORCPT ); Wed, 14 Jan 2009 15:08:04 -0500 Received: from dlep95.itg.ti.com ([157.170.170.107]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id n0EK7VEr018923; Wed, 14 Jan 2009 14:07:36 -0600 Received: from dlee74.ent.ti.com (localhost [127.0.0.1]) by dlep95.itg.ti.com (8.13.8/8.13.8) with ESMTP id n0EK7VBa006795; Wed, 14 Jan 2009 14:07:31 -0600 (CST) Received: from dlee02.ent.ti.com ([157.170.170.17]) by dlee74.ent.ti.com ([157.170.170.8]) with mapi; Wed, 14 Jan 2009 14:07:31 -0600 From: "Aguirre Rodriguez, Sergio Alberto" To: "mchehab@infradead.org" , "hverkuil@xs4all.nl" CC: "video4linux-list@redhat.com" , "linux-media@vger.kernel.org" , "Curran, Dominic" , "sakari.ailus@nokia.com" , "mikko.hurskainen@nokia.com" , "tuukka.o.toivonen@nokia.com" , "Nagalla, Hari" , "mschimek@gmx.at" Date: Wed, 14 Jan 2009 14:05:40 -0600 Subject: RE: Color FX User control proposal Thread-Topic: Color FX User control proposal Thread-Index: AQHJdoO7AdGaDql2MEabG28fso5uFA== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org > For us to apply, We need also a patch updating V4L2 API docbook. > > Cheers, > Mauro Hi, Should below patch to v4l2spec-0.24 be fine? Regards, Sergio v4l2spec: Add colorFX control documentation This patch adds description for proposed new V4L2_CID_COLORFX user control. Signed-off-by: Sergio Aguirre --- Makefile | 1 + controls.sgml | 11 ++++++++++- videodev2.h | 8 +++++++- 3 files changed, 18 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: v4l2spec-0.24/Makefile =================================================================== --- v4l2spec-0.24.orig/Makefile 2009-01-14 13:30:23.000000000 -0600 +++ v4l2spec-0.24/Makefile 2009-01-14 13:32:14.000000000 -0600 @@ -338,6 +338,7 @@ v4l2_mpeg_videotype \ v4l2_mpeg_videotype \ v4l2_power_line_frequency \ + v4l2_colorfx \ v4l2_prio_state \ ; do echo "-e \"s/ *$$i/\\\\ $$i/g\""; done) Index: v4l2spec-0.24/controls.sgml =================================================================== --- v4l2spec-0.24.orig/controls.sgml 2009-01-14 13:17:18.000000000 -0600 +++ v4l2spec-0.24/controls.sgml 2009-01-14 13:32:53.000000000 -0600 @@ -261,11 +261,20 @@ Adjusts the backlight compensation in a camera. The minimum value disables backlight compensation. + + V4L2_CID_COLORFX + integer + Sets the color effect to be applied to the captured +or displayed image. Possible values are: +V4L2_COLORFX_DEFAULT (0), +V4L2_COLORFX_BW (1) and +V4L2_COLORFX_SEPIA (2). + V4L2_CID_LASTP1 End of the predefined control IDs (currently -V4L2_CID_BACKLIGHT_COMPENSATION + 1). +V4L2_CID_COLORFX + 1). V4L2_CID_PRIVATE_BASE Index: v4l2spec-0.24/videodev2.h =================================================================== --- v4l2spec-0.24.orig/videodev2.h 2009-01-14 13:30:57.000000000 -0600 +++ v4l2spec-0.24/videodev2.h 2009-01-14 13:31:53.000000000 -0600 @@ -879,7 +879,13 @@ #define V4L2_CID_WHITE_BALANCE_TEMPERATURE (V4L2_CID_BASE+26) #define V4L2_CID_SHARPNESS (V4L2_CID_BASE+27) #define V4L2_CID_BACKLIGHT_COMPENSATION (V4L2_CID_BASE+28) -#define V4L2_CID_LASTP1 (V4L2_CID_BASE+29) /* last CID + 1 */ +#define V4L2_CID_COLORFX (V4L2_CID_BASE+31) +enum v4l2_colorfx { + V4L2_COLORFX_DEFAULT = 0, + V4L2_COLORFX_BW = 1, + V4L2_COLORFX_SEPIA = 2, +}; +#define V4L2_CID_LASTP1 (V4L2_CID_BASE+32) /* last CID + 1 */ /* MPEG-class control IDs defined by V4L2 */ #define V4L2_CID_MPEG_BASE (V4L2_CTRL_CLASS_MPEG | 0x900)