From patchwork Mon Mar 19 10:28:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier GRENIE X-Patchwork-Id: 10398 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1S9ZnC-0006Ly-8K for patchwork@linuxtv.org; Mon, 19 Mar 2012 11:26:22 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1S9ZnB-0000AL-BB; Mon, 19 Mar 2012 11:26:22 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754323Ab2CSK0T (ORCPT ); Mon, 19 Mar 2012 06:26:19 -0400 Received: from co202.xi-lite.net ([149.6.83.202]:49592 "EHLO co202.xi-lite.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754117Ab2CSK0S convert rfc822-to-8bit (ORCPT ); Mon, 19 Mar 2012 06:26:18 -0400 Received: from ONYX.xi-lite.lan (unknown [193.34.35.244]) by co202.xi-lite.net (Postfix) with ESMTPS id 623252602AF; Mon, 19 Mar 2012 11:26:15 +0100 (CET) Received: from DIAMANT.xi-lite.lan ([193.34.32.22]) by ONYX ([193.34.32.32]) with mapi; Mon, 19 Mar 2012 10:28:12 +0000 From: Olivier GRENIE To: santosh prasad nayak , "mchehab@infradead.org" CC: "pboettcher@kernellabs.com" , "florian@mickler.org" , "gregkh@linuxfoundation.org" , "linux-media@vger.kernel.org" Date: Mon, 19 Mar 2012 10:28:12 +0000 Subject: RE: [PATCH] [media] dib0700: Return -EINTR and unlock mutex if locking attempts fails. Thread-Topic: [PATCH] [media] dib0700: Return -EINTR and unlock mutex if locking attempts fails. Thread-Index: Ac0FrUKrldIONYCvRyCR9nNIDedNRAAC5PYF Message-ID: <96767C26EA89B648B398B4BCB10B3F635F0FFD779B@DIAMANT.xi-lite.lan> References: <1331901909-4960-1-git-send-email-santoshprasadnayak@gmail.com>, In-Reply-To: Accept-Language: en-US, fr-FR Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US, fr-FR MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.3.19.101815 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' MULTIPLE_RCPTS 0.1, RCVD_FROM_IP_DATE 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MSGID_ADDED_BY_MTA 0.05, BODY_SIZE_6000_6999 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' Hello, I agree with the patch. But you could also add: regards, Olivier diff --git a/drivers/media/dvb/dvb-usb/dib0700_core.c b/drivers/media/dvb/dvb-usb/dib0700_core.c index 1a6ddbc..a271203 100644 --- a/drivers/media/dvb/dvb-usb/dib0700_core.c +++ b/drivers/media/dvb/dvb-usb/dib0700_core.c @@ -178,7 +178,7 @@ static int dib0700_i2c_xfer_new(struct i2c_adapter *adap, struct i2c_msg *msg, /* Ensure nobody else hits the i2c bus while we're sending our sequence of messages, (such as the remote control thread) */ if (mutex_lock_interruptible(&d->i2c_mutex) < 0) - return -EAGAIN; + return -EINTR; for (i = 0; i < num; i++) { if (i == 0) { @@ -272,7 +272,7 @@ static int dib0700_i2c_xfer_legacy(struct i2c_adapter *adap, int i,len; if (mutex_lock_interruptible(&d->i2c_mutex) < 0) - return -EAGAIN; + return -EINTR; if (mutex_lock_interruptible(&d->usb_mutex) < 0) { err("could not acquire lock"); mutex_unlock(&d->i2c_mutex);