From patchwork Fri Apr 13 02:18:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 48641 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f6oID-0002PQ-P4; Fri, 13 Apr 2018 02:18:26 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752690AbeDMCSW (ORCPT + 1 other); Thu, 12 Apr 2018 22:18:22 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:10289 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752512AbeDMCSV (ORCPT ); Thu, 12 Apr 2018 22:18:21 -0400 Received: from unknown (HELO relmlir4.idc.renesas.com) ([10.200.68.154]) by relmlie3.idc.renesas.com with ESMTP; 13 Apr 2018 11:18:20 +0900 Received: from relmlii2.idc.renesas.com (relmlii2.idc.renesas.com [10.200.68.66]) by relmlir4.idc.renesas.com (Postfix) with ESMTP id 389EB7551B; Fri, 13 Apr 2018 11:18:20 +0900 (JST) X-IronPort-AV: E=Sophos;i="5.48,444,1517842800"; d="scan'208";a="278057440" Received: from mail-ty1jpn01lp0179.outbound.protection.outlook.com (HELO JPN01-TY1-obe.outbound.protection.outlook.com) ([23.103.139.179]) by relmlii2.idc.renesas.com with ESMTP/TLS/AES256-SHA256; 13 Apr 2018 11:18:19 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yeH0X8WBMf2G17X9/H5uoqiGt5xKao7SRN9w13CqczQ=; b=KCPanrwFOiBJhOTKMgIMr6bIn05xzm40zfOkDsqh+/51o+HmeSOMkNIarGDX8ffR1gQheRFToMb943IiKd3wA2B3qs+ztmmGqEKRXIBqSp6+5D+OPd0JP5xT077ev49mnPSMuCAeD0nZHxzxLSmrh4D4bbSJLTNqt0GaPKHg9lE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.138) by TYAPR01MB2078.jpnprd01.prod.outlook.com (2603:1096:404:8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.675.13; Fri, 13 Apr 2018 02:18:13 +0000 Message-ID: <87vacv97ik.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH] media: rcar-vin: Fix image alignment for setting pre clipping User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 To: =?ISO-8859-1?Q?=22Niklas_S=F6derlund=22?= , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, Niklas Soderlund , , Magnus , Laurent , shimoda , shiiba , sakato , Kihara , Fukawa , , , , , In-Reply-To: <87bmepxga1.wl%kuninori.morimoto.gx@renesas.com> References: <87tw5iuoqa.wl%kuninori.morimoto.gx@renesas.com> <20170421130432.GT28868@bigcity.dyn.berto.se> <877f2awv7u.wl%kuninori.morimoto.gx@renesas.com> <87bmepxga1.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Fri, 13 Apr 2018 02:18:13 +0000 X-Originating-IP: [211.11.155.138] X-ClientProxiedBy: TY1PR01CA0146.jpnprd01.prod.outlook.com (2603:1096:402:1::22) To TYAPR01MB2078.jpnprd01.prod.outlook.com (2603:1096:404:8::10) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:TYAPR01MB2078; X-Microsoft-Exchange-Diagnostics: 1; TYAPR01MB2078; 3:JiWYZsgetElnK8PQUCiKwmSALTzlhc6zNUBg65n08cfm26cItOLcOntfoO9Yo+5aCUV33KhVA/w0HJqoIp1AjwFASBSq2sOCFnuROHfQwIgMxYAO1+YTZU/wtwhGbh9XIT6FZY+7ZZ/HUIoy+xI5QIX8BsT4lKBtttiHDVXwCcooeZQoJLtLO967NVDZoyOoucypxaNbiwZZe/m0AzfNecI/IVzQYfFJpJ+2hEDcoe/NlsBrgV3A1fy+GV/Nf4cW; 25:v1UwG9DB1FRPz5ncvN5QXUGImmi2/7bw3RyPasUwAiujkkBXt1nCk02WJDNBLHKYPfSxf9LKPvNUvg6MAXx1DT1l4Fv2gattXCR1YnqpCjd/5pNxhVJNttTsAO9rBwjFY+ACqTfhcHKyOKcFlFwmngaYi22fUsFerNk0EJTFDZIBQQr0nSoGnApgGcy4q+roL5TlOJRs2P1mML+eN2ZeLHREewZxGcOvDIrWYExVrp63ZCAxV7wTrrS/Jn0RPrM1u9u67WFC+PIAE3S6sHNB2crD5MxIYoyfpW5Ebc4EaSrO1W07jnv0sef2rkn+jUoAGIyWxBYDRt1Gs8ZWTfdX/A==; 31:pxMSKwwwavK58Y5W0tSYj0pRTYazX+Dij4AWJOTqNsdd1Qnm+404vZljaqJS1fo0Ktgegxe9I+iz1Nj7NvqPOmjJ1jW1K5OnBdruwdEjTYPwPb1xUHOd9NLCoewDp4WJrBqRYI4dUJ8ACQhlYHh4NXEEo6lDAQ2ZRqvV8RRw+dnkB6J0aiXE9u7RAvyEbvrxpKfWJUMnnjYrERQulkqg2zpwO5Vy2+vNosy9PiJ+0Mk= X-MS-TrafficTypeDiagnostic: TYAPR01MB2078: X-Microsoft-Exchange-Diagnostics: 1; TYAPR01MB2078; 20:ld5i9J4AZux5kmrVDzpGS/WovEH8o/hQnQo6hGiQPy3+xsZVvxZ02TiOkFUvdY3Y+lcoKZ+4R0IoHdcrpZwPngvI2fycCA92yfV4ZBiM3havB8yw1vAKej/rPsd2YGfeamwGRSjo7fisAvUBlTlepK4LtLIZyeCgDXZR1NLHihuUBMmC4CAADLvNcPqJgQsEdH3uPgmYe5TC4/PHnP8CyV5sYGfInVeG60AqSztSFGsXgeBx1FnmY1wC2bjNXs2ymyMBSE3J1yyOSIxy1M72AI1S1TJPfxTCE0bspHo7l2AEefkRZ9XcW0WxrF8t/fXKKh6/dxiGDVWhiRrEDuc/x6E4ewDheam56DnraqhMdda9HrUDBYVR9WhlEgqkB2/wSc6lIx+oUmqUt1g9rrZeqNswpS4w5ET7TFqCNafZqZ+bWbd2zmLSPjW96D6zbsj+9Ec1PwvT/Oy5bevMcHGuJsAL0ry5TP50aReQskUTZs1En+Md2KjUxPcMGMVNK5Wd; 4:Fl/JdDypjGCcnVn146HjcPn8aWzCVBpXbRyat873rSz1rWp3QoavpUZVxqidDgoUMmnHLylA4U7pN7Vr1o745huoED55JXMvAUEUNxxUySr8rCfBjv9KuviGQA2dyBMeRvLGrkJz72cgDMxXpbMCO4WE+XWGcvEnnJHTrbPOCxt2Gik24jR8oidEhhTxkSyM+iJYea39AW9QohOoLuCOmvSQFadFTHn+F5J7errOPCLz1zfMZkTzdriMAR54MtO5h6H3kLMgWGfy2C6O+VckkA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(3231232)(944501327)(52105095)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:TYAPR01MB2078; BCL:0; PCL:0; RULEID:; SRVR:TYAPR01MB2078; X-Forefront-PRVS: 0641678E68 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(366004)(376002)(39860400002)(346002)(39380400002)(396003)(189003)(199004)(8746002)(26005)(8936002)(93886005)(107886003)(58126008)(316002)(25786009)(23756003)(8676002)(39060400002)(97736004)(4326008)(36756003)(6116002)(54906003)(86362001)(3846002)(53936002)(110136005)(11346002)(69596002)(956004)(2616005)(476003)(446003)(2906002)(305945005)(66066001)(7736002)(5660300001)(47776003)(1857600001)(50466002)(386003)(6486002)(16526019)(186003)(478600001)(68736007)(105586002)(53416004)(76176011)(52116002)(106356001)(7696005)(486006)(81166006)(81156014)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:TYAPR01MB2078; H:morimoto-PC.renesas.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1; TYAPR01MB2078; 23:0UfgPqElmc8zOmd2BkbTq+SWKoLlsx9GrcJeySq?= =?iso-8859-1?Q?TZVoR27bfVS7EB4PtPPIDEvmdEB5zUpZfmSAWfoGTTD+k7cL1/rD1z75LF?= =?iso-8859-1?Q?vBJ1KLo3Xk5Hl2k8EtnTSrORxuZBn5kjSoVGl1OsjLnCHfmaDt1YPnpz0z?= =?iso-8859-1?Q?P0jk9M3Wwzfuk1m1KjpPof17b/yPGInd1lGGgNuhVfbLESOCvdfUdSwqU4?= =?iso-8859-1?Q?6GKiuXRuWZAzxlXOcek1xV1ICT3kjsGdruBFfU+AxXR5FLp4O/1LUkDceF?= =?iso-8859-1?Q?8+jyqRuo9CFDTiGfCroWwA1puLqVNLqirvVR8swsiLEO3wr+wsLNZbvWkJ?= =?iso-8859-1?Q?jXj5DCkPxgB3JLxWT4uY2AnK4006TSFC0+gN+56OrTu6iFWHt4C9vDImjg?= =?iso-8859-1?Q?tgrzlSD8axFfHmsmYUo8UPUag6S7EQanEyRkRoRu0J65J90RugE32tb5w3?= =?iso-8859-1?Q?mLrFyLSvHUVSliZ0ug0KrcTKAyoMDsru78o1ymo5N7/qj6EOhmm9bhWxEF?= =?iso-8859-1?Q?Rv90z/V3cRdzPJ2rLrFOUWK6ByJBhLHo74uiPwfYV0EIp+f5m5SKXpReFP?= =?iso-8859-1?Q?fPmTDvabul0AMzLPAGAQes8uRGW5Bi2rnRZx4OU9s89LQZ1j3eHvjI2xhj?= =?iso-8859-1?Q?PWCiGuHIW6xCbdf1RB7YDiThf5OaH87tXXmUyL6yApye6Q9IrNqDiwTIQp?= =?iso-8859-1?Q?Ms5RtYW3p1L74ZPSqqa3xqzoJjxvVuFKZwMCVVp15m/OAA5y/Lg91yLxdg?= =?iso-8859-1?Q?UixovZVkd3ostoHOpG9kKDWUIVVHN5Tp8NwHPNWZBBI1dIhDR8snhOMRyb?= =?iso-8859-1?Q?mBMzpzKYtkaFzJ672iLsNYgjS7LVISCusZ7bVSiJ7QARpL1fmNYD1tldT4?= =?iso-8859-1?Q?Ve74uKdoeex4FhW6q9DR4qclQrQeHlVpJOT0OiWqAca1JiPd0Q1plMYa7z?= =?iso-8859-1?Q?kI+LukBOnkqWTeHYgsbqi25CuyLjn0goeIWj9M49ZdXN2Oqp6v2DS4ZS7e?= =?iso-8859-1?Q?xxqoKDWEx/gidHYKSaYJrK+muXiRbeu0DuChX5piqnA5z94Htb4Zl5Tgz4?= =?iso-8859-1?Q?If09fNH038dgBLB8srDGDh25T3RTvwSrGhLU6KQRmPgocOMCO3B3tiW+S5?= =?iso-8859-1?Q?rgTZl9AfO928lp6kyuSaCBOyfJAloI/1kaspplJqbKJ10PJUmxL0bVKwDX?= =?iso-8859-1?Q?pzTdJ4uLjW/c/CjQSIotklg99RfD0mL++/mzQYwZP0ZPDY0oSr2qWbQ+eb?= =?iso-8859-1?Q?uFMaT/oCL4Xbu1F12qqJkYPUaNQ0BYhpSQcWbhwIJEXcDEmF2ymoC9ZY0b?= =?iso-8859-1?Q?vcepznyMmYGKZV9wSzmMM0YW7GcXNFsSpK3tATVC/OJeocoGne+E/UhMWr?= =?iso-8859-1?Q?RjPPPpoU=3D?= X-Microsoft-Antispam-Message-Info: HITAHIYvPwe7dL8/YHKNEgX7IepYINFkVE+HylX+gmTnNeiLeNyNd7K58HsdGy1TJQVhrKfiUyNchRUq4KjjGmNkAf7VRdHQOhbudEn0iBC/nqZfm5PIQ8aM/2MegbEn+9xAoGuRae+BMgvdGWwKTdDGTBKpsZvwiNKQ1iVYZhSkIkQwcyX9E2d7P4fLiCND X-Microsoft-Exchange-Diagnostics: 1; TYAPR01MB2078; 6:FeTc7gBbuKGBQsL3VboVAs93BVitTwiZqeOB+mLyL9SFISrikvJjNkfXr+Li9sdl6emUO+xM/BcR1hFisg+n/C8G6f5PH73wkrzSMKXaUEZR2X1ySdmnh0WhwAjUkoenj44W8A+xY6amsRKrOlc3bsFnvpxMrI2OqqBeImVfU2bL2FiEQfP9OGPmS6AR3JAoNMNxwMrrp/qtBn4PCtQBg5IpesSUE8K3r3kRTfN6vn0E8n+7zud4bqQzMGuLhle8dKMWlndkibi3ZmbNNYNlMqWsWlQR/ogpK/OeMtAgV1n6TusjulE/VwaVIa61C8SZiftdHDmD4oI4WXiAZmVhOC2lmq1W5QrptkAL5LEp/oJU+XxVPB/jQUEStqTtl9K7a0w9ltg/RrlJGNH96YCEDiQ9MxLF/PiV3InVP1ZhxV0Uu2ei6g86XBCT2GoHAp+urkZVJtmkbkLovirglFrjvg==; 5:9pjpJEYU/JV0rUyyfaHT00GJCdecmGMmyKd/IYHJ5zzam6U2ytXjT6RGSn7He8osJ5nZwc9miDKGaBwYCQbLopoSvGtASHqG6sbFxPOF3Rq+r3PUB1BOXiC9NVgU5dFCkzufIwC74h97GrGnBxtMNkU3vDXmeUPQlIiAwMxLSsY=; 24:wlQldNXI4SbRLEZSwWl+yEAK43G65a59TA9vI8I8RIiGVxdRVhjE2C0ZIW5uYd2kh8WJxcwlmI0P/5JBoTZbuXsrS0mc/97kGysI4LRirk8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; TYAPR01MB2078; 7:ez4VTz1fQjNKedRM6OqcwAmrHQAQZiXNhQGazO8QwbZ/97YszsomKGydKEp5uIxl8VxMxxbeQl8efb8f1eznNDaPe1QBg5RVmk5bE9Vr+Rt1tWSXYyj3KshoB0sNo8KfXO5TlOt/FYoIX081hLocHYcr5VkCKwSikqcWdjA5TvcQ6OuEsQrNkl6XJshN7DSD+uNsH1IeEJPgGiNt+1R+GIZu0TPxzxLghRuZ6RIxhYh8MqxY8ugzFZr6V9ZtZhUg; 20:eb6rg1VSxyjZ7Mw1fquB5mGtcvnVBgdIsA9XgNQlI6MkdO8SK9AUo0pqgMK5ObWSHJYNuwYOYrWpJC2eDbxaK0Ig+MNZAWAxvvYxVVpxTTNVblEKR74xrOEq8H1pqhqE/CEIAMItKBi/5AhhyTkQKdlyoE56BZuXeRzoc5+iIho= X-MS-Office365-Filtering-Correlation-Id: 7d2c378e-a662-45a5-d655-08d5a0e4d263 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Apr 2018 02:18:13.3507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d2c378e-a662-45a5-d655-08d5a0e4d263 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR01MB2078 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Koji Matsuoka In Video Pixel/Line Pre-Clip Register, the setting value can be set in 1 line unit, but it can only be specified as a multiple of 4 by v4l_bound_align_image function(). So correct that it can be specified in 1 line unit with this patch. Signed-off-by: Koji Matsuoka Signed-off-by: Kuninori Morimoto Acked-by: Niklas Söderlund --- drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c index 22a6ecc..71ae65b 100644 --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c @@ -409,8 +409,8 @@ static int rvin_s_selection(struct file *file, void *fh, max_rect.height = vin->source.height; v4l2_rect_map_inside(&r, &max_rect); - v4l_bound_align_image(&r.width, 2, vin->source.width, 1, - &r.height, 4, vin->source.height, 2, 0); + v4l_bound_align_image(&r.width, 6, vin->source.width, 0, + &r.height, 2, vin->source.height, 0, 0); r.top = clamp_t(s32, r.top, 0, vin->source.height - r.height); r.left = clamp_t(s32, r.left, 0, vin->source.width - r.width);