From patchwork Sun Nov 10 20:24:54 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Nazarewicz X-Patchwork-Id: 20712 X-Patchwork-Delegate: mchehab@kernel.org Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VfbZn-0004nc-AN; Sun, 10 Nov 2013 21:25:43 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-5) with esmtp id 1VfbZl-0005K1-78; Sun, 10 Nov 2013 21:25:43 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075Ab3KJUY7 (ORCPT + 1 other); Sun, 10 Nov 2013 15:24:59 -0500 Received: from mail-ee0-f54.google.com ([74.125.83.54]:50337 "EHLO mail-ee0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821Ab3KJUY6 (ORCPT ); Sun, 10 Nov 2013 15:24:58 -0500 Received: by mail-ee0-f54.google.com with SMTP id c50so2025575eek.41 for ; Sun, 10 Nov 2013 12:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=MikxpxvFFFYgKAOSknWrb81x+tfOVXKYC1Gf/dvdG4c=; b=OMtgwfKLAIIgmJ0PvYbaMsKOn8g5Fv9H4fjBQAuGMkVZgw0YcOlmJNazwC4jPmhTwk r2/vY+7XczA/wQhSZ8pdHY2bHB/P58wO1JK4+pPgOeFdVFY8y6li+qvSh1Cd/Atbjj80 gZD1ZMg2YFqfBL09H/Wam84wG70ZEYrPgKjZeHeNCoapOkhwcoMOwl6kBWtVyDTg40q8 dTx82ddfTdSd4ViPQjqSbznfxFJvfwpCqV9LrL1jfSw9n4m1cp4PbC+54Gn3DfQofZT9 ldSNDDpGZWvITNewrZbePWDo+taucg/et8Mze5cKG7mPqFeb+hWGaQRNnQjJvtF5A9Fw i8Xg== X-Received: by 10.15.42.193 with SMTP id u41mr5887922eev.16.1384115097271; Sun, 10 Nov 2013 12:24:57 -0800 (PST) Received: from erwin.mina86.com (178-82-34-113.dynamic.hispeed.ch. [178.82.34.113]) by mx.google.com with ESMTPSA id w6sm53418878eeo.12.2013.11.10.12.24.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Nov 2013 12:24:56 -0800 (PST) From: Michal Nazarewicz To: Greg Kroah-Hartman Cc: Hans Verkuil , Mauro Carvalho Chehab , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/7] staging: go7007: fix use of uninitialised pointer In-Reply-To: <20131110185210.GA9633@kroah.com> References: <1384108677-23476-1-git-send-email-mpn@google.com> <20131110185210.GA9633@kroah.com> User-Agent: Notmuch/0.16+80~g81ee785 (http://notmuchmail.org) Emacs/24.3.50.1 (x86_64-unknown-linux-gnu) Date: Sun, 10 Nov 2013 21:24:54 +0100 Message-ID: <87fvr480o9.fsf@mina86.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.11.10.185415 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __YOUTUBE_RCVD 0' Signed-off-by: Michal Nazarewicz --- drivers/staging/media/go7007/go7007-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) On Sun, Nov 10 2013, Greg Kroah-Hartman wrote: > Please either delete this entirely, or use the struct device in the > usb_interface pointer. > > A driver should never have a "raw" pr_* call. diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c index 58684da..e8c708c 100644 --- a/drivers/staging/media/go7007/go7007-usb.c +++ b/drivers/staging/media/go7007/go7007-usb.c @@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf, char *name; int video_pipe, i, v_urb_len; - dev_dbg(go->dev, "probing new GO7007 USB board\n"); + dev_dbg(&intf->dev, "probing new GO7007 USB board\n"); switch (id->driver_info) { case GO7007_BOARDID_MATRIX_II: