From patchwork Fri Jun 2 12:18:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Stevenson X-Patchwork-Id: 41610 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dGlY2-0000qJ-28; Fri, 02 Jun 2017 12:19:22 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.89/mailfrontend-6) with esmtp id 1dGlXz-0000M3-5R; Fri, 02 Jun 2017 14:19:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751154AbdFBMTS (ORCPT + 1 other); Fri, 2 Jun 2017 08:19:18 -0400 Received: from mx08-00252a01.pphosted.com ([91.207.212.211]:32868 "EHLO mx08-00252a01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdFBMTR (ORCPT ); Fri, 2 Jun 2017 08:19:17 -0400 Received: from pps.filterd (m0102629.ppops.net [127.0.0.1]) by mx08-00252a01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v52CD3N5006345 for ; Fri, 2 Jun 2017 13:19:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.org; h=from : to : cc : subject : date : message-id : in-reply-to : references : in-reply-to : references; s=pp; bh=LNPSdsbF66fMgswc6RXHdfwTdRBF/U/3LUiM8RIe+/4=; b=xD1Ryd3wYbNKGbrgWhzzSxf3z7tCPkOzK/GMruzyCFQ4FZmSkkqpiJ/iE+km+6B79Vfl 6Vw4cXuxJBxUkbMe95VbCxvF6rrzAYDtfcyAgu/bmTubsSd7iLFyGuA7RpMV+sUNyXbw gIBFgVcaVoCYAfw5mLquU8xAox9JFK0MrM7lc4IxL5nOzidrNQFn7VgdzIol6ZJZv3DA OWc5UVErMXO6wRafJde6nSEP6/tzVXpuE/fjSpZBHexjYHZsK+yZQ9Xs1F/thZldTDi6 ag3VcAe0cqYCguiJRwM44c620ERnaMv3MgzAdkudTqaicOUxRjkMvTbsB0zDdE/BJ0Cq nQ== Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by mx08-00252a01.pphosted.com with ESMTP id 2apwxetx0u-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK) for ; Fri, 02 Jun 2017 13:19:00 +0100 Received: by mail-wm0-f69.google.com with SMTP id r203so16819224wmb.2 for ; Fri, 02 Jun 2017 05:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=LNPSdsbF66fMgswc6RXHdfwTdRBF/U/3LUiM8RIe+/4=; b=Tl+rwXfRc41dxpD2VIPJd7DEjcCo+8SGQGlC3MnWAru79YljQqlsRJdmEDF2dHMvLI LhzUHX2kKNXHgCd7b+N0W06Y+BGhjHzE90/p2NK1PORmEvrRD4M1taaNwCYK/cvxqefB xT17rPEGKEuwaYL4INXgv6O5Ex1NEoiP6n7to18Ph1z56wwF5s+BqvntIQ+vLf+J26Xz 33VxiKCAzz5HfOCO4K2qnP7m0oBeUVLt/yL1/cmmuwF70HMJlLObo/ztxGZan/6ftVEI Kbk2dzc+mVVKMHBSNIrSHiEo1IpBTwfUWjcJIBctc9qj26otmKHHO7C4tJ0f1PKQNnoP SBsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=LNPSdsbF66fMgswc6RXHdfwTdRBF/U/3LUiM8RIe+/4=; b=lns0q1vKZSIR/3nxnENASq8/EocXcRTz87UhHv5mLbPouQyILv33jqysq3u97AO915 aov+wGz/CRKXn7WWHg1ppm92GdyE0iAgjHfaOB25gI6RKDyW1qxNREI3H2szrU6qYrUA YdR88dpORIkO3vsoUGtuavNZBylGHcEuxzvNmBiR6Kt2HwNFDvk/nDxwRe/GmEyKCnKR gzWl/MdapJT5CckSR16QGbDI7xqfoh+ZVPczfFm/sPfZXOza1y3fMriEnQUEPuVuNK8F el7QtgE/iLuAYnGnpvtcbSya7vUvJEb9YFEG1IG61hEsVbRYVOFYTj50MZX/VJMPgy2y iXIQ== X-Gm-Message-State: AODbwcCGhbStuS1j49zrlZOB8OkgvFhmN1IbpM9qJJPAih4uqG+z9QNn NfyxYKzAYYVcx/tfq3+8FIhZOwTnSkCf6qfnf7/3wkzzzmcOHIehGW2pWzdO9ZbNIILfeof7P2t U/rbsA2td4Yn+QA== X-Received: by 10.223.179.198 with SMTP id x6mr6031587wrd.167.1496405939343; Fri, 02 Jun 2017 05:18:59 -0700 (PDT) X-Received: by 10.223.179.198 with SMTP id x6mr6031573wrd.167.1496405939158; Fri, 02 Jun 2017 05:18:59 -0700 (PDT) Received: from localhost.localdomain ([217.33.127.173]) by smtp.googlemail.com with ESMTPSA id l190sm2706032wmb.18.2017.06.02.05.18.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 02 Jun 2017 05:18:58 -0700 (PDT) From: Dave Stevenson To: Mats Randgaard , Mauro Carvalho Chehab , linux-media@vger.kernel.org Cc: Dave Stevenson Subject: [PATCH 2/3] [media] tc358743: Setup default mbus_fmt before registering Date: Fri, 2 Jun 2017 13:18:13 +0100 Message-Id: <77dde71a5d81ebf274b5b403b54e4086b29afc08.1496398217.git.dave.stevenson@raspberrypi.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-06-02_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1706020227 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2017.6.2.120915 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, IN_REP_TO 0, LEGITIMATE_SIGNS 0, MSG_THREAD 0, MULTIPLE_REAL_RCPTS 0, NO_URI_HTTPS 0, REFERENCES 0, __ANY_URI 0, __CC_NAME 0, __CC_NAME_DIFF_FROM_ACC 0, __CC_REAL_NAMES 0, __FROM_DOMAIN_IN_ANY_CC2 0, __FROM_DOMAIN_IN_RCPT 0, __HAS_CC_HDR 0, __HAS_FROM 0, __HAS_LIST_ID 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_TEXT_P 0, __MIME_TEXT_P1 0, __NO_HTML_TAG_RAW 0, __REFERENCES 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NAME 0, __TO_NAME_DIFF_FROM_ACC 0, __TO_REAL_NAMES 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Previously the mbus_fmt_code was set after the device was registered. If a connected sub-device called tc358743_get_fmt prior to that point it would get an invalid code back. Signed-off-by: Dave Stevenson --- drivers/media/i2c/tc358743.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/tc358743.c b/drivers/media/i2c/tc358743.c index 06bfdca..2f5763d 100644 --- a/drivers/media/i2c/tc358743.c +++ b/drivers/media/i2c/tc358743.c @@ -1905,6 +1905,8 @@ static int tc358743_probe(struct i2c_client *client, if (err < 0) goto err_hdl; + state->mbus_fmt_code = MEDIA_BUS_FMT_RGB888_1X24; + sd->dev = &client->dev; err = v4l2_async_register_subdev(sd); if (err < 0) @@ -1919,7 +1921,6 @@ static int tc358743_probe(struct i2c_client *client, tc358743_s_dv_timings(sd, &default_timing); - state->mbus_fmt_code = MEDIA_BUS_FMT_RGB888_1X24; tc358743_set_csi_color_space(sd); tc358743_init_interrupts(sd);