From patchwork Tue Jul 5 13:21:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Hans Verkuil (hansverk)" X-Patchwork-Id: 35123 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKQHy-0002eU-VL; Tue, 05 Jul 2016 13:21:23 +0000 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.84_2/mailfrontend-5) with esmtp id 1bKQHw-0008Hk-8G; Tue, 05 Jul 2016 15:21:22 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755387AbcGENVR (ORCPT + 1 other); Tue, 5 Jul 2016 09:21:17 -0400 Received: from aer-iport-4.cisco.com ([173.38.203.54]:49825 "EHLO aer-iport-4.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755384AbcGENVO (ORCPT ); Tue, 5 Jul 2016 09:21:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=889; q=dns/txt; s=iport; t=1467724874; x=1468934474; h=to:from:subject:message-id:date:mime-version: content-transfer-encoding; bh=dqpwIqUwa3wvS1ws5AQXAj5O2fw/fIHlF2H1DG/LyCA=; b=JZe2KZai0AnNnL9sUA960kc/Ckd7dNZLQkpjzqL4tMkJwgvZSfCUlMCw raaNV081hMWm2BuZabo7XZVP+ISux+MgXCBZA6vh6Xv56PlypMnFOnRZM OLVaIq4pcgqU0gg7pntmzXoRIaiMXZs1n+2v4jhyv71Vz1B3e5eEtVdBQ Q=; X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0CnBAAas3tX/xbLJq1chRC3NoQGiBcBA?= =?us-ascii?q?QEBAQFmJ4R2BIEHAgUhAhECTA0GAgKILJsej2KPMAEBAQcCASSBAYUmjA6CWgE?= =?us-ascii?q?EmROOR4Fqh2GFXQKGV4kzVINyOjKIeQEBAQ?= X-IronPort-AV: E=Sophos;i="5.26,579,1459814400"; d="scan'208";a="638382464" Received: from aer-iport-nat.cisco.com (HELO aer-core-2.cisco.com) ([173.38.203.22]) by aer-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2016 13:21:12 +0000 Received: from [10.47.79.81] ([10.47.79.81]) (authenticated bits=0) by aer-core-2.cisco.com (8.14.5/8.14.5) with ESMTP id u65DL9Q1030120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Tue, 5 Jul 2016 13:21:11 GMT To: linux-media From: Hans Verkuil Subject: [PATCH] adv7511: the h/vsync polarities were always positive Message-ID: <577BB445.10402@cisco.com> Date: Tue, 5 Jul 2016 15:21:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 X-Authenticated-User: hansverk Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2016.7.5.131217 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __SANE_MSGID 0, __SINGLE_URI_TEXT 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __URI_WITH_PATH 0, __USER_AGENT 0' Correctly set the h/vsync polarities instead of keeping to the default (positive). Signed-off-by: Hans Verkuil --- drivers/media/i2c/adv7511.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c index 161cbdb..f062694 100644 --- a/drivers/media/i2c/adv7511.c +++ b/drivers/media/i2c/adv7511.c @@ -763,6 +763,11 @@ static int adv7511_s_dv_timings(struct v4l2_subdev *sd, /* save timings */ state->dv_timings = *timings; + /* set h/vsync polarities */ + adv7511_wr_and_or(sd, 0x17, 0x9f, + ((timings->bt.polarities & V4L2_DV_VSYNC_POS_POL) ? 0 : 0x40) | + ((timings->bt.polarities & V4L2_DV_HSYNC_POS_POL) ? 0 : 0x20)); + /* update quantization range based on new dv_timings */ adv7511_set_rgb_quantization_mode(sd, state->rgb_quantization_range_ctrl);