From patchwork Tue Jul 7 08:48:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: poma X-Patchwork-Id: 30463 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1ZCOYY-00077H-LI; Tue, 07 Jul 2015 10:48:46 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.76/mailfrontend-8) with esmtp id 1ZCOYW-0002Rp-kF; Tue, 07 Jul 2015 10:48:46 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756613AbbGGIsl (ORCPT + 1 other); Tue, 7 Jul 2015 04:48:41 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:36435 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753991AbbGGIsi (ORCPT ); Tue, 7 Jul 2015 04:48:38 -0400 Received: by widjy10 with SMTP id jy10so182069312wid.1 for ; Tue, 07 Jul 2015 01:48:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=vYzxpRZ4TJisKqCJ/6eYwvi7ZbPS5VzCMhvmQVVrCL0=; b=PwQjr7k+X4eAE+pxY++havpQf47JIDHQkOq5NzG5hbZOUH9HN7VMtwkS0IK+hjb40w 2bqUAAr+xU+UTZFl+ESMMi1c/8ACbunMjYrqeBEEQ2p7u8VBZ6jIrJwqUhbSFxW+FDfH xI4qqdHrINF9os6F0NKTqmP35+YogHZwNafZb27cP8pnuVLXuKTNYlU/M6VZENCcFjN4 33rgmghGwGYqtxvBA7KIRB5yibXlJ3MD4kjkixZG7IYG5QyT8O3I66ibIKt0jHyJzEcq hmiFzdcgq+d5dDESY94VMq7Pa2sxnQbmXbEusujzl04+TDFv9qje+2GRc+mwvpKUPX3S rQzQ== X-Received: by 10.180.23.33 with SMTP id j1mr51539051wif.44.1436258916739; Tue, 07 Jul 2015 01:48:36 -0700 (PDT) Received: from localhost (iskon4343.duo.carnet.hr. [31.147.112.247]) by mx.google.com with ESMTPSA id a19sm51324170wiv.2.2015.07.07.01.48.34 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jul 2015 01:48:35 -0700 (PDT) From: poma Subject: Re: dvb_usb_af9015: command failed=1 _ kernel >= 4.1.x To: Jose Alberto Reguero References: Cc: Antti Palosaari , linux-media , Michael Krufky , Manu Abraham , Mauro Carvalho Chehab Message-ID: <559B9261.4050409@gmail.com> Date: Tue, 7 Jul 2015 10:48:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2015.7.7.84216 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, FROM_NAME_ONE_WORD 0.05, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, NO_URI_HTTPS 0, REFERENCES 0, SINGLE_URI_IN_BODY 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FORWARDED_MSG 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __REFERENCES 0, __SANE_MSGID 0, __SUBJ_ALPHA_NEGATE 0, __TO_MALFORMED_2 0, __URI_IN_BODY 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0, __YOUTUBE_RCVD 0' On 06.07.2015 22:17, Jose Alberto Reguero wrote: > I made the patch for the af9035. I have not a af9015 whith mxl5007 and dual channel. Revert it, if it cause regresions. > > Jose Alberto > Thanks. From e19560ea038e54dc57be717db55f19d449df63f0 Mon Sep 17 00:00:00 2001 From: poma Date: Tue, 7 Jul 2015 10:26:13 +0200 Subject: [PATCH] Fix for AF9015 DVB-T USB2.0 stick This reverts commitas: - 02f9cf96df57575acea2e6eb4041e9f3ecd32548 "[media] [PATH,2/2] mxl5007 move loop_thru to attach" - fe4860af002a4516dd878f7297b61e186c475b35 "[media] [PATH,1/2] mxl5007 move reset to attach" This is the conclusion after extensive testing, these two commitas produce: mxl5007t_soft_reset: 521: failed! mxl5007t_attach: error -121 on line 907 causing AF9015 DVB-T USB2.0 stick completely unusable. Tested-by: poma --- drivers/media/tuners/mxl5007t.c | 30 +++++------------------------- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/drivers/media/tuners/mxl5007t.c b/drivers/media/tuners/mxl5007t.c index f4ae04c..f8c4ba2 100644 --- a/drivers/media/tuners/mxl5007t.c +++ b/drivers/media/tuners/mxl5007t.c @@ -374,6 +374,7 @@ static struct reg_pair_t *mxl5007t_calc_init_regs(struct mxl5007t_state *state, mxl5007t_set_if_freq_bits(state, cfg->if_freq_hz, cfg->invert_if); mxl5007t_set_xtal_freq_bits(state, cfg->xtal_freq_hz); + set_reg_bits(state->tab_init, 0x04, 0x01, cfg->loop_thru_enable); set_reg_bits(state->tab_init, 0x03, 0x08, cfg->clk_out_enable << 3); set_reg_bits(state->tab_init, 0x03, 0x07, cfg->clk_out_amp); @@ -530,6 +531,10 @@ static int mxl5007t_tuner_init(struct mxl5007t_state *state, struct reg_pair_t *init_regs; int ret; + ret = mxl5007t_soft_reset(state); + if (mxl_fail(ret)) + goto fail; + /* calculate initialization reg array */ init_regs = mxl5007t_calc_init_regs(state, mode); @@ -895,32 +900,7 @@ struct dvb_frontend *mxl5007t_attach(struct dvb_frontend *fe, /* existing tuner instance */ break; } - - if (fe->ops.i2c_gate_ctrl) - fe->ops.i2c_gate_ctrl(fe, 1); - - ret = mxl5007t_soft_reset(state); - - if (fe->ops.i2c_gate_ctrl) - fe->ops.i2c_gate_ctrl(fe, 0); - - if (mxl_fail(ret)) - goto fail; - - if (fe->ops.i2c_gate_ctrl) - fe->ops.i2c_gate_ctrl(fe, 1); - - ret = mxl5007t_write_reg(state, 0x04, - state->config->loop_thru_enable); - - if (fe->ops.i2c_gate_ctrl) - fe->ops.i2c_gate_ctrl(fe, 0); - - if (mxl_fail(ret)) - goto fail; - fe->tuner_priv = state; - mutex_unlock(&mxl5007t_list_mutex); memcpy(&fe->ops.tuner_ops, &mxl5007t_tuner_ops,