From patchwork Wed Nov 13 15:04:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alfredo_Jes=C3=BAs_Delaiti?= X-Patchwork-Id: 20727 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1VgcVn-0000Us-WF; Wed, 13 Nov 2013 16:37:48 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.72/mailfrontend-6) with esmtp id 1VgcVl-0007bV-5e; Wed, 13 Nov 2013 16:37:47 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758386Ab3KMPhn (ORCPT + 1 other); Wed, 13 Nov 2013 10:37:43 -0500 Received: from omr-m02.mx.aol.com ([64.12.143.76]:61919 "EHLO omr-m02.mx.aol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756483Ab3KMPhn (ORCPT ); Wed, 13 Nov 2013 10:37:43 -0500 Received: from mtaout-da01.r1000.mx.aol.com (mtaout-da01.r1000.mx.aol.com [172.29.51.129]) by omr-m02.mx.aol.com (Outbound Mail Relay) with ESMTP id 375A47015C078; Wed, 13 Nov 2013 10:37:42 -0500 (EST) Received: from [192.168.1.34] (unknown [201.255.79.7]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mtaout-da01.r1000.mx.aol.com (MUA/Third Party Client Interface) with ESMTPSA id 17124E0000E7; Wed, 13 Nov 2013 10:37:40 -0500 (EST) Message-ID: <52839505.6090700@netscape.net> Date: Wed, 13 Nov 2013 12:04:37 -0300 From: =?UTF-8?B?QWxmcmVkbyBKZXPDunMgRGVsYWl0aQ==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Subject: [PATCH 2/2] X8502/8507 Radio Support [was: cx23885: Add basic analog radio support] References: <524F0F57.5020605@netscape.net> <20131031081255.65111ad6@samsung.com> In-Reply-To: <20131031081255.65111ad6@samsung.com> x-aol-global-disposition: G X-AOL-VSS-INFO: 5600.1067/95070 X-AOL-VSS-CODE: clean x-aol-sid: 3039ac1d338152839cc406da X-AOL-IP: 201.255.79.7 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 6.0.0.2142326, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.11.13.152715 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, FROM_NAME_PHRASE 0, URI_ENDS_IN_HTML 0, WEBMAIL_SOURCE 0, WEBMAIL_X_AOL_IP 0, WEBMAIL_X_IP_HDR 0, __ANY_URI 0, __BAT_BOUNDARY 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __FORWARDED_MSG 0, __FW_1LN_BOT_MSGID 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MOZILLA_USER_AGENT 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' Hi Mauro and all El 31/10/13 07:12, Mauro Carvalho Chehab escribió: > Hi Alfredo, My understanding is that the patch you've enclosed is > incomplete and depends on Miroslav's patch. As he have you his ack to > rework on it, could you please prepare a patch series addressing the > above comments for us to review? Than I tested this patch with the latest versions of git. I found some issue, although it may be through a bad implementation of mine. Details of them: 1) No reports signal strength or stereo signal with KRadio. XC5000 neither reported (modprobe xc5000 debug=1). Maybe a feature XC5000. To listen in stereo, sometimes, you have to turn on the Digital TV then Analog TV and then radio. 2) To listen Analog TV I need changed to NTSC standard and then PAL-Nc (the norm in my country is PAL-Nc). If I leave the tune in NTSC no problem with sound. The patch (https://linuxtv.org/patch/9505/) corrects the latter, but not always. 3) If I see-Digital TV (ISDB-T), then so as to listen the radio I have first put the TV-Analog, because I hear very low and a strong white noise. The latter is likely to be corrected by resetting the tuner, but I have not been able to do. Thank you, Alfredo Signed-off-by: Alfredo J. Delaiti diff --git a/drivers/media/pci/cx23885/cx23885-cards.c b/drivers/media/pci/cx23885/cx23885-cards.c index 79f20c8..f97002a 100644 --- a/drivers/media/pci/cx23885/cx23885-cards.c +++ b/drivers/media/pci/cx23885/cx23885-cards.c @@ -574,6 +574,8 @@ struct cx23885_board cx23885_boards[] = { .name = "Mygica X8502/X8507 ISDB-T", .tuner_type = TUNER_XC5000, .tuner_addr = 0x61, + .radio_type = TUNER_XC5000, + .radio_addr = 0x61, .tuner_bus = 1, .porta = CX23885_ANALOG_VIDEO, .portb = CX23885_MPEG_DVB, @@ -603,6 +605,10 @@ struct cx23885_board cx23885_boards[] = { .amux = CX25840_AUDIO7, }, }, + .radio = { + .type= CX23885_RADIO, + .amux= CX25840_AUDIO8, + }, }, [CX23885_BOARD_TERRATEC_CINERGY_T_PCIE_DUAL] = { .name = "TerraTec Cinergy T PCIe Dual", diff --git a/drivers/media/pci/cx23885/cx23885-dvb.c b/drivers/media/pci/cx23885/cx23885-dvb.c index 0549205..b09d97f 100644 --- a/drivers/media/pci/cx23885/cx23885-dvb.c +++ b/drivers/media/pci/cx23885/cx23885-dvb.c @@ -505,6 +505,7 @@ static struct mb86a20s_config mygica_x8507_mb86a20s_config = { static struct xc5000_config mygica_x8507_xc5000_config = { .i2c_address = 0x61, .if_khz = 4000, + .radio_input = XC5000_RADIO_FM1, }; static struct stv090x_config prof_8000_stv090x_config = {