From patchwork Fri Dec 31 11:37:00 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Igor M. Liplianin" X-Patchwork-Id: 5400 Return-path: Envelope-to: mchehab@gaivota Delivery-date: Sat, 01 Jan 2011 07:57:41 -0200 Received: from mchehab by gaivota with local (Exim 4.72) (envelope-from ) id 1PYyDU-0001ta-IZ for mchehab@gaivota; Sat, 01 Jan 2011 07:57:41 -0200 Received: from casper.infradead.org [85.118.1.10] by gaivota with IMAP (fetchmail-6.3.17) for (single-drop); Sat, 01 Jan 2011 07:57:40 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1PYxsY-0005M3-BR; Sat, 01 Jan 2011 09:36:02 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751284Ab1AAJfk (ORCPT + 1 other); Sat, 1 Jan 2011 04:35:40 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:41338 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758Ab1AAJfk (ORCPT ); Sat, 1 Jan 2011 04:35:40 -0500 Received: by eye27 with SMTP id 27so5458453eye.19 for ; Sat, 01 Jan 2011 01:35:39 -0800 (PST) Received: by 10.213.16.137 with SMTP id o9mr21253eba.31.1293874538926; Sat, 01 Jan 2011 01:35:38 -0800 (PST) Received: from useri.localnet ([93.125.74.3]) by mx.google.com with ESMTPS id t5sm12966414eeh.14.2011.01.01.01.35.37 (version=SSLv3 cipher=RC4-MD5); Sat, 01 Jan 2011 01:35:38 -0800 (PST) Message-ID: <4d1ef56a.857a0e0a.5005.0d21@mx.google.com> From: "Igor M. Liplianin" Date: Fri, 31 Dec 2010 13:37:00 +0200 Subject: [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c To: , , Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab On my system, cx23885 based card reports default volume value above 70000. So, register cx25840 subdev fails. Although, the card don't have a/v inputs it needs a/v firmware to be loaded. Signed-off-by: Igor M. Liplianin --- drivers/media/video/cx25840/cx25840-core.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c index dfb198d..dc0cec7 100644 --- a/drivers/media/video/cx25840/cx25840-core.c +++ b/drivers/media/video/cx25840/cx25840-core.c @@ -1991,6 +1991,8 @@ static int cx25840_probe(struct i2c_client *client, if (!is_cx2583x(state)) { default_volume = 228 - cx25840_read(client, 0x8d4); default_volume = ((default_volume / 2) + 23) << 9; + if (default_volume > 65535) + default_volume = 65535; state->volume = v4l2_ctrl_new_std(&state->hdl, &cx25840_audio_ctrl_ops, V4L2_CID_AUDIO_VOLUME,