From patchwork Mon Jun 11 13:00:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 11670 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Se4EV-00019l-RO for patchwork@linuxtv.org; Mon, 11 Jun 2012 15:00:35 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for id 1Se4EU-0007lU-FC; Mon, 11 Jun 2012 15:00:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751381Ab2FKNA3 (ORCPT ); Mon, 11 Jun 2012 09:00:29 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:46052 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748Ab2FKNA2 (ORCPT ); Mon, 11 Jun 2012 09:00:28 -0400 Received: by bkcji2 with SMTP id ji2so3490845bkc.19 for ; Mon, 11 Jun 2012 06:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=tyBNFCV8JxyJX0sALD5+iD/gJmggF0d99cdE036INDo=; b=O0x363tJXOrmRvTRMniee86CZ2HNgnXLiAPUCJgRddCeKQVz/xESfnbRJwXkWOTrWh UJMbEYALXkna4Slv0qwVJDvFoVTa2DagkhmNX4T6AVTsYRQz37jHvlHLCfnqJAn6h3K8 AVhV29Mf6WqbiR6d0RC5zwRjXptH7Sb+PZqU+LUpdBMgp4OjrExWRmhyrDi8zwtdUgvC XxC8JYqH5lKmmyXgPAuC/W0b8BfiP7P4b/lf5bS2HShw0qUgEidw65wOcD+4ZS8yYE1L zTX8L1jlb27rrQYFJyR+gqX+3o2RnbYnyr+EGL9491TqC2Abar+JPxAu78lzAG8Rdz9j lO5g== Received: by 10.204.152.13 with SMTP id e13mr10535216bkw.46.1339419626905; Mon, 11 Jun 2012 06:00:26 -0700 (PDT) Received: from [192.168.1.110] (031011252076.warszawa.vectranet.pl. [31.11.252.76]) by mx.google.com with ESMTPS id n17sm16300096bkw.5.2012.06.11.06.00.25 (version=SSLv3 cipher=OTHER); Mon, 11 Jun 2012 06:00:26 -0700 (PDT) Message-ID: <4FD5EBE9.509@gmail.com> Date: Mon, 11 Jun 2012 15:00:25 +0200 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Sachin Kamat CC: linux-media@vger.kernel.org, t.stanislaws@samsung.com, k.debski@samsung.com, s.nawrocki@samsung.com, kyungmin.park@samsung.com, mchehab@infradead.org, patches@linaro.org Subject: Re: [PATCH 3/3] [media] s5p-fimc: Replace printk with pr_* functions References: <1339409634-13657-1-git-send-email-sachin.kamat@linaro.org> <1339409634-13657-3-git-send-email-sachin.kamat@linaro.org> In-Reply-To: <1339409634-13657-3-git-send-email-sachin.kamat@linaro.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.6.11.125420 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' Hi Sachin, On 06/11/2012 12:13 PM, Sachin Kamat wrote: > Replace printk with pr_* functions to silence checkpatch warnings. > > Signed-off-by: Sachin Kamat > --- > drivers/media/video/s5p-fimc/fimc-core.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/s5p-fimc/fimc-core.h b/drivers/media/video/s5p-fimc/fimc-core.h > index 95b27ae..c22fb0a 100644 > --- a/drivers/media/video/s5p-fimc/fimc-core.h > +++ b/drivers/media/video/s5p-fimc/fimc-core.h > @@ -28,7 +28,7 @@ > #include > > #define err(fmt, args...) \ > - printk(KERN_ERR "%s:%d: " fmt "\n", __func__, __LINE__, ##args) > + pr_err("%s:%d: " fmt "\n", __func__, __LINE__, ##args) I don't think it's worth the effort. If you really want to get rid of that warnings, please remove the err() macro altogether and do something like this instead: 8<---------------------------------------------------------------- 8>---------------------------------------------------------------- Thanks! Sylwester --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/media/video/s5p-fimc/fimc-core.h b/drivers/media/video/s5p-fimc/fimc-core.h index 95b27ae..808ccc6 100644 --- a/drivers/media/video/s5p-fimc/fimc-core.h +++ b/drivers/media/video/s5p-fimc/fimc-core.h @@ -27,9 +27,6 @@ #include #include -#define err(fmt, args...) \ - printk(KERN_ERR "%s:%d: " fmt "\n", __func__, __LINE__, ##args) - #define dbg(fmt, args...) \ pr_debug("%s:%d: " fmt "\n", __func__, __LINE__, ##args) diff --git a/drivers/media/video/s5p-fimc/fimc-reg.c b/drivers/media/video/s5p-fimc/fimc-reg.c index 1fc4ce8..74a2fba 100644 --- a/drivers/media/video/s5p-fimc/fimc-reg.c +++ b/drivers/media/video/s5p-fimc/fimc-reg.c @@ -683,8 +683,8 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc, cfg |= FIMC_REG_CIGCTRL_CAM_JPEG; break; default: - v4l2_err(fimc->vid_cap.vfd, - "Not supported camera pixel format: %d", + v4l2_err(vid_cap->vfd, + "Not supported camera pixel format: %#x\n", vid_cap->mf.code); return -EINVAL; } @@ -699,7 +699,7 @@ int fimc_hw_set_camera_type(struct fimc_dev *fimc, } else if (cam->bus_type == FIMC_LCD_WB) { cfg |= FIMC_REG_CIGCTRL_CAMIF_SELWB; } else { - err("invalid camera bus type selected\n"); + v4l2_err(vid_cap->vfd, "Invalid camera bus type selected\n"); return -EINVAL; } writel(cfg, fimc->regs + FIMC_REG_CIGCTRL);