From patchwork Fri Apr 6 22:38:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rankin X-Patchwork-Id: 10599 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1SGHtf-0002QD-6X for patchwork@linuxtv.org; Sat, 07 Apr 2012 00:44:47 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for id 1SGHte-0006HN-I8; Sat, 07 Apr 2012 00:44:47 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754934Ab2DFWoo (ORCPT ); Fri, 6 Apr 2012 18:44:44 -0400 Received: from nm9.bullet.mail.ukl.yahoo.com ([217.146.182.250]:30212 "HELO nm9.bullet.mail.ukl.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754601Ab2DFWon (ORCPT ); Fri, 6 Apr 2012 18:44:43 -0400 X-Greylist: delayed 380 seconds by postgrey-1.27 at vger.kernel.org; Fri, 06 Apr 2012 18:44:43 EDT Received: from [217.146.183.210] by nm9.bullet.mail.ukl.yahoo.com with NNFMP; 06 Apr 2012 22:38:22 -0000 Received: from [217.146.183.204] by tm3.bullet.mail.ukl.yahoo.com with NNFMP; 06 Apr 2012 22:38:22 -0000 Received: from [127.0.0.1] by omp1002.bt.mail.ukl.yahoo.com with NNFMP; 06 Apr 2012 22:38:22 -0000 X-Yahoo-Newman-Id: 786350.34822.bm@omp1002.bt.mail.ukl.yahoo.com Received: (qmail 92818 invoked from network); 6 Apr 2012 22:38:22 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=DKIM-Signature:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=WCPm7D2I8Nz2K2XvIcjhuxRBMnmuYWo5xf1flXKx8EGIAwV+qQA8qZ+WzLPaAvTi5PadRTlzcs97Hr9euuYLiboQFD0jRKlM1gU2VLm3YBrYSJW3l/iTQ+xIr7NbnnEldKOoCe9EnbYDx5v0yUJ0d2Nsbin/JEh8W6892qAKf4s= ; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1333751902; bh=SZbJ9OAJVMZmqiTdYLJHvRSq8EB+s0oMCrd1B1hgLy8=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=LU1g5gkDlW8KCxebWUv/iHuOqr+uVHKRQPnshN14B2R9LbzDdm8Ix++Iassh+z5kzfTvOpNWvXFORg/vsKA46hp1aMPA0mQ3zdhGdvtZSyUVbGzBKRV/cATobp9w1Elk/ut9mHYLzacyDKz90cLctZMn2+FRYhwdI5dkPKm3Wgc= X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: Qelajt4VM1nOIN8T4SMzSW4ILku3d1KJiElTfxjP1t4rdF1 2VKWcSCl_2dmM.oK_c5ifCvDc0P37tQc6ULuPyuoogXe2Y3CH6049BzKb96g vXHfmTluV.XcXpZ2fPgaKhVV7wr9V19BbjcmKR8_VnDTAMo2HTuwWEjru4d7 KLk5TB6L5YbHu9BpYQA2BhKlt5genM7AiBTHkvogJwWedRCKK.WJxSkMqlz0 vfRM9Qi5YM2hMV.ISGh5W5rvghRFoA4HSasQMA24j9nJ2u26jlykNdxWfEAq XHSNY28ktBo9usRbVeD9w..kUoF4E7KY4JgpBj1nJVRFiMbJK56_2ym2FdpI s7JnCDlJT0vxsSM73B42WJchoQpenOsWg8f2arIDkgVwnuQYgnmA4uWmpu1F HBB4mbaQm8CZPoprryg-- X-Yahoo-SMTP: dMK34oyswBBlfKesWTI5ovDjFOUFE6shtILt.ZXnUEjQHhWq Received: from wellhouse.underworld (rankincj@86.180.123.66 with login) by smtp828.mail.ird.yahoo.com with SMTP; 06 Apr 2012 15:38:22 -0700 PDT Received: from volcano.underworld (volcano.underworld [192.168.0.3]) by wellhouse.underworld (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q36McIfs013751 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 6 Apr 2012 23:38:21 +0100 Message-ID: <4F7F705A.3010507@yahoo.com> Date: Fri, 06 Apr 2012 23:38:18 +0100 From: Chris Rankin User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Subject: [PATCH v2] Linux 3.3 DVB userspace ABI broken for xine (FE_SET_FRONTEND) References: <4F7F4CAF.4010501@yahoo.com> In-Reply-To: <4F7F4CAF.4010501@yahoo.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.4.6.223022 X-PMX-Spam: Gauge=XI, Probability=11%, Report=' RCVD_YAHOO_SMTP 0.5, FORGED_FROM_YAHOO 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MIME_TEXT_ONLY_MP_MIXED 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, ECARD_KNOWN_DOMAINS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BAT_BOUNDARY 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __DOMAINKEYS_YAHOO 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_YAHOO 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' I've had a closer look at the commit which caused the regression and it looks like there were two places where fepriv->parameters_in was assigned to fepriv->parameters_out. So I've updated my patch accordingly. Cheers, Chris Signed-off-by: Chris Rankin --- linux-3.3/drivers/media/dvb/dvb-core/dvb_frontend.c.orig 2012-04-06 20:16:02.000000000 +0100 +++ linux-3.3/drivers/media/dvb/dvb-core/dvb_frontend.c 2012-04-06 23:16:03.000000000 +0100 @@ -143,6 +143,8 @@ static void dvb_frontend_wakeup(struct dvb_frontend *fe); static int dtv_get_frontend(struct dvb_frontend *fe, struct dvb_frontend_parameters *p_out); +static int dtv_property_legacy_params_sync(struct dvb_frontend *fe, + struct dvb_frontend_parameters *p); static bool has_get_frontend(struct dvb_frontend *fe) { @@ -695,6 +697,7 @@ fepriv->algo_status |= DVBFE_ALGO_SEARCH_AGAIN; fepriv->delay = HZ / 2; } + dtv_property_legacy_params_sync(fe, &fepriv->parameters_out); fe->ops.read_status(fe, &s); if (s != fepriv->status) { dvb_frontend_add_event(fe, s); /* update event list */ @@ -1831,6 +1834,13 @@ return -EINVAL; /* + * Initialize output parameters to match the values given by + * the user. FE_SET_FRONTEND triggers an initial frontend event + * with status = 0, which copies output parameters to userspace. + */ + dtv_property_legacy_params_sync(fe, &fepriv->parameters_out); + + /* * Be sure that the bandwidth will be filled for all * non-satellite systems, as tuners need to know what * low pass/Nyquist half filter should be applied, in