From patchwork Fri Apr 6 14:59:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rankin X-Patchwork-Id: 10597 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1SGAdB-0001mY-Fu for patchwork@linuxtv.org; Fri, 06 Apr 2012 16:59:17 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1SGAdA-000622-CN; Fri, 06 Apr 2012 16:59:17 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757324Ab2DFO7M (ORCPT ); Fri, 6 Apr 2012 10:59:12 -0400 Received: from nm17.bullet.mail.ird.yahoo.com ([77.238.189.70]:40313 "HELO nm17.bullet.mail.ird.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754840Ab2DFO7M (ORCPT ); Fri, 6 Apr 2012 10:59:12 -0400 Received: from [77.238.189.48] by nm17.bullet.mail.ird.yahoo.com with NNFMP; 06 Apr 2012 14:59:10 -0000 Received: from [212.82.108.226] by tm1.bullet.mail.ird.yahoo.com with NNFMP; 06 Apr 2012 14:59:10 -0000 Received: from [127.0.0.1] by omp1003.bt.mail.ird.yahoo.com with NNFMP; 06 Apr 2012 14:59:10 -0000 X-Yahoo-Newman-Id: 467565.87799.bm@omp1003.bt.mail.ird.yahoo.com Received: (qmail 56518 invoked from network); 6 Apr 2012 14:59:10 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=DKIM-Signature:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=POFwKX1whokeLizq+NdrGd/OUBzeRbrGSN92gs1UJKuB9kHeA2qVNXefHrC5y1ApvppmWs1kzX98rKRYWueOlYK8PBcsUf7gVrDtANeveHnjyBzl41x5iVWEz57/EDs6VbpM6eAUQK4yqHD8Abjvs6JMGou6n5/poOC7zCzFf7Q= ; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1333724350; bh=grkq/QmVxQq7EKoqiUoHHq+vIkkCqPTwrLgmB8AK76g=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=5s5ps/PJ9bNG5kCXvm2liFmlp47ZTcu0hoy4NYq7cowLuL+2mwhAvGcGu5ATSvyZVLG+qMzqIvW5OscCuY9VQfk52IxfWp9m2FNCnnKL708rdLzxALYIv0diauvviHMM23ik6MDmK7x3qE6pnxqR90VZ3vcaHAwhTdEz/a7eTDU= X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: IWqRH2IVM1mIumhQrENYPuZRtceFOZZ0bDbGCZWMNimjLsk gZObedTkqmPphMaopPYDRYxMoIBvBaO4oNM1QDomyhmcOAJTYFI_tg11QHlT wxdzXsN1qG0V.pRJCiH3JJwaKmBqBoH0XRqFj7vQl4B.KAhySrwkM84K4ntX zgXsJnZvadB0vjY6orbt4NEgwshrrMs20jUumgl7UAqcl0IGMwHQlu0fv59i 8Hm6qRBDyf5ulrwRV8rXtMR4w4EaM3n3DMxvkf2j7MWp71prg5VjjCCSuUIk ew2HbahD9qP1MQdO32y5TuKQY7bSFbxoJxUZXRlbgBJAy1KHVcEq8AD0meKp 2FgRvcSGrpbdev4ipz9qK9phNSm5UIcUXJNIWA8aYm1vppDFZEVhESyljwwo V_DCmEUHmAw47GscbwA-- X-Yahoo-SMTP: dMK34oyswBBlfKesWTI5ovDjFOUFE6shtILt.ZXnUEjQHhWq Received: from wellhouse.underworld (rankincj@86.180.123.66 with login) by smtp829.mail.ird.yahoo.com with SMTP; 06 Apr 2012 07:59:10 -0700 PDT Received: from volcano.underworld (volcano.underworld [192.168.0.3]) by wellhouse.underworld (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id q36Ex58N012981 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 6 Apr 2012 15:59:08 +0100 Message-ID: <4F7F04B9.1040802@yahoo.com> Date: Fri, 06 Apr 2012 15:59:05 +0100 From: Chris Rankin User-Agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 MIME-Version: 1.0 To: crope@iki.fi CC: linux-media@vger.kernel.org Subject: Re: DVB ioctl FE_GET_EVENT behaviour broken in 3.3 References: <4F7ED7E9.203@iki.fi> In-Reply-To: <4F7ED7E9.203@iki.fi> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.4.6.144814 X-PMX-Spam: Gauge=X, Probability=10%, Report=' RCVD_YAHOO_SMTP 0.5, FORGED_FROM_YAHOO 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __DOMAINKEYS_YAHOO 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_YAHOO 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' The problem is that the following line was deleted from the FE_SET_FRONTEND ioctl logic: fepriv->parameters_out = fepriv->parameters_in; The following dirty little patch restores the correct behaviour: &fetunesettings) == 0)) { I'm hoping that someone out there who understands the new logic better than I can provide a better patch. Cheers, Chris --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- dvb_frontend.c.orig 2012-04-06 13:28:43.000000000 +0100 +++ dvb_frontend.c 2012-04-06 15:42:04.000000000 +0100 @@ -1877,6 +1877,8 @@ if (c->hierarchy == HIERARCHY_NONE && c->code_rate_LP == FEC_NONE) c->code_rate_LP = FEC_AUTO; + fepriv->parameters_out.frequency = c->frequency; + /* get frontend-specific tuning settings */ memset(&fetunesettings, 0, sizeof(struct dvb_frontend_tune_settings)); if (fe->ops.get_tune_settings && (fe->ops.get_tune_settings(fe,