From patchwork Sun Mar 4 22:19:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gianluca Gennari X-Patchwork-Id: 10175 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1S4JmQ-0005GO-PS for patchwork@linuxtv.org; Sun, 04 Mar 2012 23:19:50 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1S4JmQ-0001j2-9h; Sun, 04 Mar 2012 23:19:50 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753057Ab2CDWTr (ORCPT ); Sun, 4 Mar 2012 17:19:47 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:55129 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751212Ab2CDWTq (ORCPT ); Sun, 4 Mar 2012 17:19:46 -0500 Received: by eekc41 with SMTP id c41so1253573eek.19 for ; Sun, 04 Mar 2012 14:19:45 -0800 (PST) Received-SPF: pass (google.com: domain of gennarone@gmail.com designates 10.213.29.8 as permitted sender) client-ip=10.213.29.8; Authentication-Results: mr.google.com; spf=pass (google.com: domain of gennarone@gmail.com designates 10.213.29.8 as permitted sender) smtp.mail=gennarone@gmail.com; dkim=pass header.i=gennarone@gmail.com Received: from mr.google.com ([10.213.29.8]) by 10.213.29.8 with SMTP id o8mr2692788ebc.84.1330899585101 (num_hops = 1); Sun, 04 Mar 2012 14:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=ex87yaLUOiPru2zomXjA0okVuI136+hCdL8nfpRwvlo=; b=Z8VhtLjp8TBGBw0DNjrC3RqE9EwJVCcnrECN1To0PikCrmfXlwCw6weRmteG7vbgOo MD9pt+38m+AIUfPxV3o3kB+Z1UooGekPy2oq7KszYffNI5pH5lyGxnTQ/0tfAjMLAlxm JBsBiEOoI3lfsL93tVLefULcOa/tGfgL4uJGov4kZyJ0bic55rwhZJB/CU/7BqpcSez6 DQU979rGIDo9Aeq20v0nqWyFmN57G070ZSJtg6h+DNoHhKD33QnCzCdMNym0N12+FUTC IbAEtZ+A9lcH41V/GHFay+TgIT2BZIT2Mnui8M+gfK1tKMA0EjoTtG2wj6xqMggk89Us qufA== Received: by 10.213.29.8 with SMTP id o8mr2034280ebc.84.1330899584235; Sun, 04 Mar 2012 14:19:44 -0800 (PST) Received: from [192.168.2.3] (93-50-34-119.ip150.fastwebnet.it. [93.50.34.119]) by mx.google.com with ESMTPS id s48sm53699156eem.0.2012.03.04.14.19.42 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 04 Mar 2012 14:19:43 -0800 (PST) Message-ID: <4F53EA7D.4090402@gmail.com> Date: Sun, 04 Mar 2012 23:19:41 +0100 From: Gianluca Gennari Reply-To: gennarone@gmail.com User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Geert Uytterhoeven , linux-media@vger.kernel.org CC: Antti Palosaari , Mauro Carvalho Chehab , Linux-Next Subject: Re: rtl2830: __udivdi3 undefined References: In-Reply-To: X-Enigmail-Version: 1.3.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.3.4.220622 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1800_1899 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FRAUD_WEBMAIL_REPLYTO 0, __FROM_GMAIL 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __STOCK_PHRASE_7 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' Il 29/02/2012 22:30, Geert Uytterhoeven ha scritto: > http://kisskb.ellerman.id.au/kisskb/buildresult/5759200/ ERROR: > "__udivdi3" [drivers/media/dvb/frontends/rtl2830.ko] undefined! > > I didn't look too deeply into it, but I think it's caused by the > "num /= priv->cfg.xtal" in rtl2830_init() (with num being u64). > > Can't it use do_div() instead? > > Gr{oetje,eeting}s, > > Geert > > -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- > geert@linux-m68k.org > > In personal conversations with technical people, I call myself a > hacker. But when I'm talking to journalists I just say "programmer" > or something like that. -- Linus Torvalds -- To unsubscribe from this > list: send the line "unsubscribe linux-media" in the body of a > message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html > Probably the best solution is to use div_u64. The following patch fixed the warning on my 32 bit system. Signed-off-by: Gianluca Gennari Acked-by: Geert Uytterhoeven Acked-by: Antti Palosaari --- drivers/media/dvb/frontends/rtl2830.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/frontends/rtl2830.c b/drivers/media/dvb/frontends/rtl2830.c index f971d94..45196c5 100644 --- a/drivers/media/dvb/frontends/rtl2830.c +++ b/drivers/media/dvb/frontends/rtl2830.c @@ -244,7 +244,7 @@ static int rtl2830_init(struct dvb_frontend *fe) num = priv->cfg.if_dvbt % priv->cfg.xtal; num *= 0x400000; - num /= priv->cfg.xtal; + num = div_u64(num, priv->cfg.xtal); num = -num; if_ctl = num & 0x3fffff; dbg("%s: if_ctl=%08x", __func__, if_ctl);