From patchwork Fri Dec 23 13:29:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Oberritter X-Patchwork-Id: 8973 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Re5CF-0006af-E8; Fri, 23 Dec 2011 14:30:27 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp id 1Re5CE-0003bf-E3; Fri, 23 Dec 2011 14:30:03 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757157Ab1LWNaA (ORCPT + 3 others); Fri, 23 Dec 2011 08:30:00 -0500 Received: from ffm.saftware.de ([83.141.3.46]:42861 "EHLO ffm.saftware.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757155Ab1LWN37 (ORCPT ); Fri, 23 Dec 2011 08:29:59 -0500 Received: from localhost (localhost [127.0.0.1]) by ffm.saftware.de (Postfix) with ESMTP id 70F282C17B1; Fri, 23 Dec 2011 14:29:55 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at ffm.saftware.de Received: from ffm.saftware.de ([127.0.0.1]) by localhost (ffm.saftware.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gR-gn9G-5NpY; Fri, 23 Dec 2011 14:29:54 +0100 (CET) Message-ID: <4EF48250.5090305@linuxtv.org> Date: Fri, 23 Dec 2011 14:29:52 +0100 From: Andreas Oberritter User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0 MIME-Version: 1.0 To: Antti Palosaari CC: linux-media , Patrick Boettcher Subject: [RFC] remove dtv_property_dump et al References: <4EF3A171.3030906@iki.fi> In-Reply-To: <4EF3A171.3030906@iki.fi> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.12.23.132122 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, MIME_TEXT_ONLY_MP_MIXED 0.05, MSGID_ADDED_BY_MTA 0.05, BODYTEXTP_SIZE_3000_LESS 0, __ANY_URI 0, __BAT_BOUNDARY 0, __CP_URI_IN_BODY 0, __CT 0, __CTYPE_HAS_BOUNDARY 0, __CTYPE_MULTIPART 0, __CTYPE_MULTIPART_MIXED 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' X-LSpam-Score: -1.9 (-) X-LSpam-Report: No, score=-1.9 required=5.0 tests=BAYES_00=-1.9, T_TVD_MIME_EPI=0.01 autolearn=ham On 22.12.2011 22:30, Antti Palosaari wrote: > Rename DMB-TH to DTMB. > > Add few new values for existing parameters. > > Add two new parameters, interleaving and carrier. > DTMB supports interleavers: 240 and 720. > DTMB supports carriers: 1 and 3780. > > Signed-off-by: Antti Palosaari > --- > drivers/media/dvb/dvb-core/dvb_frontend.c | 19 ++++++++++++++++++- > drivers/media/dvb/dvb-core/dvb_frontend.h | 3 +++ > include/linux/dvb/frontend.h | 13 +++++++++++-- > include/linux/dvb/version.h | 2 +- > 4 files changed, 33 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c > b/drivers/media/dvb/dvb-core/dvb_frontend.c > index 821b225..ec2cbae 100644 > --- a/drivers/media/dvb/dvb-core/dvb_frontend.c > +++ b/drivers/media/dvb/dvb-core/dvb_frontend.c > @@ -924,6 +924,8 @@ static struct dtv_cmds_h dtv_cmds[DTV_MAX_COMMAND + > 1] = { > _DTV_CMD(DTV_CODE_RATE_LP, 1, 0), > _DTV_CMD(DTV_GUARD_INTERVAL, 1, 0), > _DTV_CMD(DTV_TRANSMISSION_MODE, 1, 0), > + _DTV_CMD(DTV_CARRIER, 1, 0), > + _DTV_CMD(DTV_INTERLEAVING, 1, 0), > > _DTV_CMD(DTV_ISDBT_PARTIAL_RECEPTION, 1, 0), > _DTV_CMD(DTV_ISDBT_SOUND_BROADCASTING, 1, 0), > @@ -974,6 +976,8 @@ static struct dtv_cmds_h dtv_cmds[DTV_MAX_COMMAND + > 1] = { > _DTV_CMD(DTV_GUARD_INTERVAL, 0, 0), > _DTV_CMD(DTV_TRANSMISSION_MODE, 0, 0), > _DTV_CMD(DTV_HIERARCHY, 0, 0), > + _DTV_CMD(DTV_CARRIER, 0, 0), > + _DTV_CMD(DTV_INTERLEAVING, 0, 0), > > _DTV_CMD(DTV_ENUM_DELSYS, 0, 0), > }; Adding this twice is wrong. Almost every time new commands were added in the recent past, either the command was not added to this table at all or the command was added more than once. How about removing this array instead? It's only purpose is to output ioctl parameters, which can be done with strace as well. Actually, I have two patches queued doing that (see attachments). They are based on 3.0. Regards, Andreas From bd707ac783dae5ea958f8480fce84bb89c28535f Mon Sep 17 00:00:00 2001 From: Andreas Oberritter Date: Tue, 13 Sep 2011 14:13:24 +0000 Subject: [PATCH 2/2] [RFC] DVB: remove unused DTV_MAX_COMMAND from frontend.h - This value was exported to userspace but serves no purpose. Signed-off-by: Andreas Oberritter --- include/linux/dvb/frontend.h | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/linux/dvb/frontend.h b/include/linux/dvb/frontend.h index 81f813d..37a4d38 100644 --- a/include/linux/dvb/frontend.h +++ b/include/linux/dvb/frontend.h @@ -316,8 +316,6 @@ struct dvb_frontend_event { #define DTV_DVBT2_PLP_ID 43 -#define DTV_MAX_COMMAND DTV_DVBT2_PLP_ID - typedef enum fe_pilot { PILOT_ON, PILOT_OFF, -- 1.7.2.5