From patchwork Mon Nov 7 19:57:51 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sylwester Nawrocki X-Patchwork-Id: 8345 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1RNVKT-00018a-87; Mon, 07 Nov 2011 20:58:01 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-1) with esmtp id 1RNVKS-0003Fx-L6; Mon, 07 Nov 2011 20:58:01 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976Ab1KGT56 (ORCPT + 3 others); Mon, 7 Nov 2011 14:57:58 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:46365 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348Ab1KGT55 (ORCPT ); Mon, 7 Nov 2011 14:57:57 -0500 Received: by faan17 with SMTP id n17so369538faa.19 for ; Mon, 07 Nov 2011 11:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=HTC6Q1BfCbP6UDO7bOag0j/FULI15dVO3Gbie/0LtP0=; b=F5ReQf1xPVr8bAloIDpgb+YG5FowaBfwKyPFhRHoDvZOEU1RJdzjF0GyVpdfI2qY6H EVSQ5/tfXwCn4srD5UNiatXYq1oPDZ7vcmn6F3sJFEyMoYiXQUUtu+ZumM9rxi9dk0rK Z+uDsx7AZDOkpNc1IlF3bm3ykuAR++212c9Eg= Received: by 10.223.76.135 with SMTP id c7mr49125639fak.14.1320695876380; Mon, 07 Nov 2011 11:57:56 -0800 (PST) Received: from [192.168.2.102] (84-dzi-26.acn.waw.pl. [85.222.29.84]) by mx.google.com with ESMTPS id w11sm32572728fad.7.2011.11.07.11.57.54 (version=SSLv3 cipher=OTHER); Mon, 07 Nov 2011 11:57:55 -0800 (PST) Message-ID: <4EB8383F.2000201@gmail.com> Date: Mon, 07 Nov 2011 20:57:51 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: gennarone@gmail.com CC: linux-media , Devin Heitmueller Subject: Re: [PATCH 00/13] Remaining coding style clean up of AS102 driver References: <1320611510-3326-1-git-send-email-snjw23@gmail.com> <4EB7F709.2050503@gmail.com> <4EB802A0.7030600@gmail.com> In-Reply-To: <4EB802A0.7030600@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.11.7.193915 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_MSGID 0, __HAS_X_MAILING_LIST 0, __LINES_OF_YELLING 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MOZILLA_MSGID 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __USER_AGENT 0' X-LSpam-Score: -4.2 (----) X-LSpam-Report: No, score=-4.2 required=5.0 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_MED=-2.3, T_DKIM_INVALID=0.01 autolearn=ham Hi Gianluca, On 11/07/2011 05:09 PM, Gianluca Gennari wrote: > Hi Sylwestwer, > I was about to test the new driver when I discovered that my as102 > device is not included in the list of supported devices: > > /* Super Digi KEY */ > #define AS102_SUPER_DIGI_NAME "Super Digi KEY" > #define SUPER_DIGI_USB_VID 0x2137 > #define SUPER_DIGI_USB_PID 0x0001 > > It's a "Digital key" offered by Sky Italia to its customers to watch > terrestrial programs with the Sky satellite decoders. I'm not sure if your device needs some special handling, but it might work if you repeat steps as in this patch: http://git.linuxtv.org/media_tree.git/commitdiff/5f9745b2c942b2ab220831b2c51a18c3f1374249 Have you tried it already ? Possibly something like this is enough (only compile tested): diff --git a/drivers/staging/media/as102/as102_usb_drv.c b/drivers/staging/media/as102/as102_usb_drv.c index 9faab5b..9edb366 100644 --- a/drivers/staging/media/as102/as102_usb_drv.c +++ b/drivers/staging/media/as102/as102_usb_drv.c @@ -42,6 +42,7 @@ static struct usb_device_id as102_usb_id_table[] = { { USB_DEVICE(PCTV_74E_USB_VID, PCTV_74E_USB_PID) }, { USB_DEVICE(ELGATO_EYETV_DTT_USB_VID, ELGATO_EYETV_DTT_USB_PID) }, { USB_DEVICE(NBOX_DVBT_DONGLE_USB_VID, NBOX_DVBT_DONGLE_USB_PID) }, + { USB_DEVICE(SUPER_DIGI_USB_VID, SUPER_DIGI_USB_PID) }, { } /* Terminating entry */ }; @@ -52,6 +53,7 @@ static const char * const as102_device_names[] = { AS102_PCTV_74E, AS102_ELGATO_EYETV_DTT_NAME, AS102_NBOX_DVBT_DONGLE_NAME, + AS102_SUPER_DIGI_NAME, NULL /* Terminating entry */ }; diff --git a/drivers/staging/media/as102/as102_usb_drv.h b/drivers/staging/media/as102/as102_usb_drv.h index 35925b7..6f95af2 100644 --- a/drivers/staging/media/as102/as102_usb_drv.h +++ b/drivers/staging/media/as102/as102_usb_drv.h @@ -47,6 +47,11 @@ #define NBOX_DVBT_DONGLE_USB_VID 0x0b89 #define NBOX_DVBT_DONGLE_USB_PID 0x0007 +/* Super Digi KEY */ +#define AS102_SUPER_DIGI_NAME "Super Digi KEY" +#define SUPER_DIGI_USB_VID 0x2137 +#define SUPER_DIGI_USB_PID 0x0001 + My knowledge about this driver is rather limited, in case of any issues I guess it's best to ask Devin directly.