From patchwork Mon Sep 5 14:26:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rankin X-Patchwork-Id: 7772 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Mon, 05 Sep 2011 14:26:40 +0000 Received: from casper.infradead.org [85.118.1.10] by localhost.localdomain with IMAP (fetchmail-6.3.17) for (single-drop); Mon, 05 Sep 2011 11:27:23 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1R0a8G-0002mk-Df; Mon, 05 Sep 2011 14:26:40 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754146Ab1IEO0i (ORCPT + 1 other); Mon, 5 Sep 2011 10:26:38 -0400 Received: from nm2.bt.bullet.mail.ukl.yahoo.com ([217.146.183.200]:45391 "HELO nm2.bt.bullet.mail.ukl.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753559Ab1IEO0h (ORCPT ); Mon, 5 Sep 2011 10:26:37 -0400 Received: from [217.146.183.197] by nm2.bt.bullet.mail.ukl.yahoo.com with NNFMP; 05 Sep 2011 14:26:36 -0000 Received: from [217.146.183.205] by tm3.bt.bullet.mail.ukl.yahoo.com with NNFMP; 05 Sep 2011 14:26:36 -0000 Received: from [127.0.0.1] by omp1003.bt.mail.ukl.yahoo.com with NNFMP; 05 Sep 2011 14:26:36 -0000 X-Yahoo-Newman-Id: 341612.62649.bm@omp1003.bt.mail.ukl.yahoo.com Received: (qmail 35331 invoked from network); 5 Sep 2011 14:26:36 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=DKIM-Signature:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=gGlcvQbis97Eb4FCM3qfGOiUottlCVqCL/vjL2g60dteFf5yCWbmEDHnHSs48V9e1MegbRkphe0bV40GI2rsblmyVnE+Ve4sf4ZXGYvm+/qWn/VHJyM/XtWis5JTErAt4VexKHFOS1BLYNreJwWaqnPq7HCYJKgOilm27Gzdpsc= ; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1315232796; bh=X5jojB0h2hCKj6c6UaJawdOaXnHxEHkcSFk35S1hBJ4=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=3gI13c+v+LFpxXp4CR52PEIIElan2n2cLbwbOP0VrIC4CJop8+uiUov4Kzj+44kKf0BIAx3KiSsgbUj05hm1bO3/gyQoqestsnquO5omdUZ3FOhzXCeaUdhpLypW5TZTmgMiH159yhRdgkTd4QkjIP9qNIBjMHyGbU2uBx1W/qQ= X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: EaeR0JkVM1lAP4GRUOLpRkpRLkUTEFdA7H.8CtMWxJoWFe7 yQBM6rRyY X-Yahoo-SMTP: dMK34oyswBBlfKesWTI5ovDjFOUFE6shtILt.ZXnUEjQHhWq Received: from wellhouse.underworld (rankincj@86.183.126.7 with login) by smtp819.mail.ird.yahoo.com with SMTP; 05 Sep 2011 14:26:35 +0000 GMT Received: from volcano.underworld (volcano.underworld [192.168.0.3]) by wellhouse.underworld (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id p85EQWUL014151 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 5 Sep 2011 15:26:34 +0100 Message-ID: <4E64DC18.1060308@yahoo.com> Date: Mon, 05 Sep 2011 15:26:32 +0100 From: Chris Rankin User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Antti Palosaari , linux-media@vger.kernel.org Subject: Re: ERROR: "em28xx_add_into_devlist" [drivers/media/video/em28xx/em28xx.ko] undefined! References: <4E640DBB.8010504@iki.fi> <4E64148A.3010704@yahoo.com> <4E6416D6.2060706@iki.fi> <4E64192E.7060505@yahoo.com> <4E64D566.4070105@redhat.com> In-Reply-To: <4E64D566.4070105@redhat.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 05/09/11 14:57, Mauro Carvalho Chehab wrote: > Could you please provide me a patch for it? I'll merge with your original one > when submitting it upstream. Here you go. Did you also pick up the other merge fix and the (separate) memory leak fix, please? Cheers, Chris Signed-off-by: Chris Rankin --- linux/drivers/media/video/em28xx/em28xx-cards.c.orig 2011-09-05 15:21:38.000000000 +0100 +++ linux/drivers/media/video/em28xx/em28xx-cards.c 2011-09-05 15:21:55.000000000 +0100 @@ -2885,7 +2885,6 @@ retval = em28xx_audio_setup(dev); if (retval) return -ENODEV; - em28xx_add_into_devlist(dev); em28xx_init_extension(dev); return 0;