From patchwork Sat Aug 20 11:31:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rankin X-Patchwork-Id: 273 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sat, 20 Aug 2011 11:31:17 +0000 Received: from casper.infradead.org [85.118.1.10] by gaivota with IMAP (fetchmail-6.3.20) for (single-drop); Sat, 20 Aug 2011 04:50:33 -0700 (PDT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Qujlk-0007P7-OB; Sat, 20 Aug 2011 11:31:17 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752966Ab1HTLbM (ORCPT + 1 other); Sat, 20 Aug 2011 07:31:12 -0400 Received: from nm1-vm0.bt.bullet.mail.ird.yahoo.com ([212.82.108.94]:30475 "HELO nm1-vm0.bt.bullet.mail.ird.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752456Ab1HTLbK (ORCPT ); Sat, 20 Aug 2011 07:31:10 -0400 Received: from [212.82.108.230] by nm1.bt.bullet.mail.ird.yahoo.com with NNFMP; 20 Aug 2011 11:31:09 -0000 Received: from [212.82.108.224] by tm3.bt.bullet.mail.ird.yahoo.com with NNFMP; 20 Aug 2011 11:31:09 -0000 Received: from [127.0.0.1] by omp1001.bt.mail.ird.yahoo.com with NNFMP; 20 Aug 2011 11:31:09 -0000 X-Yahoo-Newman-Id: 479044.79712.bm@omp1001.bt.mail.ird.yahoo.com Received: (qmail 92989 invoked from network); 20 Aug 2011 11:31:09 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=DKIM-Signature:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=2T3052jOzvhng/+NWzQp7l8FqidobXwPdW7Dr64nj7+sD0OeNkDR/hrzcYrQPGDJ3EHhoRnaC9oauGJL+X+iM8yN+2X0FWuiC2DIVndNp4MaOQsDfKhHswy9wlLMm/Fj/9nOKMSQiTrNWrq9/GLPQ3PFdcUZbhTrUFotXN1nTnA= ; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1313839869; bh=vd7sUTeu/DQvqiV4jwL7GJVQ6OFBV24ketuZqPbv8RY=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=n+4OTA82hryZeUm1HukJgDcfqacVf2IFn4+n+TT+IzzQgDBBrzD29c9LV/5+5jH6ztJeIS/d+7OLLmL/N+ewOvdZ/Pp6QEG0re+9mWZpEOepB7ONQaPAobl48Glis7LOfzFeIsPSM3qQyKPLjFc4ZvLhK5BjrC9syDhWY+c3oLs= X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: zQ2o_u4VM1nXQOOpCzJ4.5UXo8WE3Whob3saLSwclRL3mK6 8thfG5TDwaXLjZmoMZuA_ve9BkEPz_sT9.DkE5dm2r4sjk5D.p9gfOzlA2V3 tKKOCz0VyEuxhBXZIQg3ofLaz0E2Qp0RTznAGOGGJ0qdr3C0N7AB1xeX6Chd Kvabq.LR2Oj.zAaCebgrD10i3M6nJLdM_xjdoRCqCBqLMhETRiFyDh6T6PUU I9bhY9I0eTRGxBEf_Iarpp1c2RDkvFRTM3v_XGHChz_0o7f7b4Q_H9SvVDEL W3ETWDEjmdQ5hS6qS9VO4R7glq4aHSn0iXZuhJgG3uJbInB395Z47Cxu4W8D GB.VzaW6k9.XY3zvHeMbX443HATebDaJxWaTI1O5HGusL.xmf0f9qAuRH.vS ozw-- X-Yahoo-SMTP: dMK34oyswBBlfKesWTI5ovDjFOUFE6shtILt.ZXnUEjQHhWq Received: from wellhouse.underworld (rankincj@86.182.26.38 with login) by smtp816.mail.ukl.yahoo.com with SMTP; 20 Aug 2011 11:31:09 +0000 GMT Received: from volcano.underworld (volcano.underworld [192.168.0.3]) by wellhouse.underworld (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id p7KBV5Tc011469 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 20 Aug 2011 12:31:08 +0100 Message-ID: <4E4F9AF9.4060604@yahoo.com> Date: Sat, 20 Aug 2011 12:31:05 +0100 From: Chris Rankin User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: Devin Heitmueller , linux-media@vger.kernel.org, Antti Palosaari Subject: [PATCH 5/6] EM28xx - move printk lines outside mutex lock References: <4E4D5157.2080406@yahoo.com> <4E4D8DFD.5060800@yahoo.com> <4E4DFA65.4090508@redhat.com> In-Reply-To: <4E4DFA65.4090508@redhat.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There's no reason to still be holding the device list mutex for either of these printk statements. Signed-off-by: Chris Rankin --- linux-3.0/drivers/media/video/em28xx/em28xx-core.c.orig 2011-08-18 23:05:50.000000000 +0100 +++ linux-3.0/drivers/media/video/em28xx/em28xx-core.c 2011-08-18 23:07:02.000000000 +0100 @@ -1186,8 +1186,8 @@ list_for_each_entry(dev, &em28xx_devlist, devlist) { ops->init(dev); } - printk(KERN_INFO "Em28xx: Initialized (%s) extension\n", ops->name); mutex_unlock(&em28xx_devlist_mutex); + printk(KERN_INFO "Em28xx: Initialized (%s) extension\n", ops->name); return 0; } EXPORT_SYMBOL(em28xx_register_extension); @@ -1200,9 +1200,9 @@ list_for_each_entry(dev, &em28xx_devlist, devlist) { ops->fini(dev); } - printk(KERN_INFO "Em28xx: Removed (%s) extension\n", ops->name); list_del(&ops->next); mutex_unlock(&em28xx_devlist_mutex); + printk(KERN_INFO "Em28xx: Removed (%s) extension\n", ops->name); } EXPORT_SYMBOL(em28xx_unregister_extension);