From patchwork Thu Aug 18 22:11:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rankin X-Patchwork-Id: 262 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Thu, 18 Aug 2011 22:11:18 +0000 Received: from casper.infradead.org [85.118.1.10] by gaivota with IMAP (fetchmail-6.3.20) for (single-drop); Thu, 18 Aug 2011 17:57:22 -0700 (PDT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QuAo1-0000eQ-US; Thu, 18 Aug 2011 22:11:18 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754598Ab1HRWLP (ORCPT + 1 other); Thu, 18 Aug 2011 18:11:15 -0400 Received: from nm4-vm0.bt.bullet.mail.ukl.yahoo.com ([217.146.182.229]:47283 "HELO nm4-vm0.bt.bullet.mail.ukl.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1754351Ab1HRWLO (ORCPT ); Thu, 18 Aug 2011 18:11:14 -0400 Received: from [217.146.183.198] by nm4.bt.bullet.mail.ukl.yahoo.com with NNFMP; 18 Aug 2011 22:11:13 -0000 Received: from [217.146.183.203] by tm4.bt.bullet.mail.ukl.yahoo.com with NNFMP; 18 Aug 2011 22:11:13 -0000 Received: from [127.0.0.1] by omp1001.bt.mail.ukl.yahoo.com with NNFMP; 18 Aug 2011 22:11:13 -0000 X-Yahoo-Newman-Id: 69213.45730.bm@omp1001.bt.mail.ukl.yahoo.com Received: (qmail 38919 invoked from network); 18 Aug 2011 22:11:12 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=DKIM-Signature:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=XuZUl3rT+FheGsyHVnYdsCzkljl+l6ZCVcniiqq4rvPOpJubYdbuCm4Cs252MLJDiailvu/CUQnrzLtKS1ZDOdm6Ip3BMboP2CqhQM61zVlpy26xJX2BJisSKYLCvRFbJWcB29eiUMvC+8HKv+MlPT0gcZ46jcpH956H5l4AVdU= ; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1313705472; bh=viN61IaKbz1pPqpnhDAbHfpUzjCm26KIdd5emPg0mM0=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=C0leab9phiDgZ7XNOwmbfned07yeegEQP+79/dRT/qDTs3134Hqrd8EHhPcG+eui6fsVFqkn4GjWrxzKJDzI/XQn7ypmuLhnodu8R9Cgpdx8Wr9nDjsfOziO4r/s2938L1Tx2hSQZbFTGTg0eYr19srpUQUwAE78nBfeS9KrxVQ= X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: vYnWjtAVM1nHNxgSSm1T8MSA4yA_SJHU.A.V1PLP9H.mzpq l0n_OEHlnLlBvZOpO3xqUAsVYxZKAjGahWPkaiYC5ZfM8rrldkVWcab3AebR 5rh_e9CFKoHzSEJOxsz.XK7Brw1N8nCm63TqpOgMCX9lMxhIPTgWKYc.am1t enXzQNBj677Kr78Zhyudh4YsYyuhkjzLFHQ6Av8CSVEq5MTAAeqe1caspRW0 8IYaI2cJf_mSsezkM4Kdeif8fPTvAJr30l8Tij4epG4E_JQpnljljkZWjtmT qGMKRwaTY8O9MFfoYBvqPJs1B2tn3ARDvNQzHiGSA8icmDdvW_K_t7j9Nowe 3ipicbQVXYcd9ApM6VN5jRiJYpoTNDXhn0YhMrrP37IehFYLOR.PrSMcjH7o gZzk- X-Yahoo-SMTP: dMK34oyswBBlfKesWTI5ovDjFOUFE6shtILt.ZXnUEjQHhWq Received: from wellhouse.underworld (rankincj@86.183.125.64 with login) by smtp824.mail.ird.yahoo.com with SMTP; 18 Aug 2011 15:11:12 -0700 PDT Received: from volcano.underworld (volcano.underworld [192.168.0.3]) by wellhouse.underworld (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id p7IMB9Pt007731 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 18 Aug 2011 23:11:11 +0100 Message-ID: <4E4D8DFD.5060800@yahoo.com> Date: Thu, 18 Aug 2011 23:11:09 +0100 From: Chris Rankin User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: Devin Heitmueller CC: linux-media@vger.kernel.org, mchehab@redhat.com, Antti Palosaari Subject: Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e References: <4E4D5157.2080406@yahoo.com> In-Reply-To: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Two more patches: a) clean up resources more reliably if em28xx_init_dev() fails, b) move two printk() statements outside the mutex lock Cheers, Chris Signed-off-by: Chris Rankin --- linux-3.0/drivers/media/video/em28xx/em28xx-core.c.orig 2011-08-18 23:05:50.000000000 +0100 +++ linux-3.0/drivers/media/video/em28xx/em28xx-core.c 2011-08-18 23:07:02.000000000 +0100 @@ -1186,8 +1186,8 @@ list_for_each_entry(dev, &em28xx_devlist, devlist) { ops->init(dev); } - printk(KERN_INFO "Em28xx: Initialized (%s) extension\n", ops->name); mutex_unlock(&em28xx_devlist_mutex); + printk(KERN_INFO "Em28xx: Initialized (%s) extension\n", ops->name); return 0; } EXPORT_SYMBOL(em28xx_register_extension); @@ -1200,9 +1200,9 @@ list_for_each_entry(dev, &em28xx_devlist, devlist) { ops->fini(dev); } - printk(KERN_INFO "Em28xx: Removed (%s) extension\n", ops->name); list_del(&ops->next); mutex_unlock(&em28xx_devlist_mutex); + printk(KERN_INFO "Em28xx: Removed (%s) extension\n", ops->name); } EXPORT_SYMBOL(em28xx_unregister_extension);