From patchwork Thu Aug 18 21:34:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rankin X-Patchwork-Id: 261 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Thu, 18 Aug 2011 21:35:16 +0000 Received: from casper.infradead.org [85.118.1.10] by gaivota with IMAP (fetchmail-6.3.20) for (single-drop); Thu, 18 Aug 2011 17:57:01 -0700 (PDT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QuAF9-0008Qp-Kr; Thu, 18 Aug 2011 21:35:16 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754112Ab1HRVfG (ORCPT + 1 other); Thu, 18 Aug 2011 17:35:06 -0400 Received: from nm4-vm0.bt.bullet.mail.ird.yahoo.com ([212.82.108.93]:32500 "HELO nm4-vm0.bt.bullet.mail.ird.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753245Ab1HRVfF (ORCPT ); Thu, 18 Aug 2011 17:35:05 -0400 Received: from [212.82.108.230] by nm4.bt.bullet.mail.ird.yahoo.com with NNFMP; 18 Aug 2011 21:35:03 -0000 Received: from [212.82.108.224] by tm3.bt.bullet.mail.ird.yahoo.com with NNFMP; 18 Aug 2011 21:35:03 -0000 Received: from [127.0.0.1] by omp1001.bt.mail.ird.yahoo.com with NNFMP; 18 Aug 2011 21:35:03 -0000 X-Yahoo-Newman-Id: 227591.96355.bm@omp1001.bt.mail.ird.yahoo.com Received: (qmail 93218 invoked from network); 18 Aug 2011 21:35:03 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=DKIM-Signature:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=AHYQmnBlVqOD+dLJX9/2wlFDyY8TH+VhSISd2hr/Qva3DX3jSwlqeA8gORM5mlC+gZ2HcrZsgeGCAnLl16r+v8kYxXKKC+rBGmyTmS86oW4HNqPxPSYKHgsr1ituiSbPaG9anSE0EXrAzSdEvn800noEjGvYpOf6k38zuZRcQFU= ; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1313703303; bh=b6c5FAJL+/47lgdcpz1Ewu/rL4i5YBKR5HLzzclQ+jM=; h=X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type; b=K/h0IV2yy2NdGJ+ZsD+tRHfi3Ewy1JsV9aJfL1deXt4iPDb+lcOsTvu01jZB0UlOn5J2Zpzo6jFEAJCWCX+y5n9j0n3s2Pkbs03G9lkhYZShlDnDUMVuofW/9ek9wnm+LzQHBJQCYf72qvIBUxbdRKvortQWXozYxF72euqOwUo= X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 2a6nzxIVM1mziKUyu4JCPBr0DndDcWF7S0jpgxAGsP9yGUX RHYaM894si8d874gtaj7dWcAKNOMvwFd1iBHbRe8Kqq26JFc6la8NpUTtI42 rPHAcQy5Rc7lrId1YAXWz76Upj_Uzj8TzNazuo5o9ZB9g570BvFtfSEBR7NK ZNH7aNiKKbGnM4ejxbTrdSshLdge8qM7FHU9CY.4qib_0RPftyqs8mrQbhCt QsP3bTrk3Si0nXOKmQ3wu2K07VyN3Y69X3IV72RkUbHNIQd7soy0mZRHTqtl A.EkwKFWPDeAQ_WjUaA7q7c5jyV9B4tqO.53DIHGNl6sPnc8IlWoHO7SgKyv 6gnL1yNrN3pNrk6vmre5SriOYcDwEQMNtmj4Oqadwbc0WQEOCBPgLz8Wb5q2 uKjU- X-Yahoo-SMTP: dMK34oyswBBlfKesWTI5ovDjFOUFE6shtILt.ZXnUEjQHhWq Received: from wellhouse.underworld (rankincj@86.183.125.64 with login) by smtp823.mail.ukl.yahoo.com with SMTP; 18 Aug 2011 21:35:02 +0000 GMT Received: from volcano.underworld (volcano.underworld [192.168.0.3]) by wellhouse.underworld (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id p7ILYxbV007668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 18 Aug 2011 22:35:01 +0100 Message-ID: <4E4D8583.4070606@yahoo.com> Date: Thu, 18 Aug 2011 22:34:59 +0100 From: Chris Rankin User-Agent: Mozilla/5.0 (X11; Linux i686; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: Devin Heitmueller CC: linux-media@vger.kernel.org, mchehab@redhat.com, Antti Palosaari Subject: Re: [PATCH] Latest version of em28xx / em28xx-dvb patch for PCTV 290e References: <4E4D5157.2080406@yahoo.com> In-Reply-To: Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 18/08/11 19:44, Devin Heitmueller wrote: > You would be well served to break this into a patch series, as it tends to be > difficult to review a whole series of changes in a single patch. Here are the first three patches: - release the alt_max_pkt_size buffer. - use atomic bit operations for em28xx_devused. - use the correct amount of memory for snprintf(). Cheers, Chris Signed-of-by: Chris Rankin --- linux-3.0/drivers/media/video/em28xx/em28xx-video.c.orig 2011-08-18 17:20:10.000000000 +0100 +++ linux-3.0/drivers/media/video/em28xx/em28xx-video.c 2011-08-18 17:20:33.000000000 +0100 @@ -2202,6 +2202,7 @@ free the remaining resources */ if (dev->state & DEV_DISCONNECTED) { em28xx_release_resources(dev); + kfree(dev->alt_max_pkt_size); kfree(dev); return 0; } --- linux-3.0/drivers/media/video/em28xx/em28xx-cards.c.orig 2011-08-17 08:52:19.000000000 +0100 +++ linux-3.0/drivers/media/video/em28xx/em28xx-cards.c 2011-08-18 22:09:32.000000000 +0100 @@ -3128,6 +3128,7 @@ retval = em28xx_init_dev(&dev, udev, interface, nr); if (retval) { em28xx_devused &= ~(1<devno); + kfree(dev->alt_max_pkt_size); mutex_unlock(&dev->lock); kfree(dev); goto err;