From patchwork Tue Sep 28 19:58:04 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Hoogenraad X-Patchwork-Id: 4459 Return-path: Envelope-to: mchehab@pedra Delivery-date: Tue, 28 Sep 2010 16:58:39 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1P0gJz-0002HC-0J for mchehab@pedra; Tue, 28 Sep 2010 16:58:39 -0300 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Tue, 28 Sep 2010 16:58:39 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P0gJa-0004PM-TV; Tue, 28 Sep 2010 19:58:15 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753955Ab0I1T6N (ORCPT + 1 other); Tue, 28 Sep 2010 15:58:13 -0400 Received: from psmtp13.wxs.nl ([195.121.247.25]:42381 "EHLO psmtp13.wxs.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923Ab0I1T6N (ORCPT ); Tue, 28 Sep 2010 15:58:13 -0400 Received: from localhost (ip545779c6.direct-adsl.nl [84.87.121.198]) by psmtp13.wxs.nl (iPlanet Messaging Server 5.2 HotFix 2.15 (built Nov 14 2006)) with ESMTP id <0L9H00MMJ3GV4X@psmtp13.wxs.nl> for linux-media@vger.kernel.org; Tue, 28 Sep 2010 21:58:08 +0200 (MEST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (8.14.3/8.14.3/Debian-6) with ESMTP id o8SJw49p015884; Tue, 28 Sep 2010 21:58:06 +0200 Date: Tue, 28 Sep 2010 21:58:04 +0200 From: Jan Hoogenraad Subject: Re: updated make_kconfig.pl for Ubuntu In-reply-to: <4CA2321C.1020909@infradead.org> To: Douglas Schilling Landgraf Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org Message-id: <4CA248CC.4040404@hoogenraad.net> Organization: Hoogenraad Interface Services MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_BB0Km7EFjLrnl5cuNGil+w)" User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.13) Gecko/20100917 SeaMonkey/2.0.8 References: <1284493110.1801.57.camel@sofia> <4C924EB8.9070500@hoogenraad.net> <4C93364C.3040606@hoogenraad.net> <4C934806.7050503@gmail.com> <4C934C10.2060801@hoogenraad.net> <4C93800B.8070902@gmail.com> <4C9F7267.7000707@hoogenraad.net> <4CA018C4.9000507@gmail.com> <4CA0E554.40406@hoogenraad.net> <4CA0ECA9.30208@gmail.com> <4CA10262.6060206@hoogenraad.net> <4CA11E25.5030206@gmail.com> <4CA22A79.9020309@hoogenraad.net> <4CA2321C.1020909@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Douglas: Can you push the updated make_kconfig.pl ? It is in its own HG tree on: http://linuxtv.org/hg/~jhoogenraad/ubuntu-firedtv/ Mauro Carvalho Chehab wrote: > Em 28-09-2010 14:48, Jan Hoogenraad escreveu: >> Douglas: >> >> I have an updated make_kconfig.pl for Ububtu on: >> http://linuxtv.org/hg/~jhoogenraad/rtl2831-r2/file/cb34ee1c29fc/v4l/scripts/make_kconfig.pl >> >> Could you test if make allyesconfig actually keeps FIREDTV enabled on a non-Ubuntu system ? >> >> If so, can you merge this version into the main stream ? >> > > Ok, now it looks correct on my eyes, and it should not hurt compilation > with make release and with distros that do a good job with their kernel > packages. > > I'll let Douglas review and test, as he is the maintainer. > > It would be better if you could send him a diff. you may use hg diff to generate > it against an older version, in order to merge all your make_kconfig.pl patches, > or just create a new clone from master and apply it there. > > A side question: when do you intend to send us the patches for the Realtek > rtl2831? > > Cheers, > Mauro. > # HG changeset patch # User Jan Hoogenraad # Date 1285703652 -7200 # Node ID c8e14191e48d98a19405c9f899abca30cd89bc18 # Parent 1da5fed5c8b2c626180b1a0983fe1c960b999525 Disable FIREDTV for debian/ubuntu distributions with bad header files From: Jan Hoogenraad Disable FIREDTV for debian/ubuntu distributions with problems in header files Priority: normal Signed-off-by: Jan Hoogenraad diff -r 1da5fed5c8b2 -r c8e14191e48d v4l/scripts/make_kconfig.pl --- a/v4l/scripts/make_kconfig.pl Sun Sep 19 02:23:09 2010 -0300 +++ b/v4l/scripts/make_kconfig.pl Tue Sep 28 21:54:12 2010 +0200 @@ -597,6 +597,9 @@ disable_config('STAGING_BROKEN'); $intopt { "DVB_MAX_ADAPTERS" } = 8; +#check broken Ubuntu headers +dmahcheck(); + # Check dependencies my %newconfig = checkdeps(); @@ -681,3 +684,24 @@ EOF3 sleep 5; } + +# Check for full kernel sources and print a warning +sub dmahcheck() +{ + my $dmahplace="$kernsrc/include/config/ieee1394/dma.h"; + if (! -e $dmahplace) { + print <<"EOF2"; + +***WARNING:*** File $dmahplace not present. +This problem is at least present on Ubuntu systems: +https://bugs.launchpad.net/ubuntu/+source/linux-kernel-headers/+bug/134222 + +Therefore disabling FIREDTV driver. + +EOF2 + + disable_config('DVB_FIREDTV'); + + } + sleep 5; +}