From patchwork Wed Feb 24 06:52:59 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOpbWV0aCBNw6FydG9u?= X-Patchwork-Id: 2817 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Wed, 24 Feb 2010 06:53:06 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Wed, 24 Feb 2010 09:24:24 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NkB7J-0001DH-SG; Wed, 24 Feb 2010 06:53:06 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753663Ab0BXGxE (ORCPT + 1 other); Wed, 24 Feb 2010 01:53:04 -0500 Received: from relay01.digicable.hu ([92.249.128.189]:56651 "EHLO relay01.digicable.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753457Ab0BXGxB (ORCPT ); Wed, 24 Feb 2010 01:53:01 -0500 Received: from [94.21.49.210] by relay01.digicable.hu with esmtpa id 1NkB7E-0008Gw-Ly ; Wed, 24 Feb 2010 07:53:00 +0100 Message-ID: <4B84CCCB.1050908@freemail.hu> Date: Wed, 24 Feb 2010 07:52:59 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Jean-Francois Moine CC: V4L Mailing List Subject: [PATCH 2/2] gspca pac7302: remove LED blinking when switching stream on and off X-Original: 94.21.49.210 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Márton Németh The init sequences for PAC7302 contained register settings affecting the LED state which can result blinking of the LED when it is set to always on or always off. The blinking happened when the stream was switched on or off. Remove the register changes from the init sequence and handle it with the function set_streaming_led(). Signed-off-by: Márton Németh --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/linux/drivers/media/video/gspca/pac7302.c 2010-02-08 20:46:47.000000000 +0100 +++ b/linux/drivers/media/video/gspca/pac7302.c 2010-02-08 20:48:04.000000000 +0100 @@ -331,13 +331,6 @@ static const struct v4l2_pix_format vga_ #define END_OF_SEQUENCE 0 /* pac 7302 */ -static const __u8 init_7302[] = { -/* index,value */ - 0xff, 0x01, /* page 1 */ - 0x78, 0x00, /* deactivate */ - 0xff, 0x01, - 0x78, 0x40, /* led off */ -}; static const __u8 start_7302[] = { /* index, len, [value]* */ 0xff, 1, 0x00, /* page 0 */ @@ -373,7 +366,8 @@ static const __u8 start_7302[] = { 0xff, 1, 0x01, /* page 1 */ 0x12, 3, 0x02, 0x00, 0x01, 0x3e, 2, 0x00, 0x00, - 0x76, 5, 0x01, 0x20, 0x40, 0x00, 0xf2, + 0x76, 2, 0x01, 0x20, + 0x79, 2, 0x00, 0xf2, 0x7c, 1, 0x00, 0x7f, 10, 0x4b, 0x0f, 0x01, 0x2c, 0x02, 0x58, 0x03, 0x20, 0x02, 0x00, @@ -397,8 +391,6 @@ static const __u8 start_7302[] = { 0x2a, 5, 0xc8, 0x00, 0x18, 0x12, 0x22, 0x64, 8, 0x00, 0x00, 0xf0, 0x01, 0x14, 0x44, 0x44, 0x44, 0x6e, 1, 0x08, - 0xff, 1, 0x01, /* page 1 */ - 0x78, 1, 0x00, 0, END_OF_SEQUENCE /* end of sequence */ }; @@ -496,15 +488,6 @@ static void reg_w(struct gspca_dev *gspc } } -static void reg_w_seq(struct gspca_dev *gspca_dev, - const __u8 *seq, int len) -{ - while (--len >= 0) { - reg_w(gspca_dev, seq[0], seq[1]); - seq += 2; - } -} - /* load the beginning of a page */ static void reg_w_page(struct gspca_dev *gspca_dev, const __u8 *page, int len) @@ -774,7 +757,7 @@ static void set_streaming_led(struct gsp /* this function is called at probe and resume time for pac7302 */ static int sd_init(struct gspca_dev *gspca_dev) { - reg_w_seq(gspca_dev, init_7302, sizeof(init_7302)/2); + set_streaming_led(gspca_dev, 0); return gspca_dev->usb_err; }