From patchwork Fri Jan 29 20:30:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOpbWV0aCBNw6FydG9u?= X-Patchwork-Id: 2528 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Fri, 29 Jan 2010 20:31:09 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Fri, 29 Jan 2010 18:33:21 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NaxUj-0000i0-Fb; Fri, 29 Jan 2010 20:31:09 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754884Ab0A2UbG (ORCPT + 1 other); Fri, 29 Jan 2010 15:31:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754895Ab0A2UbF (ORCPT ); Fri, 29 Jan 2010 15:31:05 -0500 Received: from mail02d.mail.t-online.hu ([84.2.42.7]:51317 "EHLO mail02d.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754884Ab0A2UbE (ORCPT ); Fri, 29 Jan 2010 15:31:04 -0500 Received: from [192.168.1.67] (dsl5402C4B8.pool.t-online.hu [84.2.196.184]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail02d.mail.t-online.hu (Postfix) with ESMTPSA id D9AA27588B3; Fri, 29 Jan 2010 21:28:54 +0100 (CET) Message-ID: <4B63457D.5010702@freemail.hu> Date: Fri, 29 Jan 2010 21:30:53 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Janne Grunau CC: V4L Mailing List Subject: [PATCH] hdpvr-core: make module parameters local X-DCC-mail.t-online.hu-Metrics: mail02d.mail.t-online.hu 32721; Body=2 Fuz1=2 Fuz2=2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Márton Németh The default_video_input and default_audio_input module parameters are only used inside the hdpvr-core.c file so make them static. This will remove the following sparse warnings (see "make C=1"): * warning: symbol 'default_video_input' was not declared. Should it be static? * warning: symbol 'default_audio_input' was not declared. Should it be static? Signed-off-by: Márton Németh --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -r 8b9a62386b64 linux/drivers/media/video/hdpvr/hdpvr-core.c --- a/linux/drivers/media/video/hdpvr/hdpvr-core.c Fri Jan 29 01:23:57 2010 -0200 +++ b/linux/drivers/media/video/hdpvr/hdpvr-core.c Fri Jan 29 21:25:45 2010 +0100 @@ -39,12 +39,12 @@ module_param(hdpvr_debug, int, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(hdpvr_debug, "enable debugging output"); -uint default_video_input = HDPVR_VIDEO_INPUTS; +static uint default_video_input = HDPVR_VIDEO_INPUTS; module_param(default_video_input, uint, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(default_video_input, "default video input: 0=Component / " "1=S-Video / 2=Composite"); -uint default_audio_input = HDPVR_AUDIO_INPUTS; +static uint default_audio_input = HDPVR_AUDIO_INPUTS; module_param(default_audio_input, uint, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(default_audio_input, "default audio input: 0=RCA back / " "1=RCA front / 2=S/PDIF");