From patchwork Sat Jan 16 16:21:59 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOpbWV0aCBNw6FydG9u?= X-Patchwork-Id: 2467 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sat, 16 Jan 2010 16:22:09 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Sat, 16 Jan 2010 19:43:22 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NWBPd-0002j5-Eb; Sat, 16 Jan 2010 16:22:09 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752832Ab0APQWF (ORCPT + 1 other); Sat, 16 Jan 2010 11:22:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751655Ab0APQWF (ORCPT ); Sat, 16 Jan 2010 11:22:05 -0500 Received: from mail01a.mail.t-online.hu ([84.2.40.6]:62797 "EHLO mail01a.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118Ab0APQWE (ORCPT ); Sat, 16 Jan 2010 11:22:04 -0500 Received: from [192.168.1.64] (dsl5402C406.pool.t-online.hu [84.2.196.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail01a.mail.t-online.hu (Postfix) with ESMTPSA id D5627797A55; Sat, 16 Jan 2010 17:19:13 +0100 (CET) Message-ID: <4B51E7A7.8000507@freemail.hu> Date: Sat, 16 Jan 2010 17:21:59 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Srinivasa Deevi CC: V4L Mailing List Subject: [PATCH] cx231xx: cleanup dvb_attach() return value handling X-DCC-mail.t-online.hu-Metrics: mail01a.mail.t-online.hu 32721; Body=2 Fuz1=2 Fuz2=2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Márton Németh Remove the following sparse error (see "make C=1"): * error: incompatible types for operation (<) left side has type struct dvb_frontend * right side has type int Signed-off-by: Márton Németh --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -r 5bcdcc072b6d linux/drivers/media/video/cx231xx/cx231xx-dvb.c --- a/linux/drivers/media/video/cx231xx/cx231xx-dvb.c Sat Jan 16 07:25:43 2010 +0100 +++ b/linux/drivers/media/video/cx231xx/cx231xx-dvb.c Sat Jan 16 17:21:06 2010 +0100 @@ -465,9 +465,9 @@ /* define general-purpose callback pointer */ dvb->frontend->callback = cx231xx_tuner_callback; - if (dvb_attach(xc5000_attach, dev->dvb->frontend, + if (!dvb_attach(xc5000_attach, dev->dvb->frontend, &dev->i2c_bus[1].i2c_adap, - &cnxt_rde250_tunerconfig) < 0) { + &cnxt_rde250_tunerconfig)) { result = -EINVAL; goto out_free; } @@ -487,9 +487,9 @@ /* define general-purpose callback pointer */ dvb->frontend->callback = cx231xx_tuner_callback; - if (dvb_attach(xc5000_attach, dev->dvb->frontend, + if (!dvb_attach(xc5000_attach, dev->dvb->frontend, &dev->i2c_bus[1].i2c_adap, - &cnxt_rde250_tunerconfig) < 0) { + &cnxt_rde250_tunerconfig)) { result = -EINVAL; goto out_free; }