From patchwork Thu Jan 14 19:08:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Trimarchi X-Patchwork-Id: 2459 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Thu, 14 Jan 2010 19:08:26 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Fri, 15 Jan 2010 09:59:19 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NVV3R-00011o-PB; Thu, 14 Jan 2010 19:08:25 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756943Ab0ANTIX (ORCPT + 1 other); Thu, 14 Jan 2010 14:08:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756213Ab0ANTIX (ORCPT ); Thu, 14 Jan 2010 14:08:23 -0500 Received: from ms01.sssup.it ([193.205.80.99]:59018 "EHLO sssup.it" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755469Ab0ANTIX (ORCPT ); Thu, 14 Jan 2010 14:08:23 -0500 Received: from [193.205.82.7] (HELO gandalf.sssup.it) by sssup.it (CommuniGate Pro SMTP 4.1.8) with ESMTP-TLS id 56912521; Thu, 14 Jan 2010 20:06:11 +0100 Received: from [10.30.3.179] (vpn179.retis [10.30.3.179]) by gandalf.sssup.it (8.12.10/8.12.10) with ESMTP id o0EJ8JeI019297 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 14 Jan 2010 20:08:20 +0100 Message-ID: <4B4F6BA2.50402@panicking.kicks-ass.org> Date: Thu, 14 Jan 2010 20:08:18 +0100 From: Michael Trimarchi User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: "Aguirre, Sergio" CC: "linux-media@vger.kernel.org" , akari Ailus Subject: [RFC PATCH] fix try_pix_parm loop References: <4B4F0762.4040007@panicking.kicks-ass.org> <4B4F537B.7000708@panicking.kicks-ass.org> <4B4F56C8.7060108@panicking.kicks-ass.org> In-Reply-To: <4B4F56C8.7060108@panicking.kicks-ass.org> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org This patch fix try_pix_parm loop that try to find a suitable format for the isp engine Signed-off-by: Michael Trimarchi Cc: akari Ailus Cc: Sergio Aguirre --- diff --git a/drivers/media/video/omap34xxcam.c b/drivers/media/video/omap34xxcam.c index 53b587e..bf7db71 100644 --- a/drivers/media/video/omap34xxcam.c +++ b/drivers/media/video/omap34xxcam.c @@ -470,7 +470,7 @@ static int try_pix_parm(struct omap34xxcam_videodev *vdev, pix_tmp_out = *wanted_pix_out; rval = isp_try_fmt_cap(isp, &pix_tmp_in, &pix_tmp_out); if (rval) - return rval; + continue; dev_dbg(&vdev->vfd->dev, "this w %d\th %d\tfmt %8.8x\t" "-> w %d\th %d\t fmt %8.8x"