From patchwork Wed Dec 30 21:29:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOpbWV0aCBNw6FydG9u?= X-Patchwork-Id: 2389 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Wed, 30 Dec 2009 21:29:49 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Fri, 01 Jan 2010 00:47:34 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NQ673-00025n-3c; Wed, 30 Dec 2009 21:29:49 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753794AbZL3V31 (ORCPT + 1 other); Wed, 30 Dec 2009 16:29:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753790AbZL3V3N (ORCPT ); Wed, 30 Dec 2009 16:29:13 -0500 Received: from mail02d.mail.t-online.hu ([84.2.42.7]:52954 "EHLO mail02d.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753575AbZL3V3I (ORCPT ); Wed, 30 Dec 2009 16:29:08 -0500 Received: from [192.168.1.64] (dsl51B6C4AD.pool.t-online.hu [81.182.196.173]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail02d.mail.t-online.hu (Postfix) with ESMTPSA id 5A1DE758425; Wed, 30 Dec 2009 22:27:39 +0100 (CET) Message-ID: <4B3BC61E.8080706@freemail.hu> Date: Wed, 30 Dec 2009 22:29:02 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Jean-Francois Moine , V4L Mailing List , cocci@diku.dk Subject: [PATCH] gspca: make sd_desc const X-DCC-mail.t-online.hu-Metrics: mail02d.mail.t-online.hu 32721; Body=3 Fuz1=3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Márton Németh The function callbacks in sd_desc are defined at compile time and they do not change at runtime. Make the sd_desc initializations const. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @c@ identifier x; @@ static const struct sd_desc x = ...; @depends on !c@ identifier x; @@ static + const struct sd_desc x = ...; // Signed-off-by: Márton Németh Cc: cocci@diku.dk --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -r 62ee2b0f6556 linux/drivers/media/video/gspca/conex.c --- a/linux/drivers/media/video/gspca/conex.c Wed Dec 30 18:19:11 2009 +0100 +++ b/linux/drivers/media/video/gspca/conex.c Wed Dec 30 22:27:04 2009 +0100 @@ -1032,7 +1032,7 @@ } /* sub-driver description */ -static struct sd_desc sd_desc = { +static const struct sd_desc sd_desc = { .name = MODULE_NAME, .ctrls = sd_ctrls, .nctrls = ARRAY_SIZE(sd_ctrls), diff -r 62ee2b0f6556 linux/drivers/media/video/gspca/etoms.c --- a/linux/drivers/media/video/gspca/etoms.c Wed Dec 30 18:19:11 2009 +0100 +++ b/linux/drivers/media/video/gspca/etoms.c Wed Dec 30 22:27:04 2009 +0100 @@ -857,7 +857,7 @@ } /* sub-driver description */ -static struct sd_desc sd_desc = { +static const struct sd_desc sd_desc = { .name = MODULE_NAME, .ctrls = sd_ctrls, .nctrls = ARRAY_SIZE(sd_ctrls), diff -r 62ee2b0f6556 linux/drivers/media/video/gspca/gl860/gl860.c --- a/linux/drivers/media/video/gspca/gl860/gl860.c Wed Dec 30 18:19:11 2009 +0100 +++ b/linux/drivers/media/video/gspca/gl860/gl860.c Wed Dec 30 22:27:04 2009 +0100 @@ -161,7 +161,7 @@ /*==================== sud-driver structure initialisation =================*/ -static struct sd_desc sd_desc_mi1320 = { +static const struct sd_desc sd_desc_mi1320 = { .name = MODULE_NAME, .ctrls = sd_ctrls_mi1320, .nctrls = GL860_NCTRLS, @@ -174,7 +174,7 @@ .dq_callback = sd_callback, }; -static struct sd_desc sd_desc_mi2020 = { +static const struct sd_desc sd_desc_mi2020 = { .name = MODULE_NAME, .ctrls = sd_ctrls_mi2020, .nctrls = GL860_NCTRLS, @@ -187,7 +187,7 @@ .dq_callback = sd_callback, }; -static struct sd_desc sd_desc_mi2020b = { +static const struct sd_desc sd_desc_mi2020b = { .name = MODULE_NAME, .ctrls = sd_ctrls_mi2020b, .nctrls = GL860_NCTRLS, @@ -200,7 +200,7 @@ .dq_callback = sd_callback, }; -static struct sd_desc sd_desc_ov2640 = { +static const struct sd_desc sd_desc_ov2640 = { .name = MODULE_NAME, .ctrls = sd_ctrls_ov2640, .nctrls = GL860_NCTRLS, @@ -213,7 +213,7 @@ .dq_callback = sd_callback, }; -static struct sd_desc sd_desc_ov9655 = { +static const struct sd_desc sd_desc_ov9655 = { .name = MODULE_NAME, .ctrls = sd_ctrls_ov9655, .nctrls = GL860_NCTRLS, diff -r 62ee2b0f6556 linux/drivers/media/video/gspca/pac7302.c --- a/linux/drivers/media/video/gspca/pac7302.c Wed Dec 30 18:19:11 2009 +0100 +++ b/linux/drivers/media/video/gspca/pac7302.c Wed Dec 30 22:27:04 2009 +0100 @@ -1232,7 +1232,7 @@ #endif /* sub-driver description for pac7302 */ -static struct sd_desc sd_desc = { +static const struct sd_desc sd_desc = { .name = MODULE_NAME, .ctrls = sd_ctrls, .nctrls = ARRAY_SIZE(sd_ctrls), diff -r 62ee2b0f6556 linux/drivers/media/video/gspca/pac7311.c --- a/linux/drivers/media/video/gspca/pac7311.c Wed Dec 30 18:19:11 2009 +0100 +++ b/linux/drivers/media/video/gspca/pac7311.c Wed Dec 30 22:27:04 2009 +0100 @@ -870,7 +870,7 @@ } /* sub-driver description for pac7311 */ -static struct sd_desc sd_desc = { +static const struct sd_desc sd_desc = { .name = MODULE_NAME, .ctrls = sd_ctrls, .nctrls = ARRAY_SIZE(sd_ctrls), diff -r 62ee2b0f6556 linux/drivers/media/video/gspca/spca500.c --- a/linux/drivers/media/video/gspca/spca500.c Wed Dec 30 18:19:11 2009 +0100 +++ b/linux/drivers/media/video/gspca/spca500.c Wed Dec 30 22:27:04 2009 +0100 @@ -1064,7 +1064,7 @@ } /* sub-driver description */ -static struct sd_desc sd_desc = { +static const struct sd_desc sd_desc = { .name = MODULE_NAME, .ctrls = sd_ctrls, .nctrls = ARRAY_SIZE(sd_ctrls), diff -r 62ee2b0f6556 linux/drivers/media/video/gspca/spca506.c --- a/linux/drivers/media/video/gspca/spca506.c Wed Dec 30 18:19:11 2009 +0100 +++ b/linux/drivers/media/video/gspca/spca506.c Wed Dec 30 22:27:04 2009 +0100 @@ -673,7 +673,7 @@ } /* sub-driver description */ -static struct sd_desc sd_desc = { +static const struct sd_desc sd_desc = { .name = MODULE_NAME, .ctrls = sd_ctrls, .nctrls = ARRAY_SIZE(sd_ctrls),