From patchwork Sat Oct 31 23:13:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOpbWV0aCBNw6FydG9u?= X-Patchwork-Id: 1914 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sat, 31 Oct 2009 23:13:31 +0000 Received: from bombadil.infradead.org [18.85.46.34] by caramujo.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Sat, 31 Oct 2009 21:14:39 -0200 (BRST) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N4N8U-0002BA-Vb; Sat, 31 Oct 2009 23:13:31 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933330AbZJaXNY (ORCPT + 1 other); Sat, 31 Oct 2009 19:13:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933328AbZJaXNY (ORCPT ); Sat, 31 Oct 2009 19:13:24 -0400 Received: from mail01d.mail.t-online.hu ([84.2.42.6]:60547 "EHLO mail01d.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933316AbZJaXNY (ORCPT ); Sat, 31 Oct 2009 19:13:24 -0400 Received: from [192.168.1.64] (dsl5402C4D0.pool.t-online.hu [84.2.196.208]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail01d.mail.t-online.hu (Postfix) with ESMTPSA id DD57B758424; Sun, 1 Nov 2009 00:13:17 +0100 (CET) Message-ID: <4AECC494.7050402@freemail.hu> Date: Sun, 01 Nov 2009 00:13:24 +0100 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Jean-Francois Moine , Hans de Goede , V4L Mailing List CC: Thomas Kaiser , Theodore Kilgore , Kyle Guinn Subject: [PATCH 01/21] gspca pac7302/pac7311: add prefix for sensor specific functions X-DCC-mail.t-online.hu-Metrics: mail01d.mail.t-online.hu 32711; Body=6 Fuz1=6 Fuz2=6 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Márton Németh There are some functions which are already sensor specific. Mark them with pac7302_ or pac7311_ prefix Signed-off-by: Márton Németh Cc: Thomas Kaiser Cc: Theodore Kilgore Cc: Kyle Guinn --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -uprN a/drivers/media/video/gspca/pac7311.c b/drivers/media/video/gspca/pac7311.c --- a/drivers/media/video/gspca/pac7311.c 2009-10-30 16:12:05.000000000 +0100 +++ b/drivers/media/video/gspca/pac7311.c 2009-10-30 17:09:52.000000000 +0100 @@ -543,7 +543,7 @@ static int sd_config(struct gspca_dev *g } /* This function is used by pac7302 only */ -static void setbrightcont(struct gspca_dev *gspca_dev) +static void pac7302_setbrightcont(struct gspca_dev *gspca_dev) { struct sd *sd = (struct sd *) gspca_dev; int i, v; @@ -570,7 +570,7 @@ static void setbrightcont(struct gspca_d } /* This function is used by pac7311 only */ -static void setcontrast(struct gspca_dev *gspca_dev) +static void pac7311_setcontrast(struct gspca_dev *gspca_dev) { struct sd *sd = (struct sd *) gspca_dev; @@ -581,7 +581,7 @@ static void setcontrast(struct gspca_dev } /* This function is used by pac7302 only */ -static void setcolors(struct gspca_dev *gspca_dev) +static void pac7302_setcolors(struct gspca_dev *gspca_dev) { struct sd *sd = (struct sd *) gspca_dev; int i, v; @@ -700,11 +700,11 @@ static int sd_start(struct gspca_dev *gs if (sd->sensor == SENSOR_PAC7302) { reg_w_var(gspca_dev, start_7302); - setbrightcont(gspca_dev); - setcolors(gspca_dev); + pac7302_setbrightcont(gspca_dev); + pac7302_setcolors(gspca_dev); } else { reg_w_var(gspca_dev, start_7311); - setcontrast(gspca_dev); + pac7311_setcontrast(gspca_dev); } setgain(gspca_dev); setexposure(gspca_dev); @@ -923,7 +923,7 @@ static int sd_setbrightness(struct gspca sd->brightness = val; if (gspca_dev->streaming) - setbrightcont(gspca_dev); + pac7302_setbrightcont(gspca_dev); return 0; } @@ -942,9 +942,9 @@ static int sd_setcontrast(struct gspca_d sd->contrast = val; if (gspca_dev->streaming) { if (sd->sensor == SENSOR_PAC7302) - setbrightcont(gspca_dev); + pac7302_setbrightcont(gspca_dev); else - setcontrast(gspca_dev); + pac7311_setcontrast(gspca_dev); } return 0; } @@ -963,7 +963,7 @@ static int sd_setcolors(struct gspca_dev sd->colors = val; if (gspca_dev->streaming) - setcolors(gspca_dev); + pac7302_setcolors(gspca_dev); return 0; }