From patchwork Sat Oct 3 07:35:54 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOpbWV0aCBNw6FydG9u?= X-Patchwork-Id: 1797 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sat, 03 Oct 2009 07:36:20 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Sat, 03 Oct 2009 18:17:14 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MtzAC-0008UL-MD; Sat, 03 Oct 2009 07:36:20 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754047AbZJCHf4 (ORCPT + 1 other); Sat, 3 Oct 2009 03:35:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754024AbZJCHf4 (ORCPT ); Sat, 3 Oct 2009 03:35:56 -0400 Received: from mail01a.mail.t-online.hu ([84.2.40.6]:57982 "EHLO mail01a.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754005AbZJCHfy (ORCPT ); Sat, 3 Oct 2009 03:35:54 -0400 Received: from [192.168.1.64] (dsl54029FEE.pool.t-online.hu [84.2.159.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail01a.mail.t-online.hu (Postfix) with ESMTPSA id 054EB79855A; Sat, 3 Oct 2009 09:31:07 +0200 (CEST) Message-ID: <4AC6FEDA.30804@freemail.hu> Date: Sat, 03 Oct 2009 09:35:54 +0200 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Jean-Francois Moine , Thomas Kaiser CC: V4L Mailing List , LKML Subject: [PATCH 3/3] pac7311: remove magic value for USB_BUF_SZ X-DCC-mail.t-online.hu-Metrics: mail01a.mail.t-online.hu 32711; Body=4 Fuz1=4 Fuz2=4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Márton Németh The length check in reg_w_var() function is because the buffer contents is copied to gspca_dev->usb_buf which has the size of USB_BUF_SZ bytes as defined in drivers/media/video/gspca/gspca.h. Replace the number with symbol for better readability and maintainability. The change was tested with Labtec Webcam 2200. Signed-off-by: Márton Németh --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -upr c/drivers/media/video/gspca/pac7311.c d/drivers/media/video/gspca/pac7311.c --- c/drivers/media/video/gspca/pac7311.c 2009-10-03 08:47:30.000000000 +0200 +++ d/drivers/media/video/gspca/pac7311.c 2009-10-03 09:02:31.000000000 +0200 @@ -474,7 +474,7 @@ static void reg_w_var(struct gspca_dev * reg_w_page(gspca_dev, page3_7302, sizeof page3_7302); break; default: - if (len > 64) { + if (len > USB_BUF_SZ) { PDEBUG(D_ERR|D_STREAM, "Incorrect variable sequence"); return;