From patchwork Wed Apr 29 18:57:24 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOpbWV0aCBNw6FydG9u?= X-Patchwork-Id: 803 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Wed, 29 Apr 2009 18:58:26 +0000 Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1LzEzB-0005ge-Q1; Wed, 29 Apr 2009 18:58:26 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751104AbZD2S6V (ORCPT + 1 other); Wed, 29 Apr 2009 14:58:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753536AbZD2S6U (ORCPT ); Wed, 29 Apr 2009 14:58:20 -0400 Received: from mail00d.mail.t-online.hu ([84.2.42.5]:54208 "EHLO mail00d.mail.t-online.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbZD2S6U (ORCPT ); Wed, 29 Apr 2009 14:58:20 -0400 Received: from [192.168.1.65] (dsl51B6C4E5.pool.t-online.hu [81.182.196.229]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail00d.mail.t-online.hu (Postfix) with ESMTPSA id 00C57758C1F; Wed, 29 Apr 2009 20:57:13 +0200 (CEST) Message-ID: <49F8A314.4000007@freemail.hu> Date: Wed, 29 Apr 2009 20:57:24 +0200 From: =?UTF-8?B?TsOpbWV0aCBNw6FydG9u?= User-Agent: Mozilla/5.0 (X11; U; Linux i686; hu-HU; rv:1.8.1.21) Gecko/20090402 SeaMonkey/1.1.16 MIME-Version: 1.0 To: Mauro Carvalho Chehab , linux-media@vger.kernel.org CC: LKML Subject: [PATCH] v4l2: modify return value of VIDIOC_REQBUFS ioctl X-DCC-mail.t-online.hu-Metrics: mail00d.mail.t-online.hu 32721; Body=3 Fuz1=3 Fuz2=3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The V4L2 ioctls usually return 0 when the operation was successful and -1 in case of error. Currently VIDIOC_REQBUFS returns the number of buffers which is redundant because this information is available in count field of struct v4l2_requestbuffers. The V4L2 API specification, revision 0.24 [1] explicitly specifies for VIDIOC_REQBUFS that the return value shall be 0 on success. The patch was tested with v4l-test 0.13 [2] with vivi driver. References: [1] V4L2 API specification, revision 0.24 http://v4l2spec.bytesex.org/spec/r13696.htm [2] v4l-test: Test environment for Video For Linux Two API http://v4l-test.sourceforge.net/ Signed-off-by: Márton Németh --- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-2.6.30-rc3/drivers/media/video/videobuf-core.c.orig 2009-04-22 05:07:00.000000000 +0200 +++ linux-2.6.30-rc3/drivers/media/video/videobuf-core.c 2009-04-29 18:30:15.000000000 +0200 @@ -439,6 +439,7 @@ int videobuf_reqbufs(struct videobuf_que } req->count = retval; + retval = 0; done: mutex_unlock(&q->vb_lock);