From patchwork Tue Apr 7 15:59:29 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 708 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Tue, 07 Apr 2009 15:59:42 +0000 Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1LrDi9-0003Km-VV; Tue, 07 Apr 2009 15:59:42 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757999AbZDGP7j (ORCPT + 1 other); Tue, 7 Apr 2009 11:59:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757912AbZDGP7j (ORCPT ); Tue, 7 Apr 2009 11:59:39 -0400 Received: from acsinet12.oracle.com ([141.146.126.234]:34897 "EHLO acsinet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757701AbZDGP7i (ORCPT ); Tue, 7 Apr 2009 11:59:38 -0400 Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n37FwtQC003556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Apr 2009 15:58:56 GMT Received: from acsmt707.oracle.com (acsmt707.oracle.com [141.146.40.85]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n37Fxl8W015871; Tue, 7 Apr 2009 15:59:49 GMT Received: from [141.144.90.86] (/141.144.90.86) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 07 Apr 2009 15:59:19 +0000 Message-ID: <49DB7861.5050606@oracle.com> Date: Tue, 07 Apr 2009 08:59:29 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Stephen Rothwell CC: linux-next@vger.kernel.org, LKML , linux-media@vger.kernel.org, Mauro Carvalho Chehab Subject: [PATCH -next] cx231xx: fix SND dependency build error References: <20090407140717.a7f0b07c.sfr@canb.auug.org.au> In-Reply-To: <20090407140717.a7f0b07c.sfr@canb.auug.org.au> X-Source-IP: acsmt707.oracle.com [141.146.40.85] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010205.49DB785A.0223:SCFMA4539814,ss=1,fgs=0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org From: Randy Dunlap Don't select VIDEO_CX231XX_ALSA when SND is not enabled since selecting it won't cause SND to be enabled. ERROR: "snd_pcm_period_elapsed" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_card_create" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_pcm_hw_constraint_integer" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_pcm_set_ops" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_pcm_lib_ioctl" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_card_free" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_card_register" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! ERROR: "snd_pcm_new" [drivers/media/video/cx231xx/cx231xx-alsa.ko] undefined! Signed-off-by: Randy Dunlap --- drivers/media/video/cx231xx/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-next-20090407.orig/drivers/media/video/cx231xx/Kconfig +++ linux-next-20090407/drivers/media/video/cx231xx/Kconfig @@ -6,7 +6,7 @@ config VIDEO_CX231XX select VIDEO_IR select VIDEOBUF_VMALLOC select VIDEO_CX25840 - select VIDEO_CX231XX_ALSA + select VIDEO_CX231XX_ALSA if SND ---help--- This is a video4linux driver for Conexant 231xx USB based TV cards.