diff mbox series

[1/2] media: nvidia: tegra: Use iommu_paging_domain_alloc()

Message ID 20240812072105.9578-1-baolu.lu@linux.intel.com (mailing list archive)
State New
Delegated to: Hans Verkuil
Headers
Series [1/2] media: nvidia: tegra: Use iommu_paging_domain_alloc() |

Commit Message

Lu Baolu Aug. 12, 2024, 7:21 a.m. UTC 
  An iommu domain is allocated in tegra_vde_iommu_init() and is attached to
vde->dev. Use iommu_paging_domain_alloc() to make it explicit.

Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20240610085555.88197-9-baolu.lu@linux.intel.com
---
 drivers/media/platform/nvidia/tegra-vde/iommu.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Thierry Reding Aug. 29, 2024, 3:25 p.m. UTC | #1 
On Mon, Aug 12, 2024 at 03:21:04PM GMT, Lu Baolu wrote:
> An iommu domain is allocated in tegra_vde_iommu_init() and is attached to
> vde->dev. Use iommu_paging_domain_alloc() to make it explicit.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> Link: https://lore.kernel.org/r/20240610085555.88197-9-baolu.lu@linux.intel.com
> ---
>  drivers/media/platform/nvidia/tegra-vde/iommu.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Acked-by: Thierry Reding <treding@nvidia.com>
Jason Gunthorpe Sept. 15, 2024, 2:08 p.m. UTC | #2 
On Thu, Aug 29, 2024 at 05:25:12PM +0200, Thierry Reding wrote:
> On Mon, Aug 12, 2024 at 03:21:04PM GMT, Lu Baolu wrote:
> > An iommu domain is allocated in tegra_vde_iommu_init() and is attached to
> > vde->dev. Use iommu_paging_domain_alloc() to make it explicit.
> > 
> > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> > Link: https://lore.kernel.org/r/20240610085555.88197-9-baolu.lu@linux.intel.com
> > ---
> >  drivers/media/platform/nvidia/tegra-vde/iommu.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Acked-by: Thierry Reding <treding@nvidia.com>

Can someone please pick this up for this cycle? This is one of the
last two call sites before we can delete this API. Things are waiting
on this.

Jason
diff mbox series

Patch

diff --git a/drivers/media/platform/nvidia/tegra-vde/iommu.c b/drivers/media/platform/nvidia/tegra-vde/iommu.c
index 5521ed3e465f..b1d9d841d944 100644
--- a/drivers/media/platform/nvidia/tegra-vde/iommu.c
+++ b/drivers/media/platform/nvidia/tegra-vde/iommu.c
@@ -78,9 +78,10 @@  int tegra_vde_iommu_init(struct tegra_vde *vde)
 		arm_iommu_release_mapping(mapping);
 	}
 #endif
-	vde->domain = iommu_domain_alloc(&platform_bus_type);
-	if (!vde->domain) {
-		err = -ENOMEM;
+	vde->domain = iommu_paging_domain_alloc(dev);
+	if (IS_ERR(vde->domain)) {
+		err = PTR_ERR(vde->domain);
+		vde->domain = NULL;
 		goto put_group;
 	}