From patchwork Mon Jun 3 15:25:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jacopo Mondi X-Patchwork-Id: 102170 Received: from ny.mirrors.kernel.org ([147.75.199.223]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sE9Zp-000655-34 for patchwork@linuxtv.org; Mon, 03 Jun 2024 15:26:26 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 92FF31C21E09 for ; Mon, 3 Jun 2024 15:26:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3D6FA1304AB; Mon, 3 Jun 2024 15:26:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZeZZg2+k" X-Original-To: linux-media@vger.kernel.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71AD4130AD7 for ; Mon, 3 Jun 2024 15:26:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717428376; cv=none; b=Lc17mr+w68KH/xX6Ibhu0WseH2gMwFgECpz1PDwRMgATRgjk5bNbX9WA8CIXvGBbPeLZwqXw1ue+qpP4VT75zT9H1KeYL0wOPdEaOmbg7J3EVVnBT/YvIfpRPKoij+qNGj4bzRmQ65MXs3/jUPEaDlcUWoQV4wBtbU9eOKMxKY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717428376; c=relaxed/simple; bh=9O8t5m1mlX4rkc/5G9S7+wYDmYmy28rOsQ65BjEzKWc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ODxT2uhW4f8S8u5LwN8jYSFEMRp1hD35LGC4eaI3djDFdv4B5QhpoTBQEMHvHhLnqJjYnMJ24st2MTpCG3szVzGELwJhFSl+Hgghoyz8Dcts3fB3PGCVKTjSSJOS4hd54kV3fj7FhfwlZajs7kvpV48+kDALJV+tX5NBU9/snFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ZeZZg2+k; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from localhost.localdomain (93-61-96-190.ip145.fastwebnet.it [93.61.96.190]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CD0F8C67; Mon, 3 Jun 2024 17:25:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1717428358; bh=9O8t5m1mlX4rkc/5G9S7+wYDmYmy28rOsQ65BjEzKWc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZeZZg2+kEw1AHxSoWpVh/9xRVRxOBGSk3r0kU+Jv6yZYFqaXLHdtxqA24tFsgh6Tp eD9F5DlUGke+8TvEsIbTHxUQ0pUOPDBTAFSuGKCfWiPBo2+fBAgXC5YYCZrkGGcT60 jN/IJdaSJMbTToFSTGb7+0FaWhyEio/3e6FmsUnY= From: Jacopo Mondi To: Hans Verkuil , Laurent Pinchart , Sakari Ailus Cc: Jacopo Mondi , Linux Media Mailing List Subject: [RFC 3/3] media: rkisp1-params: Override vb2_queue.buf_ops Date: Mon, 3 Jun 2024 17:25:47 +0200 Message-ID: <20240603152548.107158-4-jacopo.mondi@ideasonboard.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240603152548.107158-1-jacopo.mondi@ideasonboard.com> References: <20240603152548.107158-1-jacopo.mondi@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-LSpam-Score: -2.6 (--) X-LSpam-Report: No, score=-2.6 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_MISSING=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no Override the implementation of vb2_queue.buf_ops to allow a driver-specific behaviour in the buffer initialization operation. Signed-off-by: Jacopo Mondi --- .../platform/rockchip/rkisp1/rkisp1-params.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c index 0290f25a4ab6..4bb92d076e84 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c @@ -2455,6 +2455,21 @@ static const struct vb2_ops rkisp1_params_vb2_ops = { }; +static void rkisp1_params_vb2_buf_init_buffer(struct vb2_buffer *vb) +{ + /* TODO */ + + vb2_buf_init_buffer(vb); +} + +static const struct vb2_buf_ops rkisp1_params_vb2_buf_ops = { + .verify_planes_array = vb2_buf_verify_planes_array, + .init_buffer = rkisp1_params_vb2_buf_init_buffer, + .fill_user_buffer = vb2_buf_fill_v4l2_buffer, + .fill_vb2_buffer = vb2_buf_fill_vb2_buffer, + .copy_timestamp = vb2_buf_copy_timestamp, +}; + static const struct v4l2_file_operations rkisp1_params_fops = { .mmap = vb2_fop_mmap, .unlocked_ioctl = video_ioctl2, @@ -2474,12 +2489,13 @@ static int rkisp1_params_init_vb2_queue(struct vb2_queue *q, q->io_modes = VB2_MMAP | VB2_USERPTR | VB2_DMABUF; q->drv_priv = params; q->ops = &rkisp1_params_vb2_ops; + q->buf_ops = &rkisp1_params_vb2_buf_ops; q->mem_ops = &vb2_vmalloc_memops; q->buf_struct_size = sizeof(struct rkisp1_buffer); q->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; q->lock = &node->vlock; - return vb2_queue_init(q); + return vb2_queue_init(q); } int rkisp1_params_register(struct rkisp1_device *rkisp1)