From patchwork Mon Jun 3 08:26:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wu, Wentong" X-Patchwork-Id: 102147 Received: from am.mirrors.kernel.org ([147.75.80.249]) by linuxtv.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sE2go-0006YW-2z for patchwork@linuxtv.org; Mon, 03 Jun 2024 08:05:11 +0000 Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 04E2F1F2151D for ; Mon, 3 Jun 2024 08:05:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8FA2553E37; Mon, 3 Jun 2024 08:05:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Zx4O0Ntq" X-Original-To: linux-media@vger.kernel.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BABA853E31 for ; Mon, 3 Jun 2024 08:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717401906; cv=none; b=f1RHMhDzjgx3xX37RDQD6AIxUf/Iuq7XMnAC8X9dOJgTnJsoKzzgT1LOgEgR7aRnV3c30+zg/xOvEDQi4kKQudcj1KaXVMEeZVWfVaoRl4UorbkLX8v7KXDK45YJdmbz7PIzu4MJ/eabH/3wFjUM8OXQz2pmlvqABaxBMou7H7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717401906; c=relaxed/simple; bh=neHAif2hPC2f8Ib3q+9GO/k4O2BoUwh6fsZqjyoxgGE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=QzKGcZwI5rJP4q7zFkpTHqjj0SXiBVhHdrU4H7kyN8VgNZFbajoSmtOksBnABsXWq0CbusTpWE7BRoHPuK0aqCuenzRfxuP9o29phIxUqUDLspwEL14aRddS0t/Nc1T9kYwScUf1ZeaQVX2diDTWWe2FYwbqNriBSBJXwmrNk6g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Zx4O0Ntq; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717401904; x=1748937904; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=neHAif2hPC2f8Ib3q+9GO/k4O2BoUwh6fsZqjyoxgGE=; b=Zx4O0NtqUHwY08/IzxNfHBInXBZ1vlLjTbdnYd/JfONndmmurCBNxHFP xFrtRV6TTfxW8ut7HG8gk+O0/zDXOCiS5GlXHRtUVAE+T3X2C2nVZDgCF v728SFkVLsE+p568XjazqNSPHKGRk3x9671/4DSBLB1sr13aGvPpKHKGg 9OHI3qp9/KxQGYOM3F0u8uZ2exNur0oAtu+0wUX/CCa/ysJ6+TLtsRB1y ihdlUy/Rs9Qvn7R0E7thkm4T56ZaPRe2Azs2mWVlVetC7SLKHbbfVBclr sIGd6fv46JUFhXOUxFAAMfx6yhtHNUsuFCUTG0EQOs4qFPE7e6kwrAB+Z w==; X-CSE-ConnectionGUID: 8BqHeaBuTIGoMlXpEKS/sg== X-CSE-MsgGUID: 77V/+dbfTZCi9KsSxAQCAA== X-IronPort-AV: E=McAfee;i="6600,9927,11091"; a="39285026" X-IronPort-AV: E=Sophos;i="6.08,211,1712646000"; d="scan'208";a="39285026" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2024 01:05:04 -0700 X-CSE-ConnectionGUID: HOhYa/7bQ7aHXV0Ti9T08Q== X-CSE-MsgGUID: yb8z75mqSECKq3519uPOIA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,211,1712646000"; d="scan'208";a="36722118" Received: from wentongw-optiplex-8070.sh.intel.com ([10.239.154.12]) by orviesa010.jf.intel.com with ESMTP; 03 Jun 2024 01:05:03 -0700 From: Wentong Wu To: sakari.ailus@linux.intel.com, linux-media@vger.kernel.org Cc: hao.yao@intel.com, Wentong Wu , Jason Chen Subject: [PATCH 1/3] media: ivsc: csi: don't count privacy on as error Date: Mon, 3 Jun 2024 16:26:12 +0800 Message-Id: <20240603082614.1567712-2-wentong.wu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240603082614.1567712-1-wentong.wu@intel.com> References: <20240603082614.1567712-1-wentong.wu@intel.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-LSpam-Score: -3.6 (---) X-LSpam-Report: No, score=-3.6 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,BAYES_00=-1.9,DKIMWL_WL_HIGH=-1,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,SPF_HELO_NONE=0.001,SPF_PASS=-0.001 autolearn=ham autolearn_force=no Prior to the ongoing command privacy is on, it would return -1 to indicate the current privacy status, and the ongoing command would be well executed by firmware as well, so this is not error. This patch changes its behavior to notify privacy on directly by V4L2 privacy control instead of reporting error. Fixes: 29006e196a56 ("media: pci: intel: ivsc: Add CSI submodule") Reported-by: Hao Yao Signed-off-by: Wentong Wu Tested-by: Jason Chen --- drivers/media/pci/intel/ivsc/mei_csi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/intel/ivsc/mei_csi.c b/drivers/media/pci/intel/ivsc/mei_csi.c index 89b582a221ab..004ebab0b814 100644 --- a/drivers/media/pci/intel/ivsc/mei_csi.c +++ b/drivers/media/pci/intel/ivsc/mei_csi.c @@ -190,7 +190,11 @@ static int mei_csi_send(struct mei_csi *csi, u8 *buf, size_t len) /* command response status */ ret = csi->cmd_response.status; - if (ret) { + if (ret == -1) { + /* notify privacy on instead of reporting error */ + ret = 0; + v4l2_ctrl_s_ctrl(csi->privacy_ctrl, CSI_PRIVACY_ON); + } else if (ret) { ret = -EINVAL; goto out; }