dt-bindings: i2c: maxim,max96712: Add compatible for MAX96724

Message ID 20240527132216.1681903-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State New
Headers
Series dt-bindings: i2c: maxim,max96712: Add compatible for MAX96724 |

Commit Message

Niklas Söderlund May 27, 2024, 1:22 p.m. UTC
  The MAX96712 and MAX96724 are almost identical and can be supported by
the same driver, add a compatible for MAX96724.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 .../devicetree/bindings/media/i2c/maxim,max96712.yaml        | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
  

Comments

Conor Dooley May 27, 2024, 4:34 p.m. UTC | #1
On Mon, May 27, 2024 at 03:22:16PM +0200, Niklas Söderlund wrote:
> The MAX96712 and MAX96724 are almost identical and can be supported by
> the same driver, add a compatible for MAX96724.

What does "almost identical" mean? I don't see another patch here adding
the driver support, which makes me wonder if this was intended to be a
fallback to the existing device... Ohh wait, the other patch is here:
https://lore.kernel.org/all/20240527133410.1690169-1-niklas.soderlund+renesas@ragnatech.se/

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Put it in a series next time (and mention what actually is different in
your commit message).

Thanks,
Conor.

> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>  .../devicetree/bindings/media/i2c/maxim,max96712.yaml        | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> index 6c72e77b927c..26f85151afbd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> @@ -25,7 +25,10 @@ description: |
>  
>  properties:
>    compatible:
> -    const: maxim,max96712
> +    items:
> +      - enum:
> +          - maxim,max96712
> +          - maxim,max96724
>  
>    reg:
>      description: I2C device address
> -- 
> 2.45.1
>
  
Krzysztof Kozlowski May 27, 2024, 6:56 p.m. UTC | #2
On 27/05/2024 15:22, Niklas Söderlund wrote:
> The MAX96712 and MAX96724 are almost identical and can be supported by
> the same driver, add a compatible for MAX96724.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>  .../devicetree/bindings/media/i2c/maxim,max96712.yaml        | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> index 6c72e77b927c..26f85151afbd 100644
> --- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
> @@ -25,7 +25,10 @@ description: |
>  
>  properties:
>    compatible:
> -    const: maxim,max96712
> +    items:

Why adding items?

Where is any user of this binding? Please stop posting some random
binding changes without users.

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
index 6c72e77b927c..26f85151afbd 100644
--- a/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/maxim,max96712.yaml
@@ -25,7 +25,10 @@  description: |
 
 properties:
   compatible:
-    const: maxim,max96712
+    items:
+      - enum:
+          - maxim,max96712
+          - maxim,max96724
 
   reg:
     description: I2C device address