dt-bindings: media: renesas,csi2: Add binding for V4M

Message ID 20240527132046.1680595-1-niklas.soderlund+renesas@ragnatech.se (mailing list archive)
State New
Headers
Series dt-bindings: media: renesas,csi2: Add binding for V4M |

Commit Message

Niklas Söderlund May 27, 2024, 1:20 p.m. UTC
  Document support for the CSI-2 module in the Renesas V4M (r8a779h0) SoC.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 Documentation/devicetree/bindings/media/renesas,csi2.yaml | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Conor Dooley May 27, 2024, 4:35 p.m. UTC | #1
On Mon, May 27, 2024 at 03:20:46PM +0200, Niklas Söderlund wrote:
> Document support for the CSI-2 module in the Renesas V4M (r8a779h0) SoC.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Another one not in a series, this should be with:
https://lore.kernel.org/all/20240527133221.1688830-8-niklas.soderlund+renesas@ragnatech.se/
Why isn't it?
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Send it with the driver next time,
Conor.

> ---
>  Documentation/devicetree/bindings/media/renesas,csi2.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> index 977ab188d654..80b77875874d 100644
> --- a/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,csi2.yaml
> @@ -32,6 +32,7 @@ properties:
>            - renesas,r8a77990-csi2 # R-Car E3
>            - renesas,r8a779a0-csi2 # R-Car V3U
>            - renesas,r8a779g0-csi2 # R-Car V4H
> +          - renesas,r8a779h0-csi2 # R-Car V4M
>  
>    reg:
>      maxItems: 1
> -- 
> 2.45.1
>
  
Krzysztof Kozlowski May 27, 2024, 6:55 p.m. UTC | #2
On 27/05/2024 18:35, Conor Dooley wrote:
> On Mon, May 27, 2024 at 03:20:46PM +0200, Niklas Söderlund wrote:
>> Document support for the CSI-2 module in the Renesas V4M (r8a779h0) SoC.
>>
>> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> 
> Another one not in a series, this should be with:
> https://lore.kernel.org/all/20240527133221.1688830-8-niklas.soderlund+renesas@ragnatech.se/

Niklas,

So you send three or four separate one-patch-sets for single compatible,
without any links or hints about driver submission which apparently goes
in parallel with impression of undocumented compatibles.

That's not the way.

First, if you insist on sending this separate for whatever reason, this
should have been ONE PATCHSET with cover letter (explanation + links to
users). There are no links: neither here, nor in driver submission.

Second, bindings GO WITH DRIVERS, so sending drivers without bindings is
posting undocumented compatibles. I would reject such patches to my
subsystem, because checkpatch would complain that you have undocumented
bindings.

Please resend entire series together - drivers or bindings. For every
separate submission, e.g. DTS separate from the binding which is quite
expected for media, network and USB, please always link to the binding.


Best regards,
Krzysztof
  
Geert Uytterhoeven June 4, 2024, 7:29 a.m. UTC | #3
On Mon, May 27, 2024 at 3:21 PM Niklas Söderlund
<niklas.soderlund+renesas@ragnatech.se> wrote:
> Document support for the CSI-2 module in the Renesas V4M (r8a779h0) SoC.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
  

Patch

diff --git a/Documentation/devicetree/bindings/media/renesas,csi2.yaml b/Documentation/devicetree/bindings/media/renesas,csi2.yaml
index 977ab188d654..80b77875874d 100644
--- a/Documentation/devicetree/bindings/media/renesas,csi2.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,csi2.yaml
@@ -32,6 +32,7 @@  properties:
           - renesas,r8a77990-csi2 # R-Car E3
           - renesas,r8a779a0-csi2 # R-Car V3U
           - renesas,r8a779g0-csi2 # R-Car V4H
+          - renesas,r8a779h0-csi2 # R-Car V4M
 
   reg:
     maxItems: 1