[1/3] dt-bindings: media: rockchip,vpu: Document RK3128 compatible

Message ID 20240523185633.71355-2-knaerzche@gmail.com (mailing list archive)
State TODO
Delegated to: Sebastian Fricke
Headers
Series Add VPU support for RK3128 |

Commit Message

Alex Bee May 23, 2024, 6:56 p.m. UTC
  The integration for this SoC is similar to RK3066/RK3188.

Document it's compatible.

Signed-off-by: Alex Bee <knaerzche@gmail.com>
---
 Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
  

Comments

Krzysztof Kozlowski May 23, 2024, 8:34 p.m. UTC | #1
On 23/05/2024 20:56, Alex Bee wrote:
> The integration for this SoC is similar to RK3066/RK3188.
> 
> Document it's compatible.
> 
> Signed-off-by: Alex Bee <knaerzche@gmail.com>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  
Heiko Stübner May 28, 2024, 8:19 a.m. UTC | #2
Am Donnerstag, 23. Mai 2024, 20:56:31 CEST schrieb Alex Bee:
> The integration for this SoC is similar to RK3066/RK3188.
> 
> Document it's compatible.
> 
> Signed-off-by: Alex Bee <knaerzche@gmail.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Media people, can you apply this patch alone from the series?

Thanks
Heiko

> ---
>  Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> index c57e1f488895..d1b47b14ca57 100644
> --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
> @@ -26,7 +26,9 @@ properties:
>            - rockchip,rk3568-vpu
>            - rockchip,rk3588-av1-vpu
>        - items:
> -          - const: rockchip,rk3188-vpu
> +          - enum:
> +              - rockchip,rk3128-vpu
> +              - rockchip,rk3188-vpu
>            - const: rockchip,rk3066-vpu
>        - items:
>            - const: rockchip,rk3228-vpu
>
  
Sebastian Fricke May 28, 2024, 8:37 a.m. UTC | #3
Hey Heiko,

On 28.05.2024 10:19, Heiko Stübner wrote:
>Am Donnerstag, 23. Mai 2024, 20:56:31 CEST schrieb Alex Bee:
>> The integration for this SoC is similar to RK3066/RK3188.
>>
>> Document it's compatible.
>>
>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>
>Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
>Media people, can you apply this patch alone from the series?

Yes, will do got this on my list already :).

>
>Thanks
>Heiko

Regards,
Sebastian

>
>> ---
>>  Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
>> index c57e1f488895..d1b47b14ca57 100644
>> --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
>> @@ -26,7 +26,9 @@ properties:
>>            - rockchip,rk3568-vpu
>>            - rockchip,rk3588-av1-vpu
>>        - items:
>> -          - const: rockchip,rk3188-vpu
>> +          - enum:
>> +              - rockchip,rk3128-vpu
>> +              - rockchip,rk3188-vpu
>>            - const: rockchip,rk3066-vpu
>>        - items:
>>            - const: rockchip,rk3228-vpu
>>
>
>
>
>
>
  
Alex Bee June 10, 2024, 1:56 p.m. UTC | #4
Hi,

Am 28.05.24 um 10:37 schrieb Sebastian Fricke:
> Hey Heiko,
>
> On 28.05.2024 10:19, Heiko Stübner wrote:
>> Am Donnerstag, 23. Mai 2024, 20:56:31 CEST schrieb Alex Bee:
>>> The integration for this SoC is similar to RK3066/RK3188.
>>>
>>> Document it's compatible.
>>>
>>> Signed-off-by: Alex Bee <knaerzche@gmail.com>
>>
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>>
>> Media people, can you apply this patch alone from the series?
>
> Yes, will do got this on my list already :).
>
is there anything holding you back from applying this? It's really only the
bindings which go though the media tree (i.e. this patch) and it has
been acked and reviewed some weeks ago. It'd be great if we could add the
vpu to the SoC DT before 6.11 merge window opens but the addition depends
on the compatible to be documented. Please let me know if there's anything
left to do for me.

Alex
>>
>> Thanks
>> Heiko
>
> Regards,
> Sebastian
>
>>
>>> ---
>>>  Documentation/devicetree/bindings/media/rockchip-vpu.yaml | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml 
>>> b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
>>> index c57e1f488895..d1b47b14ca57 100644
>>> --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
>>> +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
>>> @@ -26,7 +26,9 @@ properties:
>>>            - rockchip,rk3568-vpu
>>>            - rockchip,rk3588-av1-vpu
>>>        - items:
>>> -          - const: rockchip,rk3188-vpu
>>> +          - enum:
>>> +              - rockchip,rk3128-vpu
>>> +              - rockchip,rk3188-vpu
>>>            - const: rockchip,rk3066-vpu
>>>        - items:
>>>            - const: rockchip,rk3228-vpu
>>>
>>
>>
>>
>>
>>
  

Patch

diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
index c57e1f488895..d1b47b14ca57 100644
--- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml
@@ -26,7 +26,9 @@  properties:
           - rockchip,rk3568-vpu
           - rockchip,rk3588-av1-vpu
       - items:
-          - const: rockchip,rk3188-vpu
+          - enum:
+              - rockchip,rk3128-vpu
+              - rockchip,rk3188-vpu
           - const: rockchip,rk3066-vpu
       - items:
           - const: rockchip,rk3228-vpu