| Message ID | 20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com (mailing list archive) |
|---|---|
| State | New |
| Headers |
Received: from sy.mirrors.kernel.org ([147.75.48.161])
by linuxtv.org with esmtps (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.96)
(envelope-from
<linux-media+bounces-4324-patchwork=linuxtv.org@vger.kernel.org>)
id 1rUMOG-0006fT-0b
for patchwork@linuxtv.org;
Mon, 29 Jan 2024 07:49:14 +0000
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sy.mirrors.kernel.org (Postfix) with ESMTPS id AF9B5B22152
for <patchwork@linuxtv.org>; Mon, 29 Jan 2024 07:49:09 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 965414EB4F;
Mon, 29 Jan 2024 07:49:03 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com
header.b="zD0JfOPJ"
X-Original-To: linux-media@vger.kernel.org
Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com
[209.85.218.49])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F9F54EB35
for <linux-media@vger.kernel.org>; Mon, 29 Jan 2024 07:49:01 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=209.85.218.49
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1706514543; cv=none;
b=WphIHJyv25NFgwIztNqW4AUJXB3l0hzo3BnZrzI9rDCCfUoUUtGJmp9iUxD0eOH7ex8jwLK+O5TYBps6f1VBNp1Hrt+xh2fw4pA4kuus7b4mI6y5H8IdVdiQUEEK7k0trZjRsdaKkfVttu9AKVpRHnBnpmfdm7LZ6krYpv8+DWY=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1706514543; c=relaxed/simple;
bh=BKP83D9yJgO7dHlibnyMa09vHevxppr0G+06k+2XFWc=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc;
b=jF7eEBpU6ZpHQkEgUg2NhMbDQi5DBvytOarDXZOFc/xo4yDOO5urRM9NILn5aySm+UTBvKfI8B0VTFNrrjZV00yZ5XBaPHOcmUHC2VHiGZv+dc/tnBu0dkgIeivR/SpylD4jq+FC03fs5ljvTZST89TviqMyzLuhYm8dgY1FPx4=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=fairphone.com;
spf=pass smtp.mailfrom=fairphone.com;
dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com
header.b=zD0JfOPJ; arc=none smtp.client-ip=209.85.218.49
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=fairphone.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=fairphone.com
Received: by mail-ej1-f49.google.com with SMTP id
a640c23a62f3a-a357cba4a32so117271866b.2
for <linux-media@vger.kernel.org>;
Sun, 28 Jan 2024 23:49:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=fairphone.com; s=fair; t=1706514539; x=1707119339;
darn=vger.kernel.org;
h=cc:to:message-id:content-transfer-encoding:mime-version:subject
:date:from:from:to:cc:subject:date:message-id:reply-to;
bh=hi3wdBPHy9dOJfUItOIZktdrEsNa9te/nL1WfaDI3y0=;
b=zD0JfOPJHHPGaXfIawDeUuiT7Jl4xsIl3OqLLbJjuY0pY0GjUKidfiElXlN8PB/2tj
eSvjXBE/bHQEHKrpvrjTC4OkUif2mFkmV2t/t6xwwedWejM0f8Cfu+TuUHzuPRKr9/9n
uOC3185PWvH0pPa8z4NyTF/x1SRhc9e8Ayad204t8CfbvKl/9aSz9rynbDiBsOn6gl+X
9UP3kMwoTrXzFZcPUAu5GH1cxN7ZrbfQHy0N+2j5rx27q5VtrXQokpXf3uCWA0O3I3Xg
I3Bi5K1Bm7gF/K5muQ2K5tne61BftSTAqGyJQ+VTCBz9WGduSNkH7XqGXb1w73rsXUb7
x/ZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1706514539; x=1707119339;
h=cc:to:message-id:content-transfer-encoding:mime-version:subject
:date:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=hi3wdBPHy9dOJfUItOIZktdrEsNa9te/nL1WfaDI3y0=;
b=n340gyCz83ImDtMAV2OEezc9sMFmAJgci1/GoDILPUo9AhiezsD0ncsmkd6/m8PMz1
x6lzOyXxe+3WLb0j4DNfe3ZL9/eZ3VRpjkBzP7yW37dWRZbJfBmXMlbJopc1eCPB0gnC
99P+prksqKIMsJs0CwZ/MRA1LPsyJy7/HpbttQ0NAo1YrViG8kxjK2j0/XqszhFHJCst
THSswTl2/PigajF6lQ+hoxgE38p9aoaCsWZQq4S0hGznNEjCAQsfihn+vx4yNmu2PmS5
WvxhdR8VxyVLp5BYaNHL4b2nKPcSuc4EaZtBV1hCnzSIw3lALHokLI3sGgtFMD1l8ret
Kf/g==
X-Gm-Message-State: AOJu0YyNfdMC5PT71UDubUY9rt24t1Kt8okyaH+Sd8rrlbt+VzevBx8H
XRSS3AEYmsBklGYgi2oGjHoicTE0GZ91p2JrlHiaKLqhXZCcDye0Uznh2nwPBqI=
X-Google-Smtp-Source:
AGHT+IHk+mC/fG7pO9q79H3dEN8aAlJyGvqAHmPJhChitf/sDZtgl4y8tPnRH+IhsiPE5Sa2TKqS2g==
X-Received: by 2002:a17:906:a14c:b0:a35:d2f8:4927 with SMTP id
bu12-20020a170906a14c00b00a35d2f84927mr590202ejb.70.1706514539677;
Sun, 28 Jan 2024 23:48:59 -0800 (PST)
Received: from otso.luca.vpn.lucaweiss.eu (dhcp-089-099-055-216.chello.nl.
[89.99.55.216])
by smtp.gmail.com with ESMTPSA id
l13-20020a1709066b8d00b00a32429e455asm3679881ejr.175.2024.01.28.23.48.58
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 28 Jan 2024 23:48:59 -0800 (PST)
From: Luca Weiss <luca.weiss@fairphone.com>
Date: Mon, 29 Jan 2024 08:48:54 +0100
Subject: [PATCH] media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU
entry
Precedence: bulk
X-Mailing-List: linux-media@vger.kernel.org
List-Id: <linux-media.vger.kernel.org>
List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <20240129-sc7280-venus-bindings-v1-1-20a9ba194c60@fairphone.com>
X-B4-Tracking: v=1; b=H4sIAGVYt2UC/x3MMQqAMAxA0atIZgM1SLVeRRzURs0SpUERxLtbH
N/w/wPGSdigKx5IfInJrhlVWcC8jboySswGclS7igLa3FDr8GI9DSfRKLoaevY0huDJRYbcHok
Xuf9vP7zvBwnbDmZnAAAA
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Luca Weiss <luca.weiss@fairphone.com>
X-Mailer: b4 0.12.4
X-LSpam-Score: -3.0 (---)
X-LSpam-Report: No,
score=-3.0 required=5.0 tests=ARC_SIGNED=0.001,ARC_VALID=-0.1,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DMARC_PASS=-0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3,SPF_HELO_NONE=0.001,SPF_PASS=-0.001
autolearn=ham autolearn_force=no
|
| Series |
media: dt-bindings: qcom,sc7280-venus: Allow one IOMMU entry
|
|
Commit Message
Luca Weiss
Jan. 29, 2024, 7:48 a.m. UTC
Some SC7280-based boards crash when providing the "secure_non_pixel"
context bank, so allow only one iommu in the bindings also.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Reference:
https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/
---
Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 +
1 file changed, 1 insertion(+)
---
base-commit: 596764183be8ebb13352b281a442a1f1151c9b06
change-id: 20240129-sc7280-venus-bindings-6e62a99620de
Best regards,
Comments
On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote: > Some SC7280-based boards crash when providing the "secure_non_pixel" > context bank, so allow only one iommu in the bindings also. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Do we have any idea why this happens? How is someone supposed to know whether or not their system requires you to only provide one iommu? Yes, a crash might be the obvious answer, but is there a way of knowing without the crashes? Cheers, Conor. > --- > Reference: > https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ > --- > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > index 8f9b6433aeb8..10c334e6b3dc 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > @@ -43,6 +43,7 @@ properties: > - const: vcodec_bus > > iommus: > + minItems: 1 > maxItems: 2 > > interconnects: > > --- > base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 > change-id: 20240129-sc7280-venus-bindings-6e62a99620de > > Best regards, > -- > Luca Weiss <luca.weiss@fairphone.com> >
On Mon Jan 29, 2024 at 6:37 PM CET, Conor Dooley wrote: > On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote: > > Some SC7280-based boards crash when providing the "secure_non_pixel" > > context bank, so allow only one iommu in the bindings also. > > > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > > Do we have any idea why this happens? How is someone supposed to know > whether or not their system requires you to only provide one iommu? > Yes, a crash might be the obvious answer, but is there a way of knowing > without the crashes? +CC Vikash Garodia Unfortunately I don't really have much more information than this message here: https://lore.kernel.org/linux-arm-msm/ff021f49-f81b-0fd1-bd2c-895dbbb03d56@quicinc.com/ And see also the following replies for a bit more context, like this one: https://lore.kernel.org/linux-arm-msm/a4e8b531-49f9-f4a1-51cb-e422c56281cc@quicinc.com/ Maybe Vikash can add some more info regarding this. Regards Luca > > Cheers, > Conor. > > > --- > > Reference: > > https://lore.kernel.org/linux-arm-msm/20231201-sc7280-venus-pas-v3-2-bc132dc5fc30@fairphone.com/ > > --- > > Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > index 8f9b6433aeb8..10c334e6b3dc 100644 > > --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml > > @@ -43,6 +43,7 @@ properties: > > - const: vcodec_bus > > > > iommus: > > + minItems: 1 > > maxItems: 2 > > > > interconnects: > > > > --- > > base-commit: 596764183be8ebb13352b281a442a1f1151c9b06 > > change-id: 20240129-sc7280-venus-bindings-6e62a99620de > > > > Best regards, > > -- > > Luca Weiss <luca.weiss@fairphone.com> > >
Hello, On 1/30/2024 1:17 PM, Luca Weiss wrote: > On Mon Jan 29, 2024 at 6:37 PM CET, Conor Dooley wrote: >> On Mon, Jan 29, 2024 at 08:48:54AM +0100, Luca Weiss wrote: >>> Some SC7280-based boards crash when providing the "secure_non_pixel" >>> context bank, so allow only one iommu in the bindings also. >>> >>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> >> >> Do we have any idea why this happens? How is someone supposed to know >> whether or not their system requires you to only provide one iommu? >> Yes, a crash might be the obvious answer, but is there a way of knowing >> without the crashes? > > +CC Vikash Garodia > > Unfortunately I don't really have much more information than this > message here: > https://lore.kernel.org/linux-arm-msm/ff021f49-f81b-0fd1-bd2c-895dbbb03d56@quicinc.com/ > > And see also the following replies for a bit more context, like this > one: > https://lore.kernel.org/linux-arm-msm/a4e8b531-49f9-f4a1-51cb-e422c56281cc@quicinc.com/ > > Maybe Vikash can add some more info regarding this. 0x2184 is a secure SID i.e any transactions with that ID would be access controlled by trustzone (TZ). SC7280 (chromebook) was designed without TZ, while some other DT deriving from SC7280 (like qcm6490) might have TZ. Hence it is good to move the iommu entry from SC7280 to chrome-common. Regards, Vikash
On 29/01/2024 08:48, Luca Weiss wrote: > Some SC7280-based boards crash when providing the "secure_non_pixel" > context bank, so allow only one iommu in the bindings also. > > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml index 8f9b6433aeb8..10c334e6b3dc 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml @@ -43,6 +43,7 @@ properties: - const: vcodec_bus iommus: + minItems: 1 maxItems: 2 interconnects: