diff mbox series

[1/5] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G2UL CSI-2 block

Message ID 20240123121720.294753-2-biju.das.jz@bp.renesas.com (mailing list archive)
State Superseded
Headers
Series Add RZ/G2UL CRU and CSI support |

Commit Message

Biju Das Jan. 23, 2024, 12:17 p.m. UTC 
  Document the CSI-2 block which is part of CRU found in Renesas RZ/G2UL
SoC.

The CSI-2 block on the RZ/G2UL SoC is identical to one found on the
RZ/G2L SoC.

No driver changes are required as generic compatible string
"renesas,rzg2l-csi2" will be used as a fallback on RZ/G2UL SoC.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Conor Dooley Jan. 24, 2024, 5:49 p.m. UTC | #1 
On Tue, Jan 23, 2024 at 12:17:16PM +0000, Biju Das wrote:
> Document the CSI-2 block which is part of CRU found in Renesas RZ/G2UL
> SoC.
> 
> The CSI-2 block on the RZ/G2UL SoC is identical to one found on the
> RZ/G2L SoC.
> 

> No driver changes are required as generic compatible string
> "renesas,rzg2l-csi2" will be used as a fallback on RZ/G2UL SoC.

Not super relevant to the bindings commit tbh.

> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> index 67eea2ac1d22..7faa12fecd5b 100644
> --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> @@ -19,6 +19,7 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - renesas,r9a07g043-csi2       # RZ/G2UL
>            - renesas,r9a07g044-csi2       # RZ/G2{L,LC}
>            - renesas,r9a07g054-csi2       # RZ/V2L
>        - const: renesas,rzg2l-csi2
> -- 
> 2.25.1
>
Biju Das Jan. 25, 2024, 2:17 p.m. UTC | #2 
Hi Conor Dooley,

Thanks for the feedback.

> -----Original Message-----
> From: Conor Dooley <conor@kernel.org>
> Sent: Wednesday, January 24, 2024 5:49 PM
> Subject: Re: [PATCH 1/5] media: dt-bindings: renesas,rzg2l-csi2: Document
> Renesas RZ/G2UL CSI-2 block
> 
> On Tue, Jan 23, 2024 at 12:17:16PM +0000, Biju Das wrote:
> > Document the CSI-2 block which is part of CRU found in Renesas RZ/G2UL
> > SoC.
> >
> > The CSI-2 block on the RZ/G2UL SoC is identical to one found on the
> > RZ/G2L SoC.
> >
> 
> > No driver changes are required as generic compatible string
> > "renesas,rzg2l-csi2" will be used as a fallback on RZ/G2UL SoC.
> 
> Not super relevant to the bindings commit tbh.

I agree driver doesn't have anything to do with bindings other than using
the fallback compatible. From bindings anyway one can get fallback
compatible details for a device. So strictly speaking it is not required.
I will remove this in next version, if there is no objection.

Cheers,
Biju

> 
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Cheers,
> Conor.
> 
> > ---
> >  Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > index 67eea2ac1d22..7faa12fecd5b 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > @@ -19,6 +19,7 @@ properties:
> >    compatible:
> >      items:
> >        - enum:
> > +          - renesas,r9a07g043-csi2       # RZ/G2UL
> >            - renesas,r9a07g044-csi2       # RZ/G2{L,LC}
> >            - renesas,r9a07g054-csi2       # RZ/V2L
> >        - const: renesas,rzg2l-csi2
> > --
> > 2.25.1
> >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
index 67eea2ac1d22..7faa12fecd5b 100644
--- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
@@ -19,6 +19,7 @@  properties:
   compatible:
     items:
       - enum:
+          - renesas,r9a07g043-csi2       # RZ/G2UL
           - renesas,r9a07g044-csi2       # RZ/G2{L,LC}
           - renesas,r9a07g054-csi2       # RZ/V2L
       - const: renesas,rzg2l-csi2