From patchwork Thu Sep 7 16:44:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 94448 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1qeIi6-00Fyek-6o; Thu, 07 Sep 2023 17:22:30 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237076AbjIGRWb (ORCPT + 1 other); Thu, 7 Sep 2023 13:22:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbjIGRW3 (ORCPT ); Thu, 7 Sep 2023 13:22:29 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D4E01FCE for ; Thu, 7 Sep 2023 10:22:01 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2bcc4347d2dso20550201fa.0 for ; Thu, 07 Sep 2023 10:22:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694107268; x=1694712068; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zSVSANzjwjWJL58JqdMOyxf39JxdZOjplNSWyv8wvaY=; b=B0cHCGCxJ99yqqUbAOGyNbHGzCDSiIBrOblkdL0I7V4nPhOjhqlHlISeTfL+jbvpiq HosLOPRuHwbLmlAmBAyGkNkwqFPTExGHDAF4jEhC1tubKTmCDxGvQ2rx/W4HvfuZrBJv 4yIBx/e9KK1jn3lcrExZaKwQOHfQ3LnZhkZvqLkj8mL5gOWhnHQsTfthoWPufCUtXW9v Km9R1KiFAgRDZmTWhJyJHX4Uv/+vrPAmqCG/c2pQGVV2nl6yIu6yh79praKaOkOi5E2X fHovi5UD9uk/Q2WwnQSlJW4b33sWLMp33+tvjbIdeK6jqtiCR6pqzylFYRUPaB/30vbh I8nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694107268; x=1694712068; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zSVSANzjwjWJL58JqdMOyxf39JxdZOjplNSWyv8wvaY=; b=dMvgBXtq/xDfgSfbiX8PcwJPd/U25RGC0dXsGS6TRoXIiochLPpo/R045sGgdKKQzZ nEDXdKrJi4dRTrobpbkoCl7fVr3PCrMeushd4UlkT+MsGkBFeL1KC4pKzZ+AIsn/ZsNr re6bgQy1Qpzip6jEqkozYRJANxDQCLyQEGK+F3qx2m9Hzr3G5gWRIiyZmNDCJPkeJwvq BoJ2g5N5rSlavHuZ9gAJZYTU/9gRja4fNfgAp0YifRxD4Al6egG2ZR4P6lhz/005Pmhq 30yhOAk4wK0Oub0RN3LRc/elu3TAEVqy5akJLsyYJZGWMQSSc9NcMciYTphdigW2Zrbk AZPw== X-Gm-Message-State: AOJu0Yw4XaJVKikGD7ewSodyYuDfniTWGW79OJXIO0O6Z5I1G2kk7tA5 W/i1+8mHP56lViZ1tA/2HQPKWAIhGa3C/1AKSOQ= X-Google-Smtp-Source: AGHT+IHKo1JmOMb4+djt+NKGu6fxIHBbTNo3gqmI+h53oZDKltsofVpbHkVMvWTKSuUVVecRTOFMHQ== X-Received: by 2002:a5d:5643:0:b0:319:7471:2965 with SMTP id j3-20020a5d5643000000b0031974712965mr5838wrw.21.1694105066449; Thu, 07 Sep 2023 09:44:26 -0700 (PDT) Received: from sagittarius-a.chello.ie (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id d15-20020adffd8f000000b00317ab75748bsm23822145wrr.49.2023.09.07.09.44.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 09:44:26 -0700 (PDT) From: Bryan O'Donoghue To: rfoss@kernel.org, todor.too@gmail.com, bryan.odonoghue@linaro.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, andrey.konovalov@linaro.org Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 09/17] media: qcom: camss: Remove special case for VFE get/put Date: Thu, 7 Sep 2023 17:44:02 +0100 Message-ID: <20230907164410.36651-10-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230907164410.36651-1-bryan.odonoghue@linaro.org> References: <20230907164410.36651-1-bryan.odonoghue@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From sdm845 onwards we need to ensure the VFE is powered on prior to switching on the CSID. Currently the code tests for sdm845, sm8250 and then does get/set. This is not extensible and it turns out is not necessary either since vfe_get and vfe_set reference count. Remove the over-conservative SoC version check. Signed-off-by: Bryan O'Donoghue Suggested-by: Laurent Pinchart Tested-by: Bryan O'Donoghue # rb3 # db410c --- drivers/media/platform/qcom/camss/camss-csid.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c index 99f651e2021cb..02ae3f5cb0c0e 100644 --- a/drivers/media/platform/qcom/camss/camss-csid.c +++ b/drivers/media/platform/qcom/camss/camss-csid.c @@ -159,15 +159,12 @@ static int csid_set_power(struct v4l2_subdev *sd, int on) struct camss *camss = csid->camss; struct device *dev = camss->dev; struct vfe_device *vfe = &camss->vfe[csid->id]; - u32 version = camss->res->version; int ret = 0; if (on) { - if (version == CAMSS_8250 || version == CAMSS_845) { - ret = vfe_get(vfe); - if (ret < 0) - return ret; - } + ret = vfe_get(vfe); + if (ret < 0) + return ret; ret = pm_runtime_resume_and_get(dev); if (ret < 0) @@ -217,8 +214,7 @@ static int csid_set_power(struct v4l2_subdev *sd, int on) regulator_bulk_disable(csid->num_supplies, csid->supplies); pm_runtime_put_sync(dev); - if (version == CAMSS_8250 || version == CAMSS_845) - vfe_put(vfe); + vfe_put(vfe); } return ret;