diff mbox series

[03/30] media: atomisp: Remove isp->need_gfx_throttle field

Message ID	20230513123159.33234-4-hdegoede@redhat.com (mailing list archive)
State	Accepted
Headers	From: Hans de Goede <hdegoede@redhat.com> To: Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, Andy Shevchenko <andy@kernel.org> Cc: Hans de Goede <hdegoede@redhat.com>, Kate Hsuan <hpa@redhat.com>, Tsuchiya Yuto <kitakar@gmail.com>, Yury Luneff <yury.lunev@gmail.com>, Nable <nable.maininbox@googlemail.com>, andrey.i.trufanov@gmail.com, Fabio Aiuto <fabioaiuto83@gmail.com>, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 03/30] media: atomisp: Remove isp->need_gfx_throttle field Date: Sat, 13 May 2023 14:31:32 +0200 Message-Id: <20230513123159.33234-4-hdegoede@redhat.com> In-Reply-To: <20230513123159.33234-1-hdegoede@redhat.com> References: <20230513123159.33234-1-hdegoede@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	media: atomisp: Register only 1 /dev/video# node + cleanups \| [00/30] media: atomisp: Register only 1 /dev/video# node + cleanups [01/30] media: atomisp: Remove res_overflow parameter from atomisp_try_fmt() [02/30] media: atomisp: Remove Continuous capture and SDV run-modes [03/30] media: atomisp: Remove isp->need_gfx_throttle field [04/30] media: atomisp: Drop atomisp_get_css_buf_type() [05/30] media: atomisp: Replace source-pad checks with run-mode checks [06/30] media: atomisp: Register only 1 /dev/video# node [07/30] media: atomisp: Drop atomisp_is_vf_pipe() [08/30] media: atomisp: Rename video_out_preview to video_out [09/30] media: atomisp: Remove source_pad parameter from functions and structs [10/30] media: atomisp: Remove 1 line atomisp_flush_bufs_and_wakeup() helper [11/30] media: atomisp: Remove atomisp_subdev_register_video_nodes() helper [12/30] media: atomisp: Remove a bunch of unused atomisp_css_*() functions [13/30] media: atomisp: Remove unused mipi_frame_size field from atomisp_[sub_]device [14/30] media: atomisp: Remove isp_timeout flag [15/30] media: atomisp: Remove atomisp_sensor_start_stream() [16/30] media: atomisp: Simplify atomisp_[start\|stop]_streaming() [17/30] media: atomisp: Simplify atomisp_css_[start\|stop]() [18/30] media: atomisp: Simplify atomisp_open() and atomisp_release() [19/30] media: atomisp: Simplify atomisp_pipe_check() [20/30] media: atomisp: Turn asd->streaming state tracker into a bool [21/30] media: atomisp: Remove no longer used atomisp_css_flush() [22/30] media: atomisp: Remove atomisp_streaming_count() [23/30] media: atomisp: Simplify atomisp_isr() and recovery_work() [24/30] media: atomisp: Rename atomisp_destroy_pipes_stream_force() to atomisp_destroy_pipes_stream… [25/30] media: atomisp: Allow system suspend to continue with open /dev/video# nodes [26/30] media: atomisp: Remove atomisp_[sub]dev_users() [27/30] media: atomisp: Remove unused css_pipe_id argument from atomisp_css_[start\|stop]() [28/30] media: atomisp: Remove unused atomisp_get_css_pipe_id() function [29/30] media: atomisp: Remove in_reset argument from atomisp_css_start() [30/30] media: atomisp: Set asd.subdev.devnode once from isp_subdev_init_entities()

Commit Message

Hans de Goede May 13, 2023, 12:31 p.m. UTC

  Remove the isp->need_gfx_throttle field it is only ever set and
never read.

Also the code setting it is broken, comparing run_mode->val to
ATOMISP_SUBDEV_PAD_SOURCE_VIDEO which are not of the same type /
not part of the same enum.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c      | 10 ----------
 drivers/staging/media/atomisp/pci/atomisp_fops.c     |  1 -
 drivers/staging/media/atomisp/pci/atomisp_internal.h |  2 --
 3 files changed, 13 deletions(-)

diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index bb49d6f2e67f..ed1a534b7c05 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -4693,16 +4693,6 @@  int atomisp_set_fmt(struct video_device *vdev, struct v4l2_format *f)
 	f->fmt.pix = pipe->pix;
 	f->fmt.pix.priv = PAGE_ALIGN(pipe->pix.width *
 				     pipe->pix.height * 2);
-
-	/*
-	 * If in video 480P case, no GFX throttle
-	 */
-	if (asd->run_mode->val == ATOMISP_SUBDEV_PAD_SOURCE_VIDEO &&
-	    f->fmt.pix.width == 720 && f->fmt.pix.height == 480)
-		isp->need_gfx_throttle = false;
-	else
-		isp->need_gfx_throttle = true;
-
 	/* Report the needed sizes */
 	f->fmt.pix.sizeimage = pipe->pix.sizeimage;
 	f->fmt.pix.bytesperline = pipe->pix.bytesperline;
diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
index fa362c8a37e8..a95c41d084c2 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
@@ -539,7 +539,6 @@  static void atomisp_dev_init_struct(struct atomisp_device *isp)
 {
 	unsigned int i;
 
-	isp->need_gfx_throttle = true;
 	isp->isp_fatal_error = false;
 	isp->mipi_frame_size = 0;
 
diff --git a/drivers/staging/media/atomisp/pci/atomisp_internal.h b/drivers/staging/media/atomisp/pci/atomisp_internal.h
index 1fac99f4e2b0..e531f0c71a15 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_internal.h
+++ b/drivers/staging/media/atomisp/pci/atomisp_internal.h
@@ -211,8 +211,6 @@  struct atomisp_device {
 
 	spinlock_t lock; /* Protects asd.streaming */
 
-	bool need_gfx_throttle;
-
 	unsigned int mipi_frame_size;
 	const struct atomisp_dfs_config *dfs;
 	unsigned int hpll_freq;