[25/28] media: i2c: ov7740: drop of_match_ptr for ID table

Message ID 20230312131318.351173-25-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Delegated to: Sakari Ailus
Headers
Series [01/28] media: cec: ch7322: drop of_match_ptr for ID table |

Commit Message

Krzysztof Kozlowski March 12, 2023, 1:13 p.m. UTC
  The driver will match mostly by DT table (even thought there is regular
ID table) so there is little benefit in of_match_ptr (this also allows
ACPI matching via PRP0001, even though it might not be relevant here).
This also fixes !CONFIG_OF error:

  drivers/media/i2c/ov7740.c:1203:34: error: ‘ov7740_of_match’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/media/i2c/ov7740.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Laurent Pinchart March 12, 2023, 1:44 p.m. UTC | #1
Hi Krzysztof,

Thank you for the patch.

On Sun, Mar 12, 2023 at 02:13:15PM +0100, Krzysztof Kozlowski wrote:
> The driver will match mostly by DT table (even thought there is regular
> ID table) so there is little benefit in of_match_ptr (this also allows
> ACPI matching via PRP0001, even though it might not be relevant here).
> This also fixes !CONFIG_OF error:
> 
>   drivers/media/i2c/ov7740.c:1203:34: error: ‘ov7740_of_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/ov7740.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c
> index c9fd9b0bc54a..42121916d25f 100644
> --- a/drivers/media/i2c/ov7740.c
> +++ b/drivers/media/i2c/ov7740.c
> @@ -1210,7 +1210,7 @@ static struct i2c_driver ov7740_i2c_driver = {
>  	.driver = {
>  		.name = "ov7740",
>  		.pm = &ov7740_pm_ops,
> -		.of_match_table = of_match_ptr(ov7740_of_match),
> +		.of_match_table = ov7740_of_match,
>  	},
>  	.probe_new = ov7740_probe,
>  	.remove   = ov7740_remove,
  

Patch

diff --git a/drivers/media/i2c/ov7740.c b/drivers/media/i2c/ov7740.c
index c9fd9b0bc54a..42121916d25f 100644
--- a/drivers/media/i2c/ov7740.c
+++ b/drivers/media/i2c/ov7740.c
@@ -1210,7 +1210,7 @@  static struct i2c_driver ov7740_i2c_driver = {
 	.driver = {
 		.name = "ov7740",
 		.pm = &ov7740_pm_ops,
-		.of_match_table = of_match_ptr(ov7740_of_match),
+		.of_match_table = ov7740_of_match,
 	},
 	.probe_new = ov7740_probe,
 	.remove   = ov7740_remove,