From patchwork Wed Jan 11 08:52:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yunke Cao X-Patchwork-Id: 88698 X-Patchwork-Delegate: laurent.pinchart@ideasonboard.com Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1pFWqw-00Esot-VV; Wed, 11 Jan 2023 08:53:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235980AbjAKIwx (ORCPT + 1 other); Wed, 11 Jan 2023 03:52:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232390AbjAKIwu (ORCPT ); Wed, 11 Jan 2023 03:52:50 -0500 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C12D810543 for ; Wed, 11 Jan 2023 00:52:46 -0800 (PST) Received: by mail-pl1-x632.google.com with SMTP id d3so16060833plr.10 for ; Wed, 11 Jan 2023 00:52:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ymU4BRjSxrJhQL9DkjeeGrHUVG3DM8ZWjHKpQC1Y2Y0=; b=bFcukNq+D/b3ltetYdCgFtoSvKiJroUkbRgkIw6ahhoIUwyeqiIpCEPsBLopzwgmkf 0sD9QkBsFBrRFK7O637OjsIkdD34SrPuukjHJ1d0WtulZHAparow0YX+6Zi9GkvzvxPU mq7h8rpMSHOHEJmaI6xG4uqx4JIRnwaQSEKuY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ymU4BRjSxrJhQL9DkjeeGrHUVG3DM8ZWjHKpQC1Y2Y0=; b=50NupSQRvaPaEp3q7JI50gy8HotfdM4XbSp3+ec9KPZJdAWp+eVTxnv4FSLPybDo02 xN+FmrMaxpznL3ehC2lOoJucxq7X0hDcetoEMxALvRXSGM7rF/KGHyuXTpoJA7n9UJfg q5c1J+GR8paI+fvILaxMKBwcTJcCSSrcbSfqR6sSTv+f2/vxvSFvF7qn0yBCloWsZesg mojQ2+1Tp8bBpvJ0HvvwW4Nin1KUHtfXWIuEXxVlnMilQJxWxzjci72BswDSW5fV0jAO r+HC7nT9c07s3g/+LknJSKQODD6Pp/2upVrdHNU4yDcFk3TrALO+wnjbeIpca31Ubz+B OPhw== X-Gm-Message-State: AFqh2kpX8n7HCsa+py6Igp8aW+68vYtLHrjm7WGVzs3QwmFlWrtXEiWm ZeOfjIcwNUySChZsuh0JENJ+Cw== X-Google-Smtp-Source: AMrXdXsB6chUTybxsqhARKcbbZSOOrjGaMSYW18Y/R/jRnRuuEqa9fVyErkuiLO6kJDtPe7UGXjpXQ== X-Received: by 2002:a17:902:ba93:b0:191:282:5d72 with SMTP id k19-20020a170902ba9300b0019102825d72mr1496801pls.51.1673427166313; Wed, 11 Jan 2023 00:52:46 -0800 (PST) Received: from yunkec1.tok.corp.google.com ([2401:fa00:8f:203:c84:581:fd3a:b32b]) by smtp.gmail.com with ESMTPSA id ik9-20020a170902ab0900b00183c67844aesm9566612plb.22.2023.01.11.00.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 00:52:46 -0800 (PST) From: Yunke Cao Date: Wed, 11 Jan 2023 17:52:39 +0900 Subject: [PATCH RFC 2/3] media: uvcvideo: remove entity privacy control in the uvc video node MIME-Version: 1.0 Message-Id: <20230111-uvc_privacy_subdev-v1-2-f859ac9a01e3@chromium.org> References: <20230111-uvc_privacy_subdev-v1-0-f859ac9a01e3@chromium.org> In-Reply-To: <20230111-uvc_privacy_subdev-v1-0-f859ac9a01e3@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Ricardo Ribalda , Hans Verkuil Cc: Yunke Cao , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Sakari Ailus , Ricardo Ribalda X-Mailer: b4 0.11.0-dev-4d321 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_HIGH=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no For privacy_gpio, do not expose V4L2_CID_PRIVACY to userspace as a control of the video node. Signed-off-by: Yunke Cao --- drivers/media/usb/uvc/uvc_ctrl.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index c95a2229f4fa..77c5ff19add8 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -348,14 +348,6 @@ static const struct uvc_control_info uvc_ctrls[] = { | UVC_CTRL_FLAG_RESTORE | UVC_CTRL_FLAG_AUTO_UPDATE, }, - { - .entity = UVC_GUID_EXT_GPIO_CONTROLLER, - .selector = UVC_CT_PRIVACY_CONTROL, - .index = 0, - .size = 1, - .flags = UVC_CTRL_FLAG_GET_CUR - | UVC_CTRL_FLAG_AUTO_UPDATE, - }, }; static const u32 uvc_control_classes[] = { @@ -710,15 +702,6 @@ static const struct uvc_control_mapping uvc_ctrl_mappings[] = { .v4l2_type = V4L2_CTRL_TYPE_BOOLEAN, .data_type = UVC_CTRL_DATA_TYPE_BOOLEAN, }, - { - .id = V4L2_CID_PRIVACY, - .entity = UVC_GUID_EXT_GPIO_CONTROLLER, - .selector = UVC_CT_PRIVACY_CONTROL, - .size = 1, - .offset = 0, - .v4l2_type = V4L2_CTRL_TYPE_BOOLEAN, - .data_type = UVC_CTRL_DATA_TYPE_BOOLEAN, - }, }; static const struct uvc_control_mapping uvc_ctrl_mappings_uvc11[] = {