From patchwork Wed Sep 14 15:32:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorota Czaplejewicz X-Patchwork-Id: 86082 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1oYUNh-009hFV-K2; Wed, 14 Sep 2022 15:32:53 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbiINPct (ORCPT + 1 other); Wed, 14 Sep 2022 11:32:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbiINPcs (ORCPT ); Wed, 14 Sep 2022 11:32:48 -0400 Received: from comms.puri.sm (comms.puri.sm [159.203.221.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4186F48CAB; Wed, 14 Sep 2022 08:32:44 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 11A11E0E70; Wed, 14 Sep 2022 08:32:44 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Poz8d05vzgzF; Wed, 14 Sep 2022 08:32:43 -0700 (PDT) Date: Wed, 14 Sep 2022 17:32:36 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1663169563; bh=uuekv8jywcRwSksg0sQmwcM0xjq7DU2XBG5Ob1vzVl4=; h=Date:From:To:Subject:From; b=OkUJ3VqYSP1qeb3ENwgc6YjP9UfCi1JhEp/XtdeAl/0PP+aONZ9l/UMtF2u1ZrE/A 3So+tYWo8C5RuIU93EZqd3lN8gKfKnjDih/PYiJj1gPK0wdqKY/jfJDVQqSUyO+rr2 pli8BvBfeyIcr7b6TAqCIQv5icuc5/fMw74cdyfjUxkckhn2Z0QU0cQlO8MEhCRSYf 7y8MEkmOoP+YupcjitsBaU1ixQ/r19uC0U7PgTwG1f3fLyKX9RHemaJ0OVbrWBVZQ1 LlywltdOpwAXNbEWyJ9Weq6XuOAW4w4/GJezqRlDF41YFANDydNgeKesBS+juzHxaC YGKh5+uy/YoSg== From: Dorota Czaplejewicz To: Laurent Pinchart , Steve Longerbeam , Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@puri.sm, phone-devel@vger.kernel.org Subject: [PATCHv2 1/1] media: imx: Round line size to 4 bytes Message-ID: <20220914173236.3040f3a1.dorota.czaplejewicz@puri.sm> Organization: Purism MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no Section 13.7.6.13 "CSI Image Parameter Register" of the i.MX 8M Quad Applications Processors Reference Manual states that the line size should be divisible by 8 bytes. However, the hardware also accepts sizes divisible by 4 bytes, which are needed to fully utilize the S5K3L6XX sensors. This patch accepts line sizes divisible 4-bytes in non-planar mode. --- Hello, the Librem 5 is using an out-of-tree driver for s5k3l6xx, and rounding to 4 is optimal to operate it. Please ignore my previous series, I sent it by mistake. Cheers, Dorota Czaplejewicz drivers/staging/media/imx/imx7-media-csi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index a0553c24cce4..af821b410c3f 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -999,10 +999,10 @@ static int imx7_csi_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix, } /* Round up width for minimum burst size */ - width = round_up(mbus->width, 8); + width = round_up(mbus->width, 4); /* Round up stride for IDMAC line start address alignment */ - stride = round_up((width * cc->bpp) >> 3, 8); + stride = round_up((width * cc->bpp) >> 3, 4); pix->width = width; pix->height = mbus->height;