diff mbox series

[01/13] media: atomisp_gmin_platform: Switch to use acpi_evaluate_dsm_typed()

Message ID 20220821215027.461344-1-hdegoede@redhat.com (mailing list archive)
State Accepted
Headers
Series [01/13] media: atomisp_gmin_platform: Switch to use acpi_evaluate_dsm_typed() |

Commit Message

Hans de Goede Aug. 21, 2022, 9:50 p.m. UTC 
  From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

The acpi_evaluate_dsm_typed() provides a way to check the type of the
object evaluated by _DSM call. Use it instead of open coded variant.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220730155905.90091-1-andriy.shevchenko@linux.intel.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Andy Shevchenko Aug. 21, 2022, 10:31 p.m. UTC | #1 
On Mon, Aug 22, 2022 at 12:50 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Link: https://lore.kernel.org/r/20220730155905.90091-1-andriy.shevchenko@linux.intel.com
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> Tested-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Thanks!
I believe the v2 of this patch (when it was sent standalone) has been
Acked by Sakari. But I might be wrong.
Hans de Goede Aug. 22, 2022, 8:02 a.m. UTC | #2 
Hi,

On 8/22/22 00:31, Andy Shevchenko wrote:
> On Mon, Aug 22, 2022 at 12:50 AM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>>
>> The acpi_evaluate_dsm_typed() provides a way to check the type of the
>> object evaluated by _DSM call. Use it instead of open coded variant.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Link: https://lore.kernel.org/r/20220730155905.90091-1-andriy.shevchenko@linux.intel.com
>> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> Tested-by: Hans de Goede <hdegoede@redhat.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Thanks!
> I believe the v2 of this patch (when it was sent standalone) has been
> Acked by Sakari. But I might be wrong.

You are right:
https://lore.kernel.org/linux-media/Yud2hzq3JQBzf+oK@paasikivi.fi.intel.com/

So let me add that here, then patchwork should pick it up:

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Regards,

Hans
Andy Shevchenko Aug. 22, 2022, 12:57 p.m. UTC | #3 
On Mon, Aug 22, 2022 at 11:02 AM Hans de Goede <hdegoede@redhat.com> wrote:
> On 8/22/22 00:31, Andy Shevchenko wrote:

...

> So let me add that here, then patchwork should pick it up:
>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

You may also add
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
to all patches, but the 1st (it has already SoB) and commented ones,
which I'm going to do soon.
Andy Shevchenko Aug. 22, 2022, 12:59 p.m. UTC | #4 
On Mon, Aug 22, 2022 at 3:57 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Aug 22, 2022 at 11:02 AM Hans de Goede <hdegoede@redhat.com> wrote:

...

> You may also add
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> to all patches, but the 1st (it has already SoB)

> and commented ones,
> which I'm going to do soon.

(should be read as)
... and non-commented, that become visible after I comment on a
couple, which I'm going to do soon.
diff mbox series

Patch

diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
index 133d7d56fff2..648469de2cdc 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
@@ -1250,16 +1250,14 @@  static int gmin_get_config_dsm_var(struct device *dev,
 	if (!strcmp(var, "CamClk"))
 		return -EINVAL;
 
-	obj = acpi_evaluate_dsm(handle, &atomisp_dsm_guid, 0, 0, NULL);
+	/* Return on unexpected object type */
+	obj = acpi_evaluate_dsm_typed(handle, &atomisp_dsm_guid, 0, 0, NULL,
+				      ACPI_TYPE_PACKAGE);
 	if (!obj) {
 		dev_info_once(dev, "Didn't find ACPI _DSM table.\n");
 		return -EINVAL;
 	}
 
-	/* Return on unexpected object type */
-	if (obj->type != ACPI_TYPE_PACKAGE)
-		return -EINVAL;
-
 #if 0 /* Just for debugging purposes */
 	for (i = 0; i < obj->package.count; i++) {
 		union acpi_object *cur = &obj->package.elements[i];