From patchwork Tue Aug 2 13:26:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Ser X-Patchwork-Id: 85226 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1oIrur-000i4v-A6; Tue, 02 Aug 2022 13:26:33 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236062AbiHBN0a (ORCPT + 1 other); Tue, 2 Aug 2022 09:26:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236225AbiHBN02 (ORCPT ); Tue, 2 Aug 2022 09:26:28 -0400 Received: from mail-4022.proton.ch (mail-4022.proton.ch [185.70.40.22]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24439183A2 for ; Tue, 2 Aug 2022 06:26:27 -0700 (PDT) Date: Tue, 02 Aug 2022 13:26:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail3; t=1659446783; x=1659705983; bh=iCKEnj8Js+5aWwtQbshh2/2JLGurn4Z7wNEfkZEwyEs=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=adogYFCFHgi11nH1oR4Ena8NCAe64GZhE5NG1fBKgwCcNAMdWvhLF0Q9revcneZrv q9K5tMs9xqwPGdBu1Lt1Qmooi7qZTSh/V/DbAQzCSYnZbT841XRMIzteeUXR0X/Hh1 yBaVWPCRberbyHZbDAUXo0E/b6YjV9rlC0MhEcifX8ksjyX54+EC5iOnL1TWbB2NM5 EcKgaw5YVHtu72+f8Ol0blZbsNLgFKxzrL4p91jmACLUmg2YPHgmVJjSV6QaZGYkfu g7snM0H0+RQtvzT5NRM/F2MDLxYUrh6AcJVGBh0gGNN3VD8UDs74/B95rQo6vjbnCN 7Tm74DPCqr1Mw== To: linux-media@vger.kernel.org From: Simon Ser Reply-To: Simon Ser Subject: [PATCH v2] edid-decode: downgrade missing display product name to warning Message-ID: <20220802132613.47141-1-contact@emersion.fr> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no The E-EDID 1.4 spec says: > The model name of the display product may be listed (optional > but recommended) in the Display Product Name (ASCII) String > Descriptor (tag #FCh). So a missing Display Product Name descriptor shouldn't fail conformance. E-EDID 1.3 still requires the monitor name, so keep failing in that case. Signed-off-by: Simon Ser --- v2: keep this a failure for EDID 1.3 parse-base-block.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 582c935652b0303b87ddad4551e6f97f8bb883ac diff --git a/parse-base-block.cpp b/parse-base-block.cpp index 9644577bab70..a27505abec98 100644 --- a/parse-base-block.cpp +++ b/parse-base-block.cpp @@ -1673,7 +1673,7 @@ void edid_state::parse_base_block(const unsigned char *x) do_checksum("", x, EDID_PAGE_SIZE); if (base.edid_minor >= 3) { if (!base.has_name_descriptor) - fail("Missing Display Product Name.\n"); + msg(base.edid_minor >= 4, "Missing Display Product Name.\n"); if ((base.edid_minor == 3 || base.supports_continuous_freq) && !base.has_display_range_descriptor) fail("Missing Display Range Limits Descriptor.\n");