From patchwork Fri Oct 22 10:06:44 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 77962 X-Patchwork-Delegate: hverkuil@xs4all.nl Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1mdrRs-00D1AM-7r; Fri, 22 Oct 2021 10:06:52 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232550AbhJVKJH (ORCPT + 1 other); Fri, 22 Oct 2021 06:09:07 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:51796 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231944AbhJVKJG (ORCPT ); Fri, 22 Oct 2021 06:09:06 -0400 Received: from Monstersaurus.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B711D2BA; Fri, 22 Oct 2021 12:06:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1634897208; bh=vjGCE1iJEOP6vV6D0o3cwyBykC5jl0LSgHg7NnDh2WE=; h=From:To:Cc:Subject:Date:From; b=Y1wO203LGw6PjdKbkmzC6kZ5Cx/aNu38JaYV83xhlT2yHJOOWtG6KQnlmqNtHczdh Iy83GXud7alkNIXRnppNdcnQR/5ZH1rIcALoBM+Wazi2Yubp3302UkL4CjHOpLsZqd pSAo7FxwxIz3ASxJOI4TJo65dN5i9TzRVw9Cdn1E= From: Kieran Bingham To: linux-media@vger.kernel.org Cc: Kieran Bingham , Bluecherry Maintainers , Anton Sviridenko , Andrey Utkin , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] media: tw5864: Disable PCI device when finished Date: Fri, 22 Oct 2021 11:06:44 +0100 Message-Id: <20211022100644.3447-1-kieran.bingham+renesas@ideasonboard.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -3.2 (---) X-LSpam-Report: No, score=-3.2 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_LOW=-0.7 autolearn=ham autolearn_force=no The cleanup in tw5864_finidev() neglected to disable the PCI device after enabling it in tw5864_initdev(). Call pci_disable_device() after releasing the associated resources. Signed-off-by: Kieran Bingham --- drivers/media/pci/tw5864/tw5864-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/pci/tw5864/tw5864-core.c b/drivers/media/pci/tw5864/tw5864-core.c index fee3b7711901..5cae73e6fb9c 100644 --- a/drivers/media/pci/tw5864/tw5864-core.c +++ b/drivers/media/pci/tw5864/tw5864-core.c @@ -334,6 +334,7 @@ static void tw5864_finidev(struct pci_dev *pci_dev) /* release resources */ iounmap(dev->mmio); pci_release_regions(pci_dev); + pci_disable_device(pci_dev); v4l2_device_unregister(&dev->v4l2_dev); }