From patchwork Thu Oct 7 13:56:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 77540 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1mYTsv-009Fhl-8V; Thu, 07 Oct 2021 13:56:33 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241651AbhJGN6V (ORCPT + 1 other); Thu, 7 Oct 2021 09:58:21 -0400 Received: from phobos.denx.de ([85.214.62.61]:59828 "EHLO phobos.denx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241895AbhJGN6K (ORCPT ); Thu, 7 Oct 2021 09:58:10 -0400 Received: from localhost.localdomain (unknown [IPv6:2804:14c:485:504a:a293:7842:1da9:a906]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6024F80644; Thu, 7 Oct 2021 15:56:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1633614976; bh=43AkR0XBW3VazJuFE5kJ/6Qc8SLYasfSn53jK6dNziw=; h=From:To:Cc:Subject:Date:From; b=JdjId6pnZUBwZxnBcKubbO5/zuArmVAQ7AcQTlsXzZT3V4x8OOx+p0N3QfBo6jNHw EZS+bRhgYPti4O7KuKiyayLtn+BJR9KmM4eyosvdGdpGJQM0ppUEwg+Ve91D038S6k +w4M5nJmooMVTXi6+ElFIFaMkNqzzPq1Zz5Y66cV4R1/eFN1w8NWLMIcUnIpj5Rb44 cR+HXhKk8Zd14vTmgrwmLBL+rtVbh0w1eTjbeq07VHOi7p4GPWS3ClE6O4LD9OZzOf nQQAQC6Y9baBRPbGJksRwVGzJ6NwEYwUaR90O+XfyTwYR3WKAYEILi8IFSudQZuyzc TYeW7BxMFF8Qw== From: Fabio Estevam To: p.zabel@pengutronix.de Cc: hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, Fabio Estevam Subject: [PATCH] media: imx-pxp: Initialize the spinlock prior to using it Date: Thu, 7 Oct 2021 10:56:01 -0300 Message-Id: <20211007135601.2068291-1-festevam@denx.de> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no After devm_request_threaded_irq() is called there is a chance that an interrupt may occur before the spinlock is initialized, which will trigger a kernel oops. To prevent that, move the initialization of the spinlock prior to requesting the interrupts. Fixes: 51abcf7fdb70 ("media: imx-pxp: add i.MX Pixel Pipeline driver") Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- drivers/media/platform/imx-pxp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c index acfc77f9d58f..7d1768ec7fcd 100644 --- a/drivers/media/platform/imx-pxp.c +++ b/drivers/media/platform/imx-pxp.c @@ -1693,6 +1693,8 @@ static int pxp_probe(struct platform_device *pdev) if (irq < 0) return irq; + spin_lock_init(&dev->irqlock); + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, pxp_irq_handler, IRQF_ONESHOT, dev_name(&pdev->dev), dev); if (ret < 0) { @@ -1710,8 +1712,6 @@ static int pxp_probe(struct platform_device *pdev) goto err_clk; } - spin_lock_init(&dev->irqlock); - ret = v4l2_device_register(&pdev->dev, &dev->v4l2_dev); if (ret) goto err_clk;